New issue
Advanced search Search tips

Issue 849277 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 887659
Owner: ----
Closed: Nov 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Animation Worklet - EffectProxy::setLocalTime converts NaN to large negative TimeDelta

Project Member Reported by smcgruer@chromium.org, Jun 4 2018

Issue description

If you have an animator such as:

registerAnimator("test_animator", class {
  animate(currentTime, effect) {
    effect.localTime = NaN;
  }
});


Then EffectProxy::setLocalTime is called with time_ms == NaN. This ends up with a local_time_ of a large negative delta:

[1:16:0604/114855.148445:INFO:effect_proxy.h(23)] setLocalTime: nan
[1:16:0604/114855.148514:INFO:effect_proxy.h(34)] setLocalTime (result): -9.22337e+12

This then gets clamped to the effect start time. Instead, we should be properly treating this as unresolved.
 

Comment 1 by sunxd@chromium.org, Jun 5 2018

Status: Available (was: Untriaged)
Mergedinto: 887659
Status: Duplicate (was: Available)

Sign in to add a comment