New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849270 link

Starred by 14 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[User Feedback - Stable] Omnibox content not highlighted when selected from a non-focused Chrome window

Project Member Reported by craigtumblison@chromium.org, Jun 4 2018

Issue description

Chrome Version: 67.0.3396.62
OS: Windows

What steps will reproduce the problem?
(1) Open multiple Chrome windows.
(2) Have one window focused, click into the omnibox on a non-focused window.
(3) The non-focused window comes into focus, the cursor is present in the omnibox, but the omnibox text is not highlighted.

What is the expected result?
The omnibox text should be highlighted.

What happens instead?
The cursor appears at the end of the omnibox string.

We're seeing multiple user reports of this behavior on the latest stable build for Windows. I was able to reproduce on a Windows 10 device.

Community:
- https://productforums.google.com/forum/#!topic/chrome/T9DAPvySQHo

Listnr:
- https://listnr.corp.google.com/report/85481730000
- https://listnr.corp.google.com/report/85479370505
- https://listnr.corp.google.com/report/85482315325

Thanks!
 
Cc: pbomm...@chromium.org
Components: UI>Browser>Omnibox
Labels: Needs-Triage-M67
Labels: -Type-Bug -Pri-2 ReleaseBlock-Stable RegressedIn-67 Target-67 Needs-Bisect Pri-1 Type-Bug-Regression
Able to reproduce the issue and currently working on bisect to find culprit CL. 
Cc: gov...@chromium.org
Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 541825 (known good), but no later than 541826 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/f6009cbd4461f483af77655448a896e68ae5f6cb..bcca8d4a2b5164aecdfa039c29a065a832ab50af


Note : I am unable to reproduce the same on 68.0.3440.7(latest dev) and also unable to reproduce on Mac and Linux on 67.0.3396.62.
Cc: msw@chromium.org
Ccing msw@ (Reviewer of Cl listed at #3)
Labels: Needs-Feedback
Okay I have a theory for what's going on, can the tester help me confirm?

If you click the second non-focused window and are very careful to not move your mouse cursor even one pixel, you will select everything as expected.

But if you jiggle the cursor even one pixel while the mouse button is down, you will place the cursor, as reported in c#0.

Is that the symptom you are experiencing?

Thanks...

Comment 6 by ahybo...@gmail.com, Jun 4 2018

No, it always happens when clicking between windows. I can't help but think this was an intentional change with chrome's recent update and redesign, but it needs to be reverted.
ahybodus@, could you pls see this issue is fixed on chrome dev and canary?
You can download canary: https://www.google.com/chrome/browser/canary.html and Dev: https://www.chromium.org/getting-involved/dev-channel. Thank you.
Status: Fixed (was: Assigned)
We've merged the fix:

Root cause of bug here:
https://bugs.chromium.org/p/chromium/issues/detail?id=838830

Merge executed here:
https://chromium.googlesource.com/chromium/src/+/f39ea53c83e5278d93e4bdbe106271737f4be69a
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-67; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-67 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 4 2018

Labels: merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ee0726dfd163a3daf82d05d98755903746b569b

commit 8ee0726dfd163a3daf82d05d98755903746b569b
Author: Tommy C. Li <tommycli@chromium.org>
Date: Mon Jun 04 23:48:47 2018

Omnibox: Fix a bad merge to M67.

Fix a bad merge here:
https://chromium-review.googlesource.com/c/chromium/src/+/1086158

Two lines were transposed.

Bug: 849270,  838830 
Change-Id: If942472b8e4c077c5253ec2711d7fe42705045e5
Reviewed-on: https://chromium-review.googlesource.com/1086347
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#744}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/8ee0726dfd163a3daf82d05d98755903746b569b/chrome/browser/ui/views/omnibox/omnibox_view_views.h

Cc: sandeepkumars@chromium.org
Labels: TE-Verified-M67 TE-Verified-67.0.3396.79
Tested the issue using #67.0.3396.79 on Win 10 as per the steps mentioned in original comment and fix is working as expected. Observed the omnibox text is seen highlighted.

Please find the attached screencat. Hence adding Verified labels.

Thanks!!
849270.mp4
2.0 MB View Download
Oh great! Thanks for verifying.
What is the fix? Sorry I am new to how this website dev stuff works.
Requesting postmortem for this bug. Please see go/chrome-postmortems for the process to follow.
I don't understand, you just linked me to this same thread. Is there a fix I am supposed to download or otherwise implement to fix this problem? Or is it not implemented yet?
ahybodus@, the fix was merged into Chrome Stable.  The next Stable release will have it.  There is nothing for you to do except wait.  (You could check about:help every week to force Chrome to check for updates right away.)

Comment 19 Deleted

Thank you mpearson@.

ahybodus@, 67.0.3396.79 is now available with the fix on Chrome Stable. You can force an update by visiting chrome://chrome or about:help. Thank you. 
Thanks for the responses. I'm on the latest version of chrome, but the issue persists for me.
This issue has not been resolved. Started happening after the most recent update. Windows 10 64-bit
Chrome Version 68.0.3440.106 (Official Build) (64-bit)
I have also been experiencing this issue since the last chrome update (at least).
Cc: manoranj...@chromium.org abdulsyed@chromium.org
+ abdulsyed@ & manoranjanr@, PTAL comment #22 and #23.
Status: Assigned (was: Fixed)
Re-opening per comments #22 and #23.


abdulsyed@ - very unlikely.

Per comment #21, and somewhat #23, it's likely this issue was not completely fixed in M-67.  Maybe they're something new in M-68 (comment #22) also?
checking with craigtumblison@, this hasn't spiked in M68 as it did in M67 in Feedback reports, except there are a few user comments about it. 
I'm not seeing this issue on current M68 stable#68.0.3440.106 for Win10. However i'm able to replicate this on reported chrome # 67.0.3396.62 (per c#0). Not very sure if this issue got introduced w/ specific chrome extensions on current stable?

Thank you!
Labels: M-69 M-68
I'm on #68.0.3440.106 and still happening for me.  

Click in the address bar (where there is an existing URL).
The text is high-lighted.
Type anything.
That text is appended to the end of the URL, rather than typed into a blanked URL.
Friendly ping to get an update as stable release is coming soon and this bug is marked as RBS for M68/M69.
Thanks..!

M69 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Merge has to happen latest by 4:00 PM PT Friday (08/24/18) in order to make it to next week stable cut. Thank you.
In my opinion this is a P3 or P2.5 and should not be a release blocker for stable.
Labels: -ReleaseBlock-Stable -Target-67 Target-70 M-70
Removing "RBS" per comment #34. Pls target fix for M70.
Labels: -Pri-1 Pri-2
Labels: -Needs-Feedback
Removing Needs-Feedback; feedback was provided long ago.
Still an issue for me. Suface book 2, chrome Version 69.0.3497.100 (Official Build) (64-bit)
Appears to be finally fixed for me!

Version 70.0.3538.35 (Official Build) beta (64-bit)
This seems to have started again for chrome version 69.0.3497.100

Labels: OS-Linux
I see the same thing on Linux, Kubuntu 18.04, both stable and canary, version 70.0.3538.67 and 71.0.3578.10 respectively. It was happening in 69 too.

Sign in to add a comment