Same-origin ad frames that don't have a navigation but are instead doc.written don't trigger a NotifySubframeNavigationEvaluated event. This means that metrics don't learn about same-origin ad iframes.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cca6aa49ef231dc139e72856353d46bea9540fc2 commit cca6aa49ef231dc139e72856353d46bea9540fc2 Author: Eric Robinson <ericrobinson@chromium.org> Date: Wed Aug 01 16:07:06 2018 Allow ad frame identification triggered by ad scripts only. This updates the ad_page_load_metrics_observer so that it accounts for ad frames that trigger ads without a navigation (via a script identified as an ad via subresource filters). Bug: 849268 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I81b9dee7e3556719e40337f2efd818f784130b78 Reviewed-on: https://chromium-review.googlesource.com/1120347 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579825} [modify] https://crrev.com/cca6aa49ef231dc139e72856353d46bea9540fc2/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc [modify] https://crrev.com/cca6aa49ef231dc139e72856353d46bea9540fc2/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h [modify] https://crrev.com/cca6aa49ef231dc139e72856353d46bea9540fc2/chrome/browser/subresource_filter/ad_tagging_browsertest.cc [modify] https://crrev.com/cca6aa49ef231dc139e72856353d46bea9540fc2/chrome/browser/subresource_filter/subresource_filter_unittest.cc [modify] https://crrev.com/cca6aa49ef231dc139e72856353d46bea9540fc2/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc [modify] https://crrev.com/cca6aa49ef231dc139e72856353d46bea9540fc2/components/subresource_filter/content/browser/subresource_filter_observer.h [modify] https://crrev.com/cca6aa49ef231dc139e72856353d46bea9540fc2/components/subresource_filter/content/browser/subresource_filter_observer_manager.cc [modify] https://crrev.com/cca6aa49ef231dc139e72856353d46bea9540fc2/components/subresource_filter/content/browser/subresource_filter_observer_manager.h [modify] https://crrev.com/cca6aa49ef231dc139e72856353d46bea9540fc2/components/subresource_filter/content/browser/subresource_filter_observer_test_utils.cc [modify] https://crrev.com/cca6aa49ef231dc139e72856353d46bea9540fc2/components/subresource_filter/content/browser/subresource_filter_observer_test_utils.h [modify] https://crrev.com/cca6aa49ef231dc139e72856353d46bea9540fc2/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Comment 1 by ericrobinson@chromium.org
, Jun 4 2018