New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849253 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 9
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Ctrl+a in search text box handled as file operation

Project Member Reported by yamaguchi@chromium.org, Jun 4 2018

Issue description

Chrome Version: 69.0.3444.0

Steps To Reproduce:
(1) Open the Files app.
(2) Click the search icon and enter some text in the search box
(3) type Ctrl + a.

Expected Result:
The entire text in the search box is selected.

Actual Result:
All the files in the current folder are selected.
The toolbar turns to the check-select mode. As a result search text box is hidden.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
100%

What is the impact to the user, and is there a workaround? If so, what is
it?
As a workaround, choose "cancel selection" by either using mouse or Shift+tab 2 times and Enter.

 
Labels: -Type-Bug -Pri-3 M-69 Pri-1 Type-Bug-Regression
Owner: sashab@chromium.org
Status: Assigned (was: Untriaged)
This works in 67, so is a regression.

I'll take a look at this.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fffb168accf77b8bb9466babff9e2001de65e58e

commit fffb168accf77b8bb9466babff9e2001de65e58e
Author: Sasha Morrissey <sashab@chromium.org>
Date: Fri Jul 06 07:31:55 2018

Check we are not inside a text box when selecting all files

Check we are not inside a text box when selecting all files, so that
Ctrl+A is not a valid file operation when the search box is active.

Bug:  849253 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I4c808d4a2162cc9dc2f2f0ca89ff2b70903e0fa5
Reviewed-on: https://chromium-review.googlesource.com/1125743
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572915}
[modify] https://crrev.com/fffb168accf77b8bb9466babff9e2001de65e58e/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/fffb168accf77b8bb9466babff9e2001de65e58e/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/fffb168accf77b8bb9466babff9e2001de65e58e/ui/file_manager/integration_tests/file_manager/drive_specific.js

Status: Fixed (was: Started)

Sign in to add a comment