New issue
Advanced search Search tips

Issue 849234 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

chrome://settings/siteData doesn't update correctly when deleting individual cookies

Project Member Reported by dullweber@chromium.org, Jun 4 2018

Issue description

Chrome Version: 68.0.3440.7
OS: Linux

What steps will reproduce the problem?
(1) go to chrome://settings/siteData
(2) click on an page with "n cookies" (n > 1)
(3) Delete an individual cookies
(4) go back to siteData list

What is the expected result?
The list entry should say "n-1 cookies"

What happens instead?
It still shows n cookies

It looks like [1] fixed the scrolling issue by performing additions/deletions on the original list. Changes are not handled, so an updateList call that just contains changes to existing entries doesn't work correctly.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1044764


 
Description: Show this description

Comment 2 by aee@chromium.org, Jun 4 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6312daacd8c4b8a58d100d51941558201bd60827

commit 6312daacd8c4b8a58d100d51941558201bd60827
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Tue Jun 05 00:49:24 2018

Settings: include cookie summary in uid so updated entry will replace old entry

Bug:  849234 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id0c0ab1e66289429e1cf51d0f9b2bc80cee3adfc
Reviewed-on: https://chromium-review.googlesource.com/1086032
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564320}
[modify] https://crrev.com/6312daacd8c4b8a58d100d51941558201bd60827/chrome/browser/resources/settings/site_settings/site_data.js

Comment 4 by aee@chromium.org, Jun 5 2018

Status: Fixed (was: Started)

Sign in to add a comment