New issue
Advanced search Search tips

Issue 849223 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Promptly free buffer for stack allocated heap collections

Project Member Reported by keishi@chromium.org, Jun 4 2018

Issue description

We should promptly free buffer for stack allocated heap collections.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89ecc1c7cab74c7480d7878beb1c832782174bb7

commit 89ecc1c7cab74c7480d7878beb1c832782174bb7
Author: Keishi Hattori <keishi@chromium.org>
Date: Mon Jun 04 12:19:01 2018

blink_gc_plugin: Prepare for optional finalizer for on-heap collections

We will be adding an optional finalizer for on-heap collections that promptly frees the buffer. Finalization will still be required for collections with inline buffers.

blink_gc_plugin will not require finalization for objects with optional finalizers.

Bug: 849223
Change-Id: Ia4e843bc2d356bda4f5bb85da00852d208511627
Reviewed-on: https://chromium-review.googlesource.com/1084810
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564064}
[modify] https://crrev.com/89ecc1c7cab74c7480d7878beb1c832782174bb7/tools/clang/blink_gc_plugin/RecordInfo.cpp
[modify] https://crrev.com/89ecc1c7cab74c7480d7878beb1c832782174bb7/tools/clang/blink_gc_plugin/RecordInfo.h
[modify] https://crrev.com/89ecc1c7cab74c7480d7878beb1c832782174bb7/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.cpp
[modify] https://crrev.com/89ecc1c7cab74c7480d7878beb1c832782174bb7/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h
[modify] https://crrev.com/89ecc1c7cab74c7480d7878beb1c832782174bb7/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.txt
[modify] https://crrev.com/89ecc1c7cab74c7480d7878beb1c832782174bb7/tools/clang/blink_gc_plugin/tests/heap/stubs.h
[modify] https://crrev.com/89ecc1c7cab74c7480d7878beb1c832782174bb7/tools/clang/blink_gc_plugin/tests/stack_allocated.txt

Sign in to add a comment