New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 849212 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Jun 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
█ nyquist@chromium.org
dtrainor@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Tools menu animation is trigger very often

Project Member Reported by gambard@chromium.org, Jun 4 2018 
What steps will reproduce the problem?
(1) Open the app, mostly on a non-NTP page

What is the expected result?
Nothing

What happens instead?
The tools menu animation is triggered.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9836fb9466ef3d9e4311b12db2bfc97bbd572b3d

commit 9836fb9466ef3d9e4311b12db2bfc97bbd572b3d
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Jun 05 07:06:04 2018

Do not trigger tools menu animation all the time

This CL fixes a bug where the tools menu animation was triggered all the
time because of the in-product help.
Now the animation is triggered only if the corresponding in-product help
is shown.

Bug:  849212 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I24ab3665de4ba86c67d3638be5ed4ed788f52c99
Reviewed-on: https://chromium-review.googlesource.com/1084595
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564386}
[modify] https://crrev.com/9836fb9466ef3d9e4311b12db2bfc97bbd572b3d/ios/chrome/browser/ui/bubble/bubble_presenter.mm

Comment 2 by gambard@chromium.org, Jun 5 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment