New issue
Advanced search Search tips

Issue 849210 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Battery serial is included in feedback reports

Project Member Reported by tnagel@chromium.org, Jun 4 2018

Issue description

Filing this as a tracking bug to ensure release managers are aware:

https://b.corp.google.com/issues/78240760#comment35
https://b.corp.google.com/issues/80540705
 
Can we confirm this only impacts Snappy?
No this impacts all devices that would have serial number under /sys/class/power_supply/<bat>/serial_number but the change is trivial in the sense that it just removes the parsing & output of that value.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 6 2018

Labels: merge-merged-release-R68-10718.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/fb114df0a9149def2ad3831bbb89c051a4796591

commit fb114df0a9149def2ad3831bbb89c051a4796591
Author: Todd Broch <tbroch@chromium.org>
Date: Wed Jun 06 17:07:42 2018

power: Remove battery serial.

BUG=b:80540705,  chromium:849210 
TEST=manual,
run 'power_supply_info' and no longer see this line as part of output
  serial number:           abcd

Change-Id: I6cb71d095dd8aae0400394a5902596998bf0b603
Reviewed-on: https://chromium-review.googlesource.com/1087832
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
(cherry picked from commit d45ff7e90a0d4e57b9e14cddab8bc02058c84944)
Reviewed-on: https://chromium-review.googlesource.com/1089173
Reviewed-by: Todd Broch <tbroch@chromium.org>
Commit-Queue: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/fb114df0a9149def2ad3831bbb89c051a4796591/power_manager/tools/power_supply_info.cc
[modify] https://crrev.com/fb114df0a9149def2ad3831bbb89c051a4796591/power_manager/powerd/system/power_supply.cc
[modify] https://crrev.com/fb114df0a9149def2ad3831bbb89c051a4796591/power_manager/powerd/system/power_supply.h

Components: OS>Kernel>Power
Status: Fixed (was: Assigned)

Sign in to add a comment