Move the logic to resize vs adjust contentInset of WebView out of web/ |
|||
Issue descriptionThe logic to adjust the frame of the WKWebView instead of adjusting the contentInset property of the WKScrollView to workaround a WebKit bug (https://bugs.webkit.org/show_bug.cgi?id=134230) should live in chrome/ instead of web/.
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37ef13f45bc1a02808167c1db8e9687ec3e4a386 commit 37ef13f45bc1a02808167c1db8e9687ec3e4a386 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 19 08:04:18 2018 [iOS] Fix fullscreenOutOfWeb for NTP This CL fixes the fullscreen implementation living outside of web for the NTP and other scrolling issues on web page. It also fixes the animation of the resizing when the animator is triggered. Bug: 849206 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8a13b88af6808472ef84ef6902c75c398451c961 Reviewed-on: https://chromium-review.googlesource.com/1195487 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#592340} [modify] https://crrev.com/37ef13f45bc1a02808167c1db8e9687ec3e4a386/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/37ef13f45bc1a02808167c1db8e9687ec3e4a386/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/37ef13f45bc1a02808167c1db8e9687ec3e4a386/ios/chrome/browser/ui/fullscreen/BUILD.gn [modify] https://crrev.com/37ef13f45bc1a02808167c1db8e9687ec3e4a386/ios/chrome/browser/ui/fullscreen/fullscreen_mediator.mm [modify] https://crrev.com/37ef13f45bc1a02808167c1db8e9687ec3e4a386/ios/chrome/browser/ui/fullscreen/fullscreen_web_view_resizer.h [modify] https://crrev.com/37ef13f45bc1a02808167c1db8e9687ec3e4a386/ios/chrome/browser/ui/fullscreen/fullscreen_web_view_resizer.mm [modify] https://crrev.com/37ef13f45bc1a02808167c1db8e9687ec3e4a386/ios/chrome/browser/ui/fullscreen/fullscreen_web_view_resizer_unittest.mm
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae0aa26508cc424b3928b1ed4bf49db846264f36 commit ae0aa26508cc424b3928b1ed4bf49db846264f36 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 19 08:52:28 2018 [iOS] Fix the fullscreen scrolling offset The scrolling offset of the WKWebView should be handled in the FullscreenResizer, not in Web when the flag is enabled. This wasn't the case before because the flag was created in the middle of the refactoring of the existing function. Bug: 849206 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I89675ee01c43fe8eecda56f690d08ffb4eabe263 Reviewed-on: https://chromium-review.googlesource.com/1196368 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#592349} [modify] https://crrev.com/ae0aa26508cc424b3928b1ed4bf49db846264f36/ios/chrome/browser/ui/fullscreen/fullscreen_web_view_resizer.mm [modify] https://crrev.com/ae0aa26508cc424b3928b1ed4bf49db846264f36/ios/web/web_state/ui/crw_web_view_content_view.mm
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/130703ac5940ec802fcf22d9ed3bef6320f061e1 commit 130703ac5940ec802fcf22d9ed3bef6320f061e1 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 19 09:04:04 2018 [iOS] Don't always compensate fullscreen resizing This CL changes the way the fullscreen resizer is compensating the frame changes by updating the content offset of the scroll view. When the WebState is set up the first time, the content offset shouldn't be updated. Bug: 849206 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ibface28fd9d0459c411aa74de6bb3075c62eb004 Reviewed-on: https://chromium-review.googlesource.com/1225981 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#592350} [modify] https://crrev.com/130703ac5940ec802fcf22d9ed3bef6320f061e1/ios/chrome/browser/ui/fullscreen/fullscreen_web_view_resizer.mm
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8240b0090f2fb5e4bd9a35e1ecbd761786d00b58 commit 8240b0090f2fb5e4bd9a35e1ecbd761786d00b58 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Sep 25 09:09:26 2018 [iOS] Update snapshot for FullscreenOutOfWeb The snapshot of the page are taken based on the WebState's view frame. When Fullscreen is done out of Web, the WebState's view frame is changed based on the fullscreen progress. So when it is enabled, the snapshot should be taken relatively to its superview. Bug: 849206 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I13f2ad0377a6088467dd289d0cbadb7106e08019 Reviewed-on: https://chromium-review.googlesource.com/1238255 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593869} [modify] https://crrev.com/8240b0090f2fb5e4bd9a35e1ecbd761786d00b58/ios/chrome/browser/snapshots/snapshot_generator.mm
,
Sep 27
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab8fe8a52e6cf13e2eee4ab328be85577dd57935 commit ab8fe8a52e6cf13e2eee4ab328be85577dd57935 Author: Justin Cohen <justincohen@google.com> Date: Wed Oct 03 14:18:32 2018 [ios] Correct new tab animation with fullscreen features enabled. Also note that -correctMissingSafeArea in content suggestions VC can be bypassed when the BrowserContainerFullscreen feature is enabled. BUG: 849206 , 836730 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id876a66b1509cdec64a645b59c296186c31fa8e1 Reviewed-on: https://chromium-review.googlesource.com/c/1255984 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596203} [modify] https://crrev.com/ab8fe8a52e6cf13e2eee4ab328be85577dd57935/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/ab8fe8a52e6cf13e2eee4ab328be85577dd57935/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
,
Oct 9
Verified on 71.0.3572.0 Canary, iPhone X iOS 11.4.1 Looks good. https://drive.google.com/file/d/1QhdHnTrBhxoySgdrWw0-WBwBLC3EgTQI/view |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Aug 28