New issue
Advanced search Search tips

Issue 849205 link

Starred by 2 users
Status: Assigned
Owner:
paulir...@chromium.org
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: White patch is seen on recorded audit avtivity in dark theme.

Reported by aiman.an...@etouch.net, Jun 4 2018 
Chrome Version: 69.0.3449.0 (Official Build) Revision 4c662013d5fa1e3a073c4e2a62844d6838d152d3-refs/branch-heads/3449@{#1}(32/64-bit).

OS: Win(7,8,8.1,10), Linux(14.04 LTS), Mac(10.12.6, 10.13.1, 1.13.6).

What steps will reproduce the problem?
1. Launch chrome, open devtools on NTP and Hit F1 to open devtools settings.
2. Change Theme to Dark.
3. Run Audit and observe the recorded activity.

Actual Result: White patch is seen on recorded audit activity, when the theme is set as dark

Expected Result: White patch should not be seen, when theme set as dark.

This is a regression issue, broken in M-69  series, and will soon update other info.

Good Build: 69.0.3446.0 (Revision:563012)
Bad Build: 69.0.3447.0 (Revision:563478)

You are probably looking for a change made after 563120 (known good), but no later than 563121 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/6ded7989effc86bb0ff914562b158c4b28746954..8405e18c05b9e5a1c714db1e204de6aaae3be24d

Suspect https://chromium.googlesource.com/chromium/src/+/8405e18c05b9e5a1c714db1e204de6aaae3be24d

paulirish@ Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You!
Actual Result.mp4
748 KB View Download
Expected Result.mp4
1.3 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81eec00ddca5a566b6134d6a7603de9849b0ef3f

commit 81eec00ddca5a566b6134d6a7603de9849b0ef3f
Author: Patrick Hulce <phulce@chromium.org>
Date: Tue Jun 12 01:52:51 2018

DevTools: Audits dark theme styling

BUG=849205

Change-Id: Ie9a7425fd8d3698fbea1c5a395167ce535e7206d
Reviewed-on: https://chromium-review.googlesource.com/1093312
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566254}
[modify] https://crrev.com/81eec00ddca5a566b6134d6a7603de9849b0ef3f/third_party/blink/renderer/devtools/front_end/audits2/audits2Panel.css

Comment 2 by aiman.an...@etouch.net, Jun 12 2018 

Update:

Retested the above issue on latest Canary build #69.0.3455.0 using Win(7,8,8.1,10), Linux(14.04 LTS), Mac(10.12.6, 10.13.1, 1.13.6) OS.

Still able to see white patch in Devtools ark theme after running audit.

Kindly refer the attached screen-cast.

Thank You!
Canary Behaviour.mp4
785 KB View Download

Comment 3 by rbasuvula@chromium.org, Jun 12 2018 

Please ignore comment #2, fix not landed in build #69.0.3455.0.We will check once fix build is available.

Thank You!

Comment 4 by aiman.an...@etouch.net, Jun 13 2018

Labels: TE-Verified-M69 TE-Verified-69.0.3457.0
Update:

Retested the above issue on latest Canary build #69.0.3457.0 using Win(7,8,8.1,10), Linux(14.04 LTS), Mac(10.12.6, 10.13.1, 1.13.6) OS.

Now, white patch is not seen in Devtools dark theme after running audit.

Kindly refer the attached screen-cast.

Thank You!
Canary Behaviour.mov
13.2 MB View Download
►

Sign in to add a comment