New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849204 link

Starred by 22 users

Can not scroll a response's preview

Reported by karan.ka...@gmail.com, Jun 4 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/67.0.3396.62 Chrome/67.0.3396.62 Safari/537.36

Steps to reproduce the problem:
1. Open chromium DevTools while a page loads
2. Open Network
3. Select an XHR request
4. Open its Preview
5. Try to scroll the content vertically (assuming there is 
   enough content for the vertical scroll-bar to appear)

What is the expected behavior?
The scroll should work

What went wrong?
The scroll won't work in an XHR request's Preview

Did this work before? Yes 

Chrome version: 67.0.3396.62  Channel: stable
OS Version: 16.04
Flash Version:
 
I can confirm the same issue on my Ubuntu 18.04 Chromium Version 67.0.3396.62 (Official Build) Built on Ubuntu , running on Ubuntu 18.04 (64-bit). Scroll bar is only not working for HTML previews. For other content types like scripts, styles and JSON it's working fine.


 
Screencast from Monday 04 June 2018 06:18:29 IST.webm
1.6 MB View Download
Cc: pbomm...@chromium.org dgozman@chromium.org
Labels: Needs-Triage-M67
Labels: Needs-Bisect
Owner: eostroukhov@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: phanindra.mandapaka@chromium.org
Labels: -Pri-2 -Needs-Bisect ReleaseBlock-Stable Triaged-ET RegressedIn-67 M-67 Target-67 FoundIn-67 Target-68 FoundIn-69 Target-69 FoundIn-68 hasbisect OS-Mac OS-Windows Pri-1
Able to reproduce the issue on reported chrome & chromium versions 67.0.3396.62  & latest chrome 69.0.3450.0 using Ubuntu 14.04,Windows10 and Mac 10.13.3 Hence providing the bisect information below.

Bisect Info:
================
Good build: 67.0.3386.0
Bad build: 67.0.3387.0

You are probably looking for a change made after 547557 (known good), but no later than 547566 (first known bad).

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/f9e0290cfcba215dfe7d1c95f51f216d31546f7d..6de618859d1c700738ce94cfcce017bac664b171

suspect: https://chromium.googlesource.com/chromium/src/+/0300fb5c41637ba7d2633d21dec29124d60e17cb

Reviewed-on: https://chromium-review.googlesource.com/990207

eostroukhov@: Please confirm the issue and help in re-assigning if it is not related to your change.

Thanks!
Labels: -ReleaseBlock-Stable
Cc: sindhu.chelamcherla@chromium.org
 Issue 849687  has been merged into this issue.
 Issue 850453  has been merged into this issue.
I'm curious as to the reason for disabling pointer events on the HTML preview anyway, was there a related bug? For now I commented out the `pointer-events: none;` line in `network/requestHTMLView.css`.

Comment 9 by l...@chromium.org, Jun 13 2018

 Issue 852360  has been merged into this issue.
Have tried to work through this one but is getting a bit painful now. 

Cannot for the life of me find where network/requestHTMLView.css lives on Ubuntu/ElementaryOS to fix like #8. Unfortunately scrolling with the mouse doesn't work for me. 

A work around for anyone that it might help for the moment is to select the Preview tab, hit the tab key and you can then use the down arrow key to scroll down.
I looked around briefly in eOS and couldn't find it either, but I was able to override it with a local file. You still need to open the inspector for the inspector and reload for the override to apply though, which is still less than ideal.
override.png
20.5 KB View Download
Owner: l...@chromium.org
Erik, could you please look into this? Seems like a painful regression.
Labels: M-68
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/122037b2541bf0932fd6fbcb29a98d487525c4ec

commit 122037b2541bf0932fd6fbcb29a98d487525c4ec
Author: Erik Luo <luoe@chromium.org>
Date: Wed Jun 20 23:54:16 2018

DevTools: restore pointer events in HTML preview

- Restores pointer events (including scrolling) to HTML preview.
- Prevents accidentally focusing inputs/links inside the preview
  iframe when tabbing via keyboard.

Bug:  849204 
Change-Id: Iea5dc6117decbe1d9e746139dd5974a8bfb45c62
Reviewed-on: https://chromium-review.googlesource.com/1107250
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569093}
[modify] https://crrev.com/122037b2541bf0932fd6fbcb29a98d487525c4ec/third_party/blink/renderer/devtools/front_end/network/RequestHTMLView.js
[modify] https://crrev.com/122037b2541bf0932fd6fbcb29a98d487525c4ec/third_party/blink/renderer/devtools/front_end/network/requestHTMLView.css

Comment 15 by l...@chromium.org, Jun 22 2018

Status: Fixed (was: Assigned)

Comment 16 by l...@chromium.org, Jun 23 2018

Cc: l...@chromium.org
 Issue 855321  has been merged into this issue.
Labels: Needs-Feedback
Able to reproduce this issue on Windows 10, Mac OS 10.13.5 and Ubuntu 17.10 on the reported version 67.0.3396.79 and the issue is fixed on the latest Canary 69.0.3480.0 by following the below steps. 
1. Open chromium DevTools while a page loads
2. Open Network
3. Select a request
4. Open its Preview
5. Try to scroll the content  - it scrolls up and down successfully
Attached is the screen cast for reference. 

Tested this issue on latest Beta 68.0.3440.42 and able to reproduce the issue. 
luoe@ Can you please confirm if this issue needs a merge to M-68?

Thanks...
849204.mp4
2.7 MB View Download
Labels: TE-Verified-M69 TE-Verified-69.0.3480.0
Adding the verified label for M-69 as per C#17.
Labels: -Needs-Feedback
#17, thanks for verifying.  No merge is planned for now.
Labels: -Needs-Triage-M67 Merge-Request-68
Status: Started (was: Fixed)
Requesting a merge to M68, we have received user feedback on many channels when this broke [1].

The fix in #14 should be low risk, as it reverts a change that used to be stable before M67.

[1] https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/google-chrome-developer-tools/KOnzzvAHSlU
Project Member

Comment 21 by sheriffbot@chromium.org, Jul 9

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: abdulsyed@chromium.org
Labels: -Merge-Review-68 Merge-Approved-68
Approved - branch:3440
Project Member

Comment 24 by bugdroid1@chromium.org, Jul 10

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b96fd075313549310221797a978f7d2393fc112

commit 6b96fd075313549310221797a978f7d2393fc112
Author: Erik Luo <luoe@chromium.org>
Date: Tue Jul 10 18:14:07 2018

Merge of DevTools: restore pointer events in HTML preview

- Restores pointer events (including scrolling) to HTML preview.
- Prevents accidentally focusing inputs/links inside the preview
  iframe when tabbing via keyboard.

Bug:  849204 
Change-Id: Iea5dc6117decbe1d9e746139dd5974a8bfb45c62
Reviewed-on: https://chromium-review.googlesource.com/1107250
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#569093}(cherry picked from commit 122037b2541bf0932fd6fbcb29a98d487525c4ec)
Reviewed-on: https://chromium-review.googlesource.com/1132014
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#634}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/6b96fd075313549310221797a978f7d2393fc112/third_party/blink/renderer/devtools/front_end/network/RequestHTMLView.js
[modify] https://crrev.com/6b96fd075313549310221797a978f7d2393fc112/third_party/blink/renderer/devtools/front_end/network/requestHTMLView.css

Status: Fixed (was: Started)
Labels: TE-Verified-M68 TE-Verified-68.0.3440.59
Able to reproduce the issue on Mac 10.12.6 using chrome reported version #67.0.3396.62

Verified the fix on Mac 10.12.6, Win-10 and Ubuntu 17.10 using Chrome beta version #68.0.3440.59 as per the comment #0.
Attaching screen cast for reference.
Observed that the scroll works in request's Preview.
Hence, the fix is working as expected.
Adding the verified labels.

Thanks...!!
849204.mp4
4.2 MB View Download
 Issue 865194  has been merged into this issue.
Guys it is fine on the beta, no bug present:
Version 68.0.3440.68 (Official Build) beta (64-bit)
Cc: krajshree@chromium.org pnangunoori@chromium.org jbanavatu@chromium.org vamshi.kommuri@chromium.org
 Issue 857412  has been merged into this issue.

Sign in to add a comment