New issue
Advanced search Search tips

Issue 849193 link

Starred by 1 user
Status: Fixed
Owner:
edchin@chromium.org
Closed: Jun 2018
Cc:
marq@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-06-20
OS: iOS
Pri: 2
Type: Bug
Q2



Sign in to add a comment

"Cancel" button is moving when moving from one TabGrid to the other

Project Member Reported by gambard@chromium.org, Jun 4 2018 
With UI Refresh flag enabled

What steps will reproduce the problem?
(1) Open tabs in Incognito and non-incognito
(2) Hit "Close All Tabs" in non-incognito
(3) Swipe to the incognito TabGrid

What is the expected result?
"Cancel" should be changed to "Close All Tabs" smoothly.

What happens instead?
"Cancel" is slightly moving the right before being replaced by "Close All Tabs".

Comment 1 by edchin@chromium.org, Jun 13 2018

Labels: medium
NextAction: 2018-06-20

Comment 2 by monor...@bugs.chromium.org, Jun 20 2018 

The NextAction date has arrived: 2018-06-20

Comment 3 by edchin@chromium.org, Jun 25 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a6346e3f1912afb92d8a35a7977eaaa9386e770

commit 7a6346e3f1912afb92d8a35a7977eaaa9386e770
Author: edchin <edchin@chromium.org>
Date: Mon Jun 25 23:17:04 2018

[ios] Extend done button in tab grid

The done button tap target should be expanded so that the user can tap
the same spot when entering and exiting the tab grid.

This CL also fixes the ellipsis when changing the "Close All" button text to "Undo".

Bug:  825787 ,  849193 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I352e9654419c670f6dea431003a9c189ed639156
Reviewed-on: https://chromium-review.googlesource.com/1114149
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570228}
[modify] https://crrev.com/7a6346e3f1912afb92d8a35a7977eaaa9386e770/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/7a6346e3f1912afb92d8a35a7977eaaa9386e770/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm
[modify] https://crrev.com/7a6346e3f1912afb92d8a35a7977eaaa9386e770/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.mm

Comment 5 by edchin@chromium.org, Jun 25 2018

Status: Fixed (was: Started)
►

Sign in to add a comment