The tab-switching metrics are not reported correctly for cases where the renderer has to submit a new content because of the tab-switch (e.g. if the content of the renderer had been evicted while it was in the background).
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/a9d8c2947cb93edc4242fde8f7f5b2b891a86a03 commit a9d8c2947cb93edc4242fde8f7f5b2b891a86a03 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Mon Jun 04 20:33:06 2018 tabs: Update the measurements. The tab-switching time is currently measured from the presentation time after crrev.com/c/1083862. This means that the metric is reported in both the browser and renderer processes. Update tabsMetric to work correctly after this change. BUG= chromium:849182 Change-Id: I07a854cbe06610a241ec78420af219ed8b30ff29 Reviewed-on: https://chromium-review.googlesource.com/1084431 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Ben Hayden <benjhayden@chromium.org> [modify] https://crrev.com/a9d8c2947cb93edc4242fde8f7f5b2b891a86a03/tracing/tracing/metrics/tabs_metric_test.html [modify] https://crrev.com/a9d8c2947cb93edc4242fde8f7f5b2b891a86a03/tracing/tracing/metrics/tabs_metric.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99fa900045e32ad50d7ce5b7aa53ed37cfc6af5c commit 99fa900045e32ad50d7ce5b7aa53ed37cfc6af5c Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon Jun 04 23:53:32 2018 Roll src/third_party/catapult bf32270..a9d8c29 (2 commits) https://chromium.googlesource.com/catapult.git/+log/bf32270..a9d8c29 git log bf32270..a9d8c29 --date=short --no-merges --format='%ad %ae %s' 2018-06-04 sadrul@chromium.org tabs: Update the measurements. 2018-06-04 sadrul@chromium.org tabs: Fix tabs metric. Created with: gclient setdep -r src/third_party/catapult@a9d8c29 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:849182 , chromium:842732 TBR=sullivan@chromium.org Change-Id: Ia0082975bc8c135e38b8183ca31a22596f2f78b0 Reviewed-on: https://chromium-review.googlesource.com/1086070 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564301} [modify] https://crrev.com/99fa900045e32ad50d7ce5b7aa53ed37cfc6af5c/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/9861a71fa584804df9e1502d07cbb409e5c6e726 commit 9861a71fa584804df9e1502d07cbb409e5c6e726 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Tue Jun 05 23:48:22 2018 tabs: Switch back to async trace events. We ended up switching to using async trace events for measuring the tab-switching latency. So update the metric to work with that. BUG= chromium:849182 Change-Id: I653dc59660758e84bdc83ca580c0f724c3f56fae Reviewed-on: https://chromium-review.googlesource.com/1087579 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Ben Hayden <benjhayden@chromium.org> [modify] https://crrev.com/9861a71fa584804df9e1502d07cbb409e5c6e726/tracing/tracing/metrics/tabs_metric_test.html [modify] https://crrev.com/9861a71fa584804df9e1502d07cbb409e5c6e726/tracing/tracing/metrics/tabs_metric.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bc43cc019d9983e96f9a7c5549f862674991e97 commit 8bc43cc019d9983e96f9a7c5549f862674991e97 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Wed Jun 06 01:48:03 2018 tab-switching: Use presentation time for measuring tab-switching time. Use the presentation-time for measuring the tab-switching times, both for the browser process, and the renderer process (when the renderer needs to submit new content because of the switch, if its content had been evicted while it was in the background). This removes the usage of ui::LatencyInfo for measuring the tab-switching time, and TAB_SHOW_COMPONENT is no longer needed. So TAB_SHOW_COMPONENT is removed, and IPCs are updated to not carry a ui::LatencyInfo anymore. BUG= 849182 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ie6d695ebc2ffaed321e061b965615cee8564430d Reviewed-on: https://chromium-review.googlesource.com/1083862 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Brian Anderson <brianderson@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#564765} [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/components/viz/service/frame_sinks/surface_synchronization_unittest.cc [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/browser/frame_host/render_widget_host_view_guest.cc [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/browser/renderer_host/browser_compositor_view_mac.mm [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/browser/renderer_host/delegated_frame_host.cc [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/browser/renderer_host/delegated_frame_host.h [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/browser/renderer_host/render_widget_host_impl.h [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/browser/renderer_host/render_widget_host_unittest.cc [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/browser/renderer_host/render_widget_host_view_aura.h [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/browser/renderer_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/browser/renderer_host/render_widget_host_view_mac.h [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/browser/renderer_host/render_widget_host_view_mac.mm [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/common/BUILD.gn [add] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/common/tab_switching_time_callback.cc [add] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/common/tab_switching_time_callback.h [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/common/view_messages.h [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/renderer/gpu/render_widget_compositor.h [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/renderer/render_frame_impl_browsertest.cc [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/renderer/render_widget.cc [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/renderer/render_widget.h [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/content/test/test_render_view_host.cc [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/ui/latency/latency_info.cc [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/ui/latency/latency_info.h [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/ui/latency/latency_tracker.cc [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/ui/latency/mojo/latency_info.mojom [modify] https://crrev.com/8bc43cc019d9983e96f9a7c5549f862674991e97/ui/latency/mojo/latency_info_struct_traits.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca0efc8e34c8e21dcb8f529340e18699882e341a commit ca0efc8e34c8e21dcb8f529340e18699882e341a Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Jun 06 06:25:14 2018 Roll src/third_party/catapult 36d4a47..9861a71 (1 commits) https://chromium.googlesource.com/catapult.git/+log/36d4a47..9861a71 git log 36d4a47..9861a71 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 sadrul@chromium.org tabs: Switch back to async trace events. Created with: gclient setdep -r src/third_party/catapult@9861a71 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:849182 TBR=sullivan@chromium.org Change-Id: Id29f0c07a689efcbb900a4d9f0b54d2267602f51 Reviewed-on: https://chromium-review.googlesource.com/1088247 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564804} [modify] https://crrev.com/ca0efc8e34c8e21dcb8f529340e18699882e341a/DEPS
This should now be fixed.
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/63f44ee353bd025293b2e25f9237d3ca09c3142c commit 63f44ee353bd025293b2e25f9237d3ca09c3142c Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Thu Jun 07 20:47:46 2018 tabs: Ignore the duration for the new metric. It is possible that in the new metric, the final results gets a mix of the new metric and the old metric (based on slice-duration). There can be un-terminated slices in some cases, and instead of using the new metric for these, it ends up using duration, which is incorrect. So explicitly look for new metric, and have some code to work for the legacy cases too. BUG= chromium:849182 Change-Id: Ia5982316eb0398f92e9b5c9cd58f864fc76d95fd Reviewed-on: https://chromium-review.googlesource.com/1091119 Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> [modify] https://crrev.com/63f44ee353bd025293b2e25f9237d3ca09c3142c/tracing/tracing/metrics/tabs_metric.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c150be89c3fe3f157822b7aaa9436116e9adca0 commit 0c150be89c3fe3f157822b7aaa9436116e9adca0 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jun 08 02:30:58 2018 Roll src/third_party/catapult 72a8685..09b82f4 (2 commits) https://chromium.googlesource.com/catapult.git/+log/72a8685..09b82f4 git log 72a8685..09b82f4 --date=short --no-merges --format='%ad %ae %s' 2018-06-07 benjhayden@chromium.org Plumb story tags through Telemetry Values. 2018-06-07 sadrul@chromium.org tabs: Ignore the duration for the new metric. Created with: gclient setdep -r src/third_party/catapult@09b82f4 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849363, chromium:849182 TBR=sullivan@chromium.org Change-Id: I025e96839825a8303a7108a11c23604b7fa3f6c3 Reviewed-on: https://chromium-review.googlesource.com/1091931 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565515} [modify] https://crrev.com/0c150be89c3fe3f157822b7aaa9436116e9adca0/DEPS
Comment 1 by bugdroid1@chromium.org
, Jun 4 2018