New issue
Advanced search Search tips

Issue 849180 link

Starred by 1 user
Status: Fixed
Owner:
aee@chromium.org
Closed: Jun 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:The font size on the 'Edit bookmark' overlay appears larger

Reported by vineetha...@etouch.net, Jun 4 2018 
Chrome Version: 69.0.3448.0 (Official Build) Revision 881f7188e7bedfd86afd70ed2af61a41667fe141-refs/branch-heads/3448@{#1}(32/64 bit)
OS: Mac(10.12.6,10.13.1), 10.13.6(Macbook Pro Touchbar), Windows(7,8,8.1,10) and Linux(14.04) OS

Pre-condition : Atleast one bookmark entry should be present under chrome://bookmarks

What steps will reproduce the problem?
(1) Launch Chrome, navigate to chrome://bookmarks.
(2) Click on the 'More actions' (3 dot) icon, select on 'Edit option to open 'Edit bookmark' overlay and observe.

Actual Result: The font size on the 'Edit bookmark' overlay appears larger.
Expected Result: The font size on the 'Edit bookmark' overlay should be normal like on other overlays.

This is regression issue broken in ‘M-69’ and will soon update the bisect info,
Good build: 69.0.3447.0(Revision: 563479)
Bad build : 69.0.3448.0(Revision: 563958)
ActualVideo.mov
1.5 MB View Download
ExpectedVideo.mov
1.1 MB View Download

Comment 1 by vineetha...@etouch.net, Jun 4 2018

Labels: hasbisect-per-revision RegressedIn-69 Target-69 FoundIn-69
Owner: aee@chromium.org
Status: Assigned (was: Unconfirmed)
Providing the bisect using per-revision bisect,

You are probably looking for a change made after 563768 (known good), but no later than 563769 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure

https://chromium.googlesource.com/chromium/src/+log/da9e113c3734f8ad63806c86b491e0ff0e62ebfd..a17e4103e82e75462cb32a066e9c4b532cb4555d

Suspect: https://chromium.googlesource.com/chromium/src/+/a17e4103e82e75462cb32a066e9c4b532cb4555d

@aee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You!

Comment 2 by aee@chromium.org, Jun 4 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47070f751ee3d0533b474242e862983e1949237f

commit 47070f751ee3d0533b474242e862983e1949237f
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Tue Jun 05 00:41:21 2018

Bookmarks: fix the input style in the edit dialog

Bug:  849180 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I71a8dbc6a17383f21bd58ff3c9d918444930f715
Reviewed-on: https://chromium-review.googlesource.com/1086040
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564318}
[modify] https://crrev.com/47070f751ee3d0533b474242e862983e1949237f/chrome/browser/resources/md_bookmarks/edit_dialog.html

Comment 4 by aee@chromium.org, Jun 5 2018

Status: Fixed (was: Started)

Comment 5 by vineetha...@etouch.net, Jun 5 2018

Labels: TE-Verified-69.0.3450.0 TE-Verified-M69
Update :
Rechecked the above issue on Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6) and Linux(14.04)OS with latest Canary Chrome version #69.0.3450.0 and the issue is fixed.

Kindly refer the attached screen cast.
FixedVideo.mov
1.1 MB View Download
►

Sign in to add a comment