blink/PRESUBMIT_test.py fails on ToT |
|||
Issue descriptionFrom https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8944817997339230448%2F%2B%2Fsteps%2Fpresubmit%2F0%2Fstdout ====================================================================== FAIL: testCheckCoreEnforcement (__main__.CxxDependencyTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/b/swarming/w/ir/cache/builder/chromium_presubmit/src/third_party/blink/PRESUBMIT_test.py", line 182, in testCheckCoreEnforcement self.assertEquals(1, len(errors)) AssertionError: 1 != 0 ====================================================================== FAIL: testCheckModulesEnforcement (__main__.CxxDependencyTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/b/swarming/w/ir/cache/builder/chromium_presubmit/src/third_party/blink/PRESUBMIT_test.py", line 195, in testCheckModulesEnforcement self.assertEquals(1, len(errors)) AssertionError: 1 != 0 ====================================================================== FAIL: testCheckPublicEnforcement (__main__.CxxDependencyTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/b/swarming/w/ir/cache/builder/chromium_presubmit/src/third_party/blink/PRESUBMIT_test.py", line 208, in testCheckPublicEnforcement self.assertEquals(1, len(errors)) AssertionError: 1 != 0 ----------------------------------------------------------------------
,
Jun 4 2018
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85c4d030ca16a1e8e3be1c733a0fcebac5309d07 commit 85c4d030ca16a1e8e3be1c733a0fcebac5309d07 Author: danakj <danakj@chromium.org> Date: Tue Jun 05 15:16:00 2018 Fix PRESUBMIT_test.py, gfx geometry is allowed. Replace gfx::Point/Rect with gfx::Canvas as an example of a banned type. R=tkent@chromium.org Bug: 849172 Change-Id: I898e89f0a6b033f5d61df2790bc2b8338ba5c928 Reviewed-on: https://chromium-review.googlesource.com/1085007 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#564504} [modify] https://crrev.com/85c4d030ca16a1e8e3be1c733a0fcebac5309d07/third_party/blink/PRESUBMIT_test.py
,
Jun 5 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tkent@chromium.org
, Jun 4 2018Status: Assigned (was: Untriaged)