"MediaFileValidatorTest.ValidAudio" is flaky |
|||||
Issue description"MediaFileValidatorTest.ValidAudio" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLAsSBUZsYWtlIiFNZWRpYUZpbGVWYWxpZGF0b3JUZXN0LlZhbGlkQXVkaW8M. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jun 4 2018
The first flake happened in the ASAN build that contained https://chromium-review.googlesource.com/1072965 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ASan%20LSan%20Tests%20%281%29/46638 Trying to revert.
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4603361e99c204ae881ffd20f5c07b320c646249 commit 4603361e99c204ae881ffd20f5c07b320c646249 Author: Dominic Battré <battre@chromium.org> Date: Mon Jun 04 07:55:10 2018 Revert "Break down the NativeMediaFileUtil into IO and MediaTaskRunner parts." This reverts commit 7a5f1db86fda6c73b7362eb9e990c080c9bb6d55. Strongly expecting this to be the cause of crbug.com/849171 . First flakes happened when this CL landed. Original change's description: > Break down the NativeMediaFileUtil into IO and MediaTaskRunner parts. > > The NativeMediaFileUtil runs tasks on a TaskScheduler sequence provided > by the MediaFileSystemBackend, but was itself owned and deleted on the > IO thread, where its AsyncFileUtil API was used. > > The NativeMediaFileUtil is split into an outer part, used and owned on > the IO thread, and a "core" containing the MediaPathFilter for use on > the MediaFileSystemBackend's media TaskRunner. > > The MediaFileValidatorTests are also fixed, to tear-down the storage > FileSystemContext before the browser's threads are torn-down. > > Bug: 729716 > Change-Id: I339fe68f28d1bf6330ec4d341d2730df26bc4b30 > Reviewed-on: https://chromium-review.googlesource.com/1072965 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563918} TBR=wez@chromium.org,kinuko@chromium.org,tzik@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 729716, 849171 Change-Id: I0034caf2868bbc94565e883a94e3d0bac2e6af33 Reviewed-on: https://chromium-review.googlesource.com/1084491 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#564011} [modify] https://crrev.com/4603361e99c204ae881ffd20f5c07b320c646249/chrome/browser/media_galleries/fileapi/media_file_system_backend.cc [modify] https://crrev.com/4603361e99c204ae881ffd20f5c07b320c646249/chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc [modify] https://crrev.com/4603361e99c204ae881ffd20f5c07b320c646249/chrome/browser/media_galleries/fileapi/native_media_file_util.cc [modify] https://crrev.com/4603361e99c204ae881ffd20f5c07b320c646249/chrome/browser/media_galleries/fileapi/native_media_file_util.h
,
Jun 4 2018
,
Jun 4 2018
,
Jun 4 2018
Fixed and re-landed in https://chromium-review.googlesource.com/c/chromium/src/+/1085527 but forgot to add this bug #; sorry. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by battre@chromium.org
, Jun 4 2018