New issue
Advanced search Search tips

Issue 849169 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 849475



Sign in to add a comment

Regression : Browser window does not turn into fullscreen mode even after clicking on fullscreen button.

Reported by pranjali...@etouch.net, Jun 4 2018

Issue description

Chrome version : 69.0.3448.0 (Official Build) Revision	881f7188e7bedfd86afd70ed2af61a41667fe141-refs/branch-heads/3448@{#1} (32/64-bit) 

OS : Win(7,8,8.1,10) OS

Steps to reproduce:
1. Launch chrome and navigate to 'https://permission.site/'.
2. Now click on 'Fullscreen' button and press 'ESC' button.
3. Observe.

Actual Result: Browser window does not turn into fullscreen mode even after clicking on fullscreen button.
Expected Result: Browser window should be turn into fullscreen mode after clicking on fullscreen button.

This is a regression issue broken in ‘M-69’ and will soon update other bisect info.
Good build: 69.0.3447.0 
Bad build: 69.0.3448.0  

 
Actual_result.mp4
311 KB View Download
Expected_result.mp4
675 KB View Download
Owner: steimel@chromium.org
Status: Assigned (was: Unconfirmed)
Update:

Unable to provide bisect using hasbisect-per-revision, hence providing bisect using Chromium builds.

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/6ee0391693f4aa448833d50e2c61c8d86f884441..a1dee391232d54b3f32cb7db0518bfc84b88352c?pretty=fuller&n=10000

Suspect: r563682?

steimel@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You!
Cc: steimel@chromium.org
Owner: samans@chromium.org
I don't think this is due to my change. Looking at the regression range, I'd expect maybe 3e5eaae29d310061c0504f7d011f8bb0263e0078?
Concur with c#2. Just built 69.0.3450.0-r564179 locally. Reverting 3e5eaae29d310061c0504f7d011f8bb0263e0078 fixed the fullscreen issue here.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/554a4b6a90144952665ec035d62fd60faade7412

commit 554a4b6a90144952665ec035d62fd60faade7412
Author: Saman Sami <samans@chromium.org>
Date: Mon Jun 04 23:06:45 2018

Revert "Make Compositor::DisableSwapUntilResize work with viz"

This reverts commit 3e5eaae29d310061c0504f7d011f8bb0263e0078.

Reason for revert: causes multiple bugs on Windows and breaks viz_content_browsertests on Mac FYI bots

Original change's description:
> Make Compositor::DisableSwapUntilResize work with viz
> 
> Send a sync IPC to Viz process when size is changing in order
> to prevent frame swaps of wrong size. If a wrong size frame is
> swapped then Windows might stretch our content to fill the window.
> 
> Bug:  811945 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I4960e5a349902b75522c42a9f70b6eac531fdff6
> Reviewed-on: https://chromium-review.googlesource.com/1076530
> Reviewed-by: kylechar <kylechar@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Commit-Queue: Saman Sami <samans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563676}

TBR=danakj@chromium.org,rockot@chromium.org,tsepez@chromium.org,kylechar@chromium.org,samans@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  811945 ,  849283 ,  849169 ,  849155 
Change-Id: Ifada5eb26caf9fb7be5a242c0fb4b97070f4df57
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1085971
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564284}
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.h
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/content/browser/compositor/gpu_process_transport_factory.h
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/content/browser/compositor/test/test_image_transport_factory.h
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/content/browser/compositor/viz_process_transport_factory.cc
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/content/browser/compositor/viz_process_transport_factory.h
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/mojo/public/cpp/bindings/sync_call_restrictions.h
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/services/ui/ws/compositor_frame_sink_client_binding.cc
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/services/ui/ws/compositor_frame_sink_client_binding.h
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/services/ui/ws/frame_generator.h
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/services/ui/ws/platform_display_default.cc
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/services/ui/ws/platform_display_mirror.cc
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/services/viz/privileged/interfaces/compositing/display_private.mojom
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/ui/compositor/compositor.cc
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/ui/compositor/compositor.h
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/ui/compositor/test/in_process_context_factory.cc
[modify] https://crrev.com/554a4b6a90144952665ec035d62fd60faade7412/ui/compositor/test/in_process_context_factory.h

Labels: TE-Verified-69.0.3450.0 TE-Verified-M69
Update:
Rechecked the above issue using latest canary build #69.0.3450.0 on Win(7,8,8.1,10) OS and issue is fixed.Browser window turns into fullscreen mode after clicking on on fullscreen button.

Please refer attached screencast for reference.

Thank You....

Canary_behaviour.mp4
418 KB View Download
Status: Fixed (was: Assigned)

Comment 7 by zmo@chromium.org, Jun 5 2018

Blocking: 849475

Comment 8 Deleted

Sign in to add a comment