"BookmarkAppNavigationThrottleExperimentalWindowOpenBrowserTest.WindowOpenInApp/1" is flaky |
||||||
Issue description"BookmarkAppNavigationThrottleExperimentalWindowOpenBrowserTest.WindowOpenInApp/1" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWwsSBUZsYWtlIlBCb29rbWFya0FwcE5hdmlnYXRpb25UaHJvdHRsZUV4cGVyaW1lbnRhbFdpbmRvd09wZW5Ccm93c2VyVGVzdC5XaW5kb3dPcGVuSW5BcHAvMQw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jun 4 2018
Assiginig to ortuno@ who worked in this space before. Also CCing gab@ as an expert in TestNavigationObserver::WaitForNavigationFinished.
,
Jun 4 2018
Assigned an owner who will disable the test and investigate. Taking out of sheriff queue.
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8cec1a059b6fcb14aec350fb3ff3bd58804b6a29 commit 8cec1a059b6fcb14aec350fb3ff3bd58804b6a29 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Mon Jun 04 08:37:42 2018 desktop-pwas: Disable flaky WindowOpenInApp test TBR=ortuno@chromium.org Bug: 849163 Change-Id: Icf1a392035fadd0d5e7b9f8cebf0794e5b562395 Reviewed-on: https://chromium-review.googlesource.com/1084515 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#564024} [modify] https://crrev.com/8cec1a059b6fcb14aec350fb3ff3bd58804b6a29/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc
,
Jun 4 2018
Also tons of further failures for BookmarkAppNavigationThrottleCommonBrowserTest.OutOfScopePopup and BookmarkAppNavigationThrottleCommonBrowserTest.InScopePopup (but only on macOS): https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BookmarkAppNavigationThrottleCommonBrowserTest Disabling those as well.
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e45d98a3381e1abaf8e2165147d28c3cdcdfe4d9 commit e45d98a3381e1abaf8e2165147d28c3cdcdfe4d9 Author: Dominic Battre <battre@chromium.org> Date: Mon Jun 04 15:56:24 2018 Disable BookmarkAppNavigationThrottleCommonBrowserTest.*Popup* on macOS Disable tests on macOS that timeout flakily. TBR=ortuno@chromium.org Bug: 849163 Change-Id: I968e48ac5da5267a3cc7fa60484c3ef56ed7d4bd Reviewed-on: https://chromium-review.googlesource.com/1085301 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#564105} [modify] https://crrev.com/e45d98a3381e1abaf8e2165147d28c3cdcdfe4d9/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc
,
Jun 4 2018
Re. #2 : wouldn't say I'm an "expert in TestNavigationObserver::WaitForNavigationFinished" :), but would suspect the cause of flakiness being related to a racy observation (e.g. if the thing being observed can ever happen before the observer is registered, it will flake).
,
Jun 8 2018
NtpExtensionBubbleViewBrowserTest.TestBubbleClosedAfterExtensionUninstall just flaked on the waterfall. Please disable or fix as soon as possible. https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8944246680068545552%2F%2B%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FNtpExtensionBubbleViewBrowserTest.TestBubbleClosedAfterExtensionUninstall%2F0 [ RUN ] NtpExtensionBubbleViewBrowserTest.TestBubbleClosedAfterExtensionUninstall [64919:18183:0608/161203.921320:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated. 2018-06-08 16:12:04.134 browser_tests[64919:2520289] *** Owner supplied to -[NSTrackingArea initWithRect:options:owner:userInfo:] referenced a deallocating object. Tracking area behavior is undefined. Break on NSTrackingAreaDeallocatingOwnerError to debug. [64932:775:0608/161204.163586:WARNING:vt_video_decode_accelerator_mac.cc(193)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "codecOpenErr" (-8973) [64932:775:0608/161204.164350:WARNING:vt_video_decode_accelerator_mac.cc(215)] Hardware decoding with VideoToolbox is not supported [64932:775:0608/161204.197974:ERROR:vt_video_encode_accelerator_mac.cc(516)] VTCompressionSessionCreate failed: -12908 [64919:775:0608/161204.677303:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11 [64919:775:0608/161205.651200:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11 [64919:775:0608/161205.929023:ERROR:extension_function_dispatcher.cc(568)] Permission denied for test.sendMessage [64919:775:0608/161205.929136:FATAL:extension_function.cc(504)] Check failed: !browser_client || browser_client->IsShuttingDown() || did_respond() || ignore_all_did_respond_for_testing_do_not_use. test.sendMessage 0 libbase.dylib 0x0000000123f340ae base::debug::StackTrace::StackTrace(unsigned long) + 174 1 libbase.dylib 0x0000000123f3416d base::debug::StackTrace::StackTrace(unsigned long) + 29 2 libbase.dylib 0x0000000123b5be8c base::debug::StackTrace::StackTrace() + 28 3 libbase.dylib 0x0000000123bdac6c logging::LogMessage::~LogMessage() + 460 4 libbase.dylib 0x0000000123bd89d5 logging::LogMessage::~LogMessage() + 21 5 browser_tests 0x00000001076155a0 UIThreadExtensionFunction::~UIThreadExtensionFunction() + 448 6 browser_tests 0x0000000107e51611 extensions::TestSendMessageFunction::~TestSendMessageFunction() + 225 7 browser_tests 0x0000000107e51635 extensions::TestSendMessageFunction::~TestSendMessageFunction() + 21 8 browser_tests 0x0000000107e51659 extensions::TestSendMessageFunction::~TestSendMessageFunction() + 25 9 browser_tests 0x00000001076159cf void content::BrowserThread::DeleteOnThread<(content::BrowserThread::ID)0>::Destruct<UIThreadExtensionFunction>(UIThreadExtensionFunction const*) + 79 10 browser_tests 0x0000000107615975 UIThreadExtensionFunction::Destruct() const + 21 11 browser_tests 0x000000010760f7e6 ExtensionFunctionDeleteTraits::Destruct(ExtensionFunction const*) + 22 12 browser_tests 0x000000010570139c base::RefCountedThreadSafe<ExtensionFunction, ExtensionFunctionDeleteTraits>::Release() const + 60 13 browser_tests 0x0000000105da4899 scoped_refptr<ExtensionFunction>::Release(ExtensionFunction*) + 25 14 browser_tests 0x0000000105da487a scoped_refptr<ExtensionFunction>::~scoped_refptr() + 42 15 browser_tests 0x0000000105da39b5 scoped_refptr<ExtensionFunction>::~scoped_refptr() + 21 16 browser_tests 0x000000010761baf6 extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderFrameHost*, int, base::RepeatingCallback<void (ExtensionFunction::ResponseType, base::ListValue const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, extensions::functions::HistogramValue)> const&) + 3126 17 browser_tests 0x000000010761a438 extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderFrameHost*, int) + 2120 18 browser_tests 0x00000001076c9914 extensions::ExtensionWebContentsObserver::OnRequest(content::RenderFrameHost*, ExtensionHostMsg_Request_Params const&) + 308 19 browser_tests 0x00000001076ca182 void IPC::DispatchToMethodImpl<extensions::ExtensionWebContentsObserver, void (extensions::ExtensionWebContentsObserver::*)(content::RenderFrameHost*, ExtensionHostMsg_Request_Params const&), content::RenderFrameHost, std::__1::tuple<ExtensionHostMsg_Request_Params>, 0ul>(extensions::ExtensionWebContentsObserver*, void (extensions::ExtensionWebContentsObserver::*)(content::RenderFrameHost*, ExtensionHostMsg_Request_Params const&), content::RenderFrameHost*, std::__1::tuple<ExtensionHostMsg_Request_Params>&&, std::__1::integer_sequence<unsigned long, 0ul>) + 162 20 browser_tests 0x00000001076c9fe0 std::__1::enable_if<(sizeof...(ExtensionHostMsg_Request_Params const&)) == (std::tuple_size<std::__1::decay<std::__1::tuple<ExtensionHostMsg_Request_Params> >::type>::value), void>::type IPC::DispatchToMethod<extensions::ExtensionWebContentsObserver, content::RenderFrameHost, ExtensionHostMsg_Request_Params const&, std::__1::tuple<ExtensionHostMsg_Request_Params> >(extensions::ExtensionWebContentsObserver*, void (extensions::ExtensionWebContentsObserver::*)(content::RenderFrameHost*, ExtensionHostMsg_Request_Params const&), content::RenderFrameHost*, std::__1::tuple<ExtensionHostMsg_Request_Params>&&) + 112 21 browser_tests 0x00000001076c9760 bool IPC::MessageT<ExtensionHostMsg_Request_Meta, std::__1::tuple<ExtensionHostMsg_Request_Params>, void>::Dispatch<extensions::ExtensionWebContentsObserver, extensions::ExtensionWebContentsObserver, content::RenderFrameHost, void (extensions::ExtensionWebContentsObserver::*)(content::RenderFrameHost*, ExtensionHostMsg_Request_Params const&)>(IPC::Message const*, extensions::ExtensionWebContentsObserver*, extensions::ExtensionWebContentsObserver*, content::RenderFrameHost*, void (extensions::ExtensionWebContentsObserver::*)(content::RenderFrameHost*, ExtensionHostMsg_Request_Params const&)) + 544 22 browser_tests 0x00000001076c94dd extensions::ExtensionWebContentsObserver::OnMessageReceived(IPC::Message const&, content::RenderFrameHost*) + 333 23 browser_tests 0x000000010dfcbd79 extensions::ChromeExtensionWebContentsObserver::OnMessageReceived(IPC::Message const&, content::RenderFrameHost*) + 233 24 libcontent.dylib 0x0000000130e756b7 content::WebContentsImpl::OnMessageReceived(content::RenderFrameHostImpl*, IPC::Message const&) + 247 25 libcontent.dylib 0x000000012ffa374a content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const&) + 282 26 libcontent.dylib 0x00000001308ffe83 content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) + 835 27 libipc.dylib 0x000000012d2d3975 IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) + 149 28 libipc.dylib 0x000000012d2da8ff void base::internal::FunctorTraits<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), void>::Invoke<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context> const&, IPC::Message const&>(void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context> const&&&, IPC::Message const&&&) + 143 29 libipc.dylib 0x000000012d2da7ff void base::internal::InvokeHelper<false, void>::MakeItSo<void (IPC::ChannelProxy::Context::* const&)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context> const&, IPC::Message const&>(void (IPC::ChannelProxy::Context::* const&&&)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context> const&&&, IPC::Message const&&&) + 95 30 libipc.dylib 0x000000012d2da78d void base::internal::Invoker<base::internal::BindState<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message>, void ()>::RunImpl<void (IPC::ChannelProxy::Context::* const&)(IPC::Message const&), std::__1::tuple<scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message> const&, 0ul, 1ul>(void (IPC::ChannelProxy::Context::* const&&&)(IPC::Message const&), std::__1::tuple<scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message> const&&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) + 125 31 libipc.dylib 0x000000012d2da69c base::internal::Invoker<base::internal::BindState<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message>, void ()>::Run(base::internal::BindStateBase*) + 44 32 libbase.dylib 0x0000000123afe49c base::OnceCallback<void ()>::Run() && + 92 33 libbase.dylib 0x0000000123b5da49 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 1033 34 libbase.dylib 0x0000000123c270ea base::internal::IncomingTaskQueue::RunTask(base::PendingTask*) + 234 35 libbase.dylib 0x0000000123c33b38 base::MessageLoop::RunTask(base::PendingTask*) + 872 36 libbase.dylib 0x0000000123c34109 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 89 37 libbase.dylib 0x0000000123c3443a base::MessageLoop::DoWork() + 570 38 libbase.dylib 0x0000000123c41552 base::MessagePumpCFRunLoopBase::RunWork() + 98 39 libbase.dylib 0x0000000123c414dc ___ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv_block_invoke + 28 40 libbase.dylib 0x0000000123be019a base::mac::CallWithEHFrame(void () block_pointer) + 10 41 libbase.dylib 0x0000000123c403b5 base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 101 42 CoreFoundation 0x00007fff49625a21 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 43 CoreFoundation 0x00007fff496dd26c __CFRunLoopDoSource0 + 108 44 CoreFoundation 0x00007fff49608ab0 __CFRunLoopDoSources0 + 208 45 CoreFoundation 0x00007fff49607f2d __CFRunLoopRun + 1293 46 CoreFoundation 0x00007fff49607787 CFRunLoopRunSpecific + 487 47 Foundation 0x00007fff4b6f3c16 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277 48 libaccelerated_widget_mac.dylib 0x000000014a48d31d ___ZN2ui24CATransactionCoordinator15SynchronizeImplEv_block_invoke + 1277 49 QuartzCore 0x00007fff5475578f CA::Transaction::run_commit_handlers(CATransactionPhase) + 49 50 QuartzCore 0x00007fff54754cc2 CA::Context::commit_transaction(CA::Transaction*) + 1396 51 QuartzCore 0x00007fff5475443d CA::Transaction::commit() + 487 52 AppKit 0x00007fff474d6658 __65+[CATransaction(NSCATransaction) NS_setFlushesWithDisplayRefresh]_block_invoke + 283 53 CoreFoundation 0x00007fff49625427 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23 54 CoreFoundation 0x00007fff4962534f __CFRunLoopDoObservers + 511 55 CoreFoundation 0x00007fff49607ef8 __CFRunLoopRun + 1240 56 CoreFoundation 0x00007fff49607787 CFRunLoopRunSpecific + 487 57 HIToolbox 0x00007fff48914e26 RunCurrentEventLoopInMode + 286 58 HIToolbox 0x00007fff48914a9f ReceiveNextEventCommon + 366 59 HIToolbox 0x00007fff48914914 _BlockUntilNextEventMatchingListInModeWithFilter + 64 60 AppKit 0x00007fff46bdff5f _DPSNextEvent + 2085 61 AppKit 0x00007fff47375b4c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044
,
Jun 9 2018
That seems unrelated to this flaky test.
,
Jun 11 2018
Indeed. Apologies for spamming this bug. I'm going to delete my comments. and file a new bug. Removing this bug from the sheriff queue as well, as the original flake has already been handled. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by battre@chromium.org
, Jun 4 2018