New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849156 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Participants' hotlists:
MakeFilesAppAwesomO-2018


Sign in to add a comment

Clean up and audit existing UMAs

Project Member Reported by sashab@chromium.org, Jun 4 2018

Issue description

- Clean up owners
- Remove no-longer-used UMAs
- Track expiry dates
- Etc

Spreadsheet: go/xf-uma
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1c2233e4325421816cad620b115f219ed6c3cfb

commit b1c2233e4325421816cad620b115f219ed6c3cfb
Author: Sasha Morrissey <sashab@chromium.org>
Date: Mon Jun 04 18:35:56 2018

Set owners for all FileBrowser.* actions to sashab and slangley

Also updated action descriptions.

Bug:  849156 
Change-Id: Iab95daff8faec3e1abb941a5d97e466fcf241fa1
Reviewed-on: https://chromium-review.googlesource.com/1084517
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564161}
[modify] https://crrev.com/b1c2233e4325421816cad620b115f219ed6c3cfb/tools/metrics/actions/actions.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53a0aaf30ed140d1cc123efedbacd5210dd3ffe7

commit 53a0aaf30ed140d1cc123efedbacd5210dd3ffe7
Author: Sasha Morrissey <sashab@chromium.org>
Date: Mon Jun 04 20:01:21 2018

Set owners for all FileBrowser.* histograms to sashab and slangley

Old owners are no longer active on the Files app.

Bug:  849156 
Change-Id: I0098ea2ab5b22ac0d2f057e0c9002f9d11add5c9
Reviewed-on: https://chromium-review.googlesource.com/1084361
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564202}
[modify] https://crrev.com/53a0aaf30ed140d1cc123efedbacd5210dd3ffe7/tools/metrics/histograms/histograms.xml

Labels: -M-69 M-70
Labels: -M-70
Owner: slangley@chromium.org
Status: Assigned (was: Started)
Cc: mtomasz@chromium.org
 Issue 271409  has been merged into this issue.
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a20964bdde1abc1858fbcf2c84c6fdd819ba0cca

commit a20964bdde1abc1858fbcf2c84c6fdd819ba0cca
Author: Stuart Langley <slangley@google.com>
Date: Tue Dec 11 22:25:58 2018

Cleanup existing Files App UMA Metrics.

1/ Fix up the FileManagerRootType enums to reflexct the values sent.
2/ Add back the deprecated "ADD_NEW_SERVICES_MENU" so that the enums
   have a consistent value. Note that there will be a time period where
   the accounting is incorrect for roots > 15.
3/ Add expiry to all FileBrowser metrics, M79 which is the last release
   of 2019.
4/ Mark as obsolete FileBrowser.CloudImport.UserAction which does not
   appear to exist anymore.

Bug:  849156 
Change-Id: If7eea77f079cb6ca24ab9a744924899e2404df3b
Reviewed-on: https://chromium-review.googlesource.com/c/1370156
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615692}
[modify] https://crrev.com/a20964bdde1abc1858fbcf2c84c6fdd819ba0cca/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/a20964bdde1abc1858fbcf2c84c6fdd819ba0cca/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/a20964bdde1abc1858fbcf2c84c6fdd819ba0cca/ui/file_manager/base/js/volume_manager_types.js
[modify] https://crrev.com/a20964bdde1abc1858fbcf2c84c6fdd819ba0cca/ui/file_manager/base/js/volume_manager_types_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment