New issue
Advanced search Search tips

Issue 849144 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in content::SignedExchangePrologue::ParseEncodedLength

Project Member Reported by ClusterFuzz, Jun 4 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6540458646568960

Fuzzer: libFuzzer_signed_exchange_envelope_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x60500000de2a
Crash State:
  content::SignedExchangePrologue::ParseEncodedLength
  content::SignedExchangePrologue::Parse
  signed_exchange_envelope_fuzzer.cc
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=563572:563576

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6540458646568960

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 4 2018

Labels: OS-Mac
Project Member

Comment 2 by ClusterFuzz, Jun 4 2018

Components: Blink>Loader Internals>Core
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by ClusterFuzz, Jun 4 2018

Cc: kouhei@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 4 by ClusterFuzz, Jun 4 2018

Labels: Test-Predator-Auto-Owner
Owner: ksakamoto@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648 (Signed Exchange: Switch to b1 envelope format).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 4 2018

Labels: M-68 Target-68
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 4 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 4 2018

Labels: Pri-1
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44a9e657e0b629ac3518d2887c1aed9870c808e9

commit 44a9e657e0b629ac3518d2887c1aed9870c808e9
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Jun 05 10:04:26 2018

Fix signed_exchange_envelope_fuzzer

It was using wrong constant to check input length.

Bug:  849144 , 848779 
Change-Id: I0408e9147922fcc3d94388709e455d9393165426
Reviewed-on: https://chromium-review.googlesource.com/1086427
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564428}
[modify] https://crrev.com/44a9e657e0b629ac3518d2887c1aed9870c808e9/content/test/fuzzer/signed_exchange_envelope_fuzzer.cc

Project Member

Comment 10 by sheriffbot@chromium.org, Jun 5 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Status: Fixed (was: Started)
Project Member

Comment 12 by ClusterFuzz, Jun 6 2018

ClusterFuzz has detected this issue as fixed in range 564425:564434.

Detailed report: https://clusterfuzz.com/testcase?key=6540458646568960

Fuzzer: libFuzzer_signed_exchange_envelope_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x60500000de2a
Crash State:
  content::SignedExchangePrologue::ParseEncodedLength
  content::SignedExchangePrologue::Parse
  signed_exchange_envelope_fuzzer.cc
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=563572:563576
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=564425:564434

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6540458646568960

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Jun 6 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6540458646568960 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Jun 6 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable -M-68 -Target-68 M-69 Target-69
Project Member

Comment 16 by sheriffbot@chromium.org, Sep 12

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment