New issue
Advanced search Search tips

Issue 849143 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 62400



Sign in to add a comment

Stack-overflow in CXFA_DocumentParser::NormalLoader

Project Member Reported by ClusterFuzz, Jun 4 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5423445832368128

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Stack-overflow
Crash Address: 0x7fff1ba3cce8
Crash State:
  CXFA_DocumentParser::NormalLoader
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=555503:555546

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5423445832368128

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 4 2018

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 4 2018

Cc: dsinclair@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Jun 4 2018

Labels: Test-Predator-Auto-Owner
Owner: dsinclair@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://pdfium.googlesource.com/pdfium/+/70180648ffd01dd3716871758411d2031aaaebbe (Add a CFX_XMLDocument class.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Blocking: 62400
Owner: hnakashima@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/3d7b555aa843b026c9dcb6b0f855af1d358ef2ba

commit 3d7b555aa843b026c9dcb6b0f855af1d358ef2ba
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Tue Jul 17 20:47:27 2018

Limit recursion depth for CXFA_DocumentParser::NormalLoader().

Bug:  chromium:849143 
Change-Id: I973bb3be6151ac3afad850533cb735c03e9f3d2c
Reviewed-on: https://pdfium-review.googlesource.com/38210
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>

[modify] https://crrev.com/3d7b555aa843b026c9dcb6b0f855af1d358ef2ba/xfa/fxfa/parser/cxfa_document_parser.h
[modify] https://crrev.com/3d7b555aa843b026c9dcb6b0f855af1d358ef2ba/xfa/fxfa/parser/cxfa_document_parser.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9eba4d434eb6694ed1d0f9535b9fa93fc353b79c

commit 9eba4d434eb6694ed1d0f9535b9fa93fc353b79c
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Jul 18 02:48:42 2018

Roll src/third_party/pdfium d563855ac72b..8e0c0dbc4876 (2 commits)

https://pdfium.googlesource.com/pdfium.git/+log/d563855ac72b..8e0c0dbc4876


git log d563855ac72b..8e0c0dbc4876 --date=short --no-merges --format='%ad %ae %s'
2018-07-17 asweintraub@google.com Add Deleter and Scoper for FPDF_PAGELINK.
2018-07-17 hnakashima@chromium.org Limit recursion depth for CXFA_DocumentParser::NormalLoader().


Created with:
  gclient setdep -r src/third_party/pdfium@8e0c0dbc4876

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:849143 
TBR=dsinclair@chromium.org

Change-Id: I690589dba2241ff7f211a6c753a0ed74c57bd0a3
Reviewed-on: https://chromium-review.googlesource.com/1140539
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575917}
[modify] https://crrev.com/9eba4d434eb6694ed1d0f9535b9fa93fc353b79c/DEPS

Project Member

Comment 8 by ClusterFuzz, Jul 18

ClusterFuzz has detected this issue as fixed in range 575913:575920.

Detailed report: https://clusterfuzz.com/testcase?key=5423445832368128

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Stack-overflow
Crash Address: 0x7fff1ba3cce8
Crash State:
  CXFA_DocumentParser::NormalLoader
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=555503:555546
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=575913:575920

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5423445832368128

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Jul 18

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5423445832368128 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment