New issue
Advanced search Search tips

Issue 849142 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in test_runner::CopyImageAtAndCapturePixels

Project Member Reported by ClusterFuzz, Jun 4 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5344191874596864

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  test_runner::CopyImageAtAndCapturePixels
  test_runner::TestRunnerForSpecificView::CopyImageAtAndCapturePixelsAsyncThen
  gin::internal::Dispatcher<void
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=557574:557585

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5344191874596864

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 4 2018

Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 4 2018

Labels: Test-Predator-Auto-Owner
Owner: dgozman@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d (Replace WebMockClipboard with MockClipboardHost).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 4 2018

Labels: M-68 Target-68
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 4 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 4 2018

Labels: Pri-1
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 5 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Components: Test
These test_runner bugs often turn out to be in test_runner only, not in Chrome as shipped. Can you confirm whether that's the case here, dgozman? Thanks.
Yes, this is test only.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9b8e584fb9e9acf84db6b7f2805b4abd4177913

commit f9b8e584fb9e9acf84db6b7f2805b4abd4177913
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Jun 05 21:53:26 2018

Fix uninitialized variable in pixel_dump.cc

Bug:  849142 
Change-Id: I1a758908af5e765dd69868a8d045664d208346d3
Reviewed-on: https://chromium-review.googlesource.com/1086229
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564678}
[modify] https://crrev.com/f9b8e584fb9e9acf84db6b7f2805b4abd4177913/content/shell/test_runner/pixel_dump.cc

Status: Fixed (was: Assigned)
Labels: -ReleaseBlock-Stable
Project Member

Comment 12 by ClusterFuzz, Jun 6 2018

ClusterFuzz has detected this issue as fixed in range 564677:564679.

Detailed report: https://clusterfuzz.com/testcase?key=5344191874596864

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  test_runner::CopyImageAtAndCapturePixels
  test_runner::TestRunnerForSpecificView::CopyImageAtAndCapturePixelsAsyncThen
  gin::internal::Dispatcher<void
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=557574:557585
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=564677:564679

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5344191874596864

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Jun 6 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5344191874596864 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Jun 6 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 15 by sheriffbot@chromium.org, Sep 12

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment