A11y and tests need to be updated.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dcf9d10d65251ea2740bd30779a1a2077de4094 commit 9dcf9d10d65251ea2740bd30779a1a2077de4094 Author: sczs <sczs@chromium.org> Date: Thu Jun 07 03:46:54 2018 [ios] Improves Bookmarks accessibility. - Creates constants for BookmarksHome, BookmarksEdit, and BookmarksFolderEditor Done buttons and container identifiers. - Updates tests so they use these newly created constants. - Fixes BookmarkFolderCell and TableUrlCell accessibility identifiers, labels and traits. Bug: 849140 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iad749da41610fb3c3e9b06d2a11db08716920f3b Reviewed-on: https://chromium-review.googlesource.com/1084318 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#565171} [modify] https://crrev.com/9dcf9d10d65251ea2740bd30779a1a2077de4094/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/9dcf9d10d65251ea2740bd30779a1a2077de4094/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm [modify] https://crrev.com/9dcf9d10d65251ea2740bd30779a1a2077de4094/ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm [modify] https://crrev.com/9dcf9d10d65251ea2740bd30779a1a2077de4094/ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.mm [modify] https://crrev.com/9dcf9d10d65251ea2740bd30779a1a2077de4094/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm [modify] https://crrev.com/9dcf9d10d65251ea2740bd30779a1a2077de4094/ios/chrome/browser/ui/bookmarks/bookmark_ui_constants.h [modify] https://crrev.com/9dcf9d10d65251ea2740bd30779a1a2077de4094/ios/chrome/browser/ui/bookmarks/bookmark_ui_constants.mm [modify] https://crrev.com/9dcf9d10d65251ea2740bd30779a1a2077de4094/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm [modify] https://crrev.com/9dcf9d10d65251ea2740bd30779a1a2077de4094/ios/chrome/browser/ui/bookmarks/cells/bookmark_folder_item.mm [modify] https://crrev.com/9dcf9d10d65251ea2740bd30779a1a2077de4094/ios/chrome/browser/ui/bookmarks/cells/bookmark_home_node_item.mm [modify] https://crrev.com/9dcf9d10d65251ea2740bd30779a1a2077de4094/ios/chrome/browser/ui/keyboard_commands_egtest.mm [modify] https://crrev.com/9dcf9d10d65251ea2740bd30779a1a2077de4094/ios/chrome/browser/ui/signin_interaction/signin_interaction_controller_egtest.mm [modify] https://crrev.com/9dcf9d10d65251ea2740bd30779a1a2077de4094/ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm [modify] https://crrev.com/9dcf9d10d65251ea2740bd30779a1a2077de4094/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/9dcf9d10d65251ea2740bd30779a1a2077de4094/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/9dcf9d10d65251ea2740bd30779a1a2077de4094/ios/chrome/test/earl_grey/chrome_matchers.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/273cf09720958bdc83b75d7596ae5e0b1988310f commit 273cf09720958bdc83b75d7596ae5e0b1988310f Author: sczs <sczs@chromium.org> Date: Mon Jun 11 19:56:24 2018 [ios] Moves Bookmarks behind UIRefresh Phase1 flag. - Updates Bookmarks EG and UnitTests to pass using the new UIRefresh. - Disables testUndoDeleteBookmarkFromSwipe and testSwipeToDeleteDisabledInEditMode on UIRefresh, non-compact, iOS11 since a "short" swipe can't be reproduced using EG. Bug: 849140 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8b596b871dbc04c6e443a758d5964f9a11fa5612 Reviewed-on: https://chromium-review.googlesource.com/1092073 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#566111} [modify] https://crrev.com/273cf09720958bdc83b75d7596ae5e0b1988310f/ios/chrome/browser/experimental_flags.mm [modify] https://crrev.com/273cf09720958bdc83b75d7596ae5e0b1988310f/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm [modify] https://crrev.com/273cf09720958bdc83b75d7596ae5e0b1988310f/ios/chrome/browser/ui/bookmarks/cells/BUILD.gn [modify] https://crrev.com/273cf09720958bdc83b75d7596ae5e0b1988310f/ios/chrome/browser/ui/bookmarks/cells/bookmark_parent_folder_item_unittest.mm [modify] https://crrev.com/273cf09720958bdc83b75d7596ae5e0b1988310f/ios/chrome/browser/ui/bookmarks/cells/bookmark_text_field_item_unittest.mm
Comment 1 by sczs@chromium.org
, Jun 4 2018