<input type=color> with <datalist> doesn't show expected suggested colors |
|||||
Issue description
Chrome Version: 67 stable
OS: All but iOS
What steps will reproduce the problem?
(1) Open the following URL:
data:text/html;charset=utf-8,<input type="color" value="#ffffff" list="colorList"> <datalist id="colorList"><option value="#000000"></datalist>
(2) Click on the color swatch
(3) Look at the popup
What is the expected result?
The popup contains a black square button, and [Other...] button.
What happens instead?
The popup contains a *white* square button, and [Other...] button.
Please use labels and text to provide additional information.
Regression by https://chromium-review.googlesource.com/c/chromium/src/+/821954
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d40a90a349b6e4dbe843aedadc78c82fce063d8 commit 0d40a90a349b6e4dbe843aedadc78c82fce063d8 Author: Kent Tamura <tkent@chromium.org> Date: Mon Jun 04 05:42:59 2018 input[type=color]: Fix a regression that suggested colors were broken if OPTION's labels were not #rrggbb. crrev.com/525311 caused this regression. ColorChooserPopupUIController should pass color strings to the popup UI code, instead of label strings. Bug: 849130 Change-Id: I2da1e2c032c1b0dba8fbffd4ded2a24b5c6dc0f6 Reviewed-on: https://chromium-review.googlesource.com/1084148 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#564001} [add] https://crrev.com/0d40a90a349b6e4dbe843aedadc78c82fce063d8/third_party/WebKit/LayoutTests/fast/forms/color/color-suggestion-picker-appearance-value-attribute-expected.html [add] https://crrev.com/0d40a90a349b6e4dbe843aedadc78c82fce063d8/third_party/WebKit/LayoutTests/fast/forms/color/color-suggestion-picker-appearance-value-attribute.html [modify] https://crrev.com/0d40a90a349b6e4dbe843aedadc78c82fce063d8/third_party/blink/renderer/core/html/forms/color_chooser_popup_ui_controller.cc
,
Jun 4 2018
,
Jun 5 2018
Verified the fix with 69.0.3450.0 canary
,
Jun 6 2018
Approved - branch:3440
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d3ee847a0c6cd4ae7663cf61f0514dc93de289a commit 4d3ee847a0c6cd4ae7663cf61f0514dc93de289a Author: Kent Tamura <tkent@chromium.org> Date: Thu Jun 07 02:59:32 2018 Merge "input[type=color]: Fix a regression that suggested colors were broken if OPTION's labels were not #rrggbb." to M68 crrev.com/525311 caused this regression. ColorChooserPopupUIController should pass color strings to the popup UI code, instead of label strings. Bug: 849130 Change-Id: I2da1e2c032c1b0dba8fbffd4ded2a24b5c6dc0f6 Reviewed-on: https://chromium-review.googlesource.com/1084148 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#564001}(cherry picked from commit 0d40a90a349b6e4dbe843aedadc78c82fce063d8) Reviewed-on: https://chromium-review.googlesource.com/1090290 Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#229} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [add] https://crrev.com/4d3ee847a0c6cd4ae7663cf61f0514dc93de289a/third_party/WebKit/LayoutTests/fast/forms/color/color-suggestion-picker-appearance-value-attribute-expected.html [add] https://crrev.com/4d3ee847a0c6cd4ae7663cf61f0514dc93de289a/third_party/WebKit/LayoutTests/fast/forms/color/color-suggestion-picker-appearance-value-attribute.html [modify] https://crrev.com/4d3ee847a0c6cd4ae7663cf61f0514dc93de289a/third_party/blink/renderer/core/html/forms/color_chooser_popup_ui_controller.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by joelhockey@chromium.org
, Jun 4 2018Owner: ----
Status: Available (was: Assigned)