New issue
Advanced search Search tips

Issue 849129 link

Starred by 4 users
Status: Fixed
Owner:
sdy@chromium.org
Closed: Aug 14
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: ----



Sign in to add a comment

SaveCardBubbleViewsFullFormBrowserTest, All/AutofillDevToolsSanityTest.TestDispatchKeyEventShowsAutoFill/* failing on Mac 10.11,msan

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jun 4 2018

Comment 1 by tapted@chromium.org, Jun 4 2018

Owner: sdy@chromium.org
Status: Assigned (was: Available)
Errors on multiple builders. Most useful errors are probably from 

https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20%281%29/41072

"De-jank window resizing in MacViews (part 1)." is the only CL.

It looks like there are nested runloops, which is causing some new/unexpected lifetime flows.

All/AutofillDevToolsSanityTest.TestDispatchKeyEventShowsAutoFill/0
PDFExtensionTest.NavigationOnCorrectTab
All/AutofillDevToolsSanityTest.TestDispatchKeyEventShowsAutoFill/1

[22455:775:0602/204231.133696:INFO:CONSOLE(1)] "didShowSuggestions", source:  (1)
=================================================================
==22455==ERROR: AddressSanitizer: heap-use-after-free on address 0x61100043d210 at pc 0x00011e3c8340 bp 0x7ffee7386f30 sp 0x7ffee7386f28
READ of size 8 at 0x61100043d210 thread T0
    #0 0x11e3c833f in autofill::AutofillPopupControllerImpl::Show(std::__1::vector<autofill::Suggestion, std::__1::allocator<autofill::Suggestion> > const&) ??:0:0
    #1 0x11e3d0eaf in autofill::AutofillPopupControllerImplMac::Show(std::__1::vector<autofill::Suggestion, std::__1::allocator<autofill::Suggestion> > const&) ??:0:0
    #2 0x11e3d550a in autofill::ChromeAutofillClient::ShowAutofillPopup(gfx::RectF const&, base::i18n::TextDirection, std::__1::vector<autofill::Suggestion, std::__1::allocator<autofill::Suggestion> > const&, base::WeakPtr<autofill::AutofillPopupDelegate>) ??:0:0
    #3 0x11bb6b5bf in autofill::AutofillExternalDelegate::OnSuggestionsReturned(int, std::__1::vector<autofill::Suggestion, std::__1::allocator<autofill::Suggestion> > const&, bool) ??:0:0
    #4 0x11bb53881 in autofill::AutocompleteHistoryManager::SendSuggestions(std::__1::vector<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> >, std::__1::allocator<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > > > const*) ??:0:0
    #5 0x11bb547a2 in autofill::AutocompleteHistoryManager::OnWebDataServiceRequestDone(int, std::__1::unique_ptr<WDTypedResult, std::__1::default_delete<WDTypedResult> >) ??:0:0
    #6 0x11b1ad9ba in WebDataRequestManager::RequestCompletedOnThread(std::__1::unique_ptr<WebDataRequest, std::__1::default_delete<WebDataRequest> >, std::__1::unique_ptr<WDTypedResult, std::__1::default_delete<WDTypedResult> >) ??:0:0
    #7 0x11b1ae12e in void base::internal::FunctorTraits<void (WebDataRequestManager::*)(std::__1::unique_ptr<WebDataRequest, std::__1::default_delete<WebDataRequest> >, std::__1::unique_ptr<WDTypedResult, std::__1::default_delete<WDTypedResult> >), void>::Invoke<void (WebDataRequestManager::*)(std::__1::unique_ptr<WebDataRequest, std::__1::default_delete<WebDataRequest> >, std::__1::unique_ptr<WDTypedResult, std::__1::default_delete<WDTypedResult> >), scoped_refptr<WebDataRequestManager>, std::__1::unique_ptr<WebDataRequest, std::__1::default_delete<WebDataRequest> >, std::__1::unique_ptr<WDTypedResult, std::__1::default_delete<WDTypedResult> > >(void (WebDataRequestManager::*)(std::__1::unique_ptr<WebDataRequest, std::__1::default_delete<WebDataRequest> >, std::__1::unique_ptr<WDTypedResult, std::__1::default_delete<WDTypedResult> >), scoped_refptr<WebDataRequestManager>&&, std::__1::unique_ptr<WebDataRequest, std::__1::default_delete<WebDataRequest> >&&, std::__1::unique_ptr<WDTypedResult, std::__1::default_delete<WDTypedResult> >&&) ??:0:0
    #8 0x114391858 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ??:0:0
    #9 0x1144120ef in base::internal::IncomingTaskQueue::RunTask(base::PendingTask*) ??:0:0
    #10 0x11441cfce in base::MessageLoop::RunTask(base::PendingTask*) ??:0:0
    #11 0x11441dac0 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) ??:0:0
    #12 0x11441e183 in base::MessageLoop::DoWork() ??:0:0
    #13 0x114427e4c in base::MessagePumpCFRunLoopBase::RunWork() ??:0:0
    #14 0x1143de839 in base::mac::CallWithEHFrame(void () block_pointer) ??:0:0
    #15 0x114426415 in base::MessagePumpCFRunLoopBase::RunWorkSource(void*) ??:0:0
    #16 0x7fff2e46aa20 in __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ ??:0:0
    #17 0x7fff2e52226b in __CFRunLoopDoSource0 ??:0:0
    #18 0x7fff2e44daaf in __CFRunLoopDoSources0 ??:0:0
    #19 0x7fff2e44cf2c in __CFRunLoopRun ??:0:0
    #20 0x7fff2e44c786 in CFRunLoopRunSpecific ??:0:0
    #21 0x7fff2d759e25 in RunCurrentEventLoopInMode ??:0:0
    #22 0x7fff2d759b95 in ReceiveNextEventCommon ??:0:0
    #23 0x7fff2d759913 in _BlockUntilNextEventMatchingListInModeWithFilter ??:0:0
    #24 0x7fff2ba24f5e in _DPSNextEvent ??:0:0
    #25 0x7fff2c1bab4b in -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] ??:0:0
    #26 0x114869780 in __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke ??:0:0
    #27 0x1143de839 in base::mac::CallWithEHFrame(void () block_pointer) ??:0:0
    #28 0x114869331 in -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] ??:0:0
    #29 0x7fff2ba19d6c in -[NSApplication run] ??:0:0
    #30 0x11442a9e2 in base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) ??:0:0
    #31 0x114425440 in base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) ??:0:0
    #32 0x11441be75 in base::MessageLoop::Run(bool) ??:0:0
    #33 0x1144b79bc in base::RunLoop::Run() ??:0:0
    #34 0x115bc4a79 in content::DOMMessageQueue::WaitForMessage(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) ??:0:0
    #35 0x115bbe450 in content::(anonymous namespace)::ExecuteScriptHelper(content::RenderFrameHost*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >*) ??:0:0
    #36 0x115bbcfd6 in content::ExecuteScriptAndExtractString(content::ToRenderFrameHost const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) ??:0:0
    #37 0x108e6419b in void (anonymous namespace)::DispatchOnTestSuiteSkipCheck<>(DevToolsWindow*, char const*) ??:0:0
    #38 0x108e43029 in void (anonymous namespace)::DispatchOnTestSuite<>(DevToolsWindow*, char const*) ??:0:0
    #39 0x108e3cbf9 in AutofillDevToolsSanityTest_TestDispatchKeyEventShowsAutoFill_Test::RunTestOnMainThread() ??:0:0
    #40 0x115baeb0a in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ??:0:0
    #41 0x11487c66b in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ??:0:0
    #42 0x11487993d in ChromeBrowserMainParts::PreMainMessageLoopRun() ??:0:0
    #43 0x10f548332 in content::BrowserMainLoop::PreMainMessageLoopRun() ??:0:0
    #44 0x1105c8e7e in content::StartupTaskRunner::RunAllTasksNow() ??:0:0
    #45 0x10f543b09 in content::BrowserMainLoop::CreateStartupTasks() ??:0:0
    #46 0x10f550554 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ??:0:0
    #47 0x10f53cd0e in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ??:0:0
    #48 0x114218a9a in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ??:0:0
    #49 0x11421b554 in content::ContentMainRunnerImpl::Run() ??:0:0
    #50 0x11ab7904c in service_manager::Main(service_manager::MainParams const&) ??:0:0
    #51 0x114218770 in content::ContentMain(content::ContentMainParams const&) ??:0:0
    #52 0x115bad735 in content::BrowserTestBase::SetUp() ??:0:0
    #53 0x1146c2000 in InProcessBrowserTest::SetUp() ??:0:0
    #54 0x10c85f7f4 in testing::Test::Run() ??:0:0
    #55 0x10c861c55 in testing::TestInfo::Run() ??:0:0
    #56 0x10c8630c6 in testing::TestCase::Run() ??:0:0
    #57 0x10c888666 in testing::internal::UnitTestImpl::RunAllTests() ??:0:0
    #58 0x10c887abd in testing::UnitTest::Run() ??:0:0
    #59 0x114714876 in base::TestSuite::Run() ??:0:0
    #60 0x114361df5 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ??:0:0
    #61 0x115c32089 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ??:0:0
    #62 0x114362aae in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ??:0:0
    #63 0x114361c4c in main ??:0:0
    #64 0x7fff55e06114 in start ??:0:0
0x61100043d210 is located 144 bytes inside of 256-byte region [0x61100043d180,0x61100043d280)
freed by thread T0 here:
    #0 0x1357c8632 in __sanitizer_finish_switch_fiber ??:0:0
    #1 0x11e3cce0c in autofill::AutofillPopupControllerImpl::Hide() ??:0:0
    #2 0x11e3d5adc in autofill::ChromeAutofillClient::HideAutofillPopup() ??:0:0
    #3 0x11bb6dc54 in autofill::AutofillExternalDelegate::DidAcceptSuggestion(std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, int, int) ??:0:0
    #4 0x11e3cdc04 in autofill::AutofillPopupControllerImpl::AcceptSuggestion(int) ??:0:0
    #5 0x11e3cd827 in autofill::AutofillPopupControllerImpl::AcceptSelectedLine() ??:0:0
    #6 0x11e3c9049 in autofill::AutofillPopupControllerImpl::HandleKeyPressEvent(content::NativeWebKeyboardEvent const&) ??:0:0
    #7 0x110252a9d in content::RenderWidgetHostImpl::KeyPressListenersHandleEvent(content::NativeWebKeyboardEvent const&) ??:0:0
    #8 0x110251f2d in content::RenderWidgetHostImpl::ForwardKeyboardEventWithCommands(content::NativeWebKeyboardEvent const&, ui::LatencyInfo const&, std::__1::vector<content::EditCommand, std::__1::allocator<content::EditCommand> > const*, bool*) ??:0:0
    #9 0x110251b93 in content::RenderWidgetHostImpl::ForwardKeyboardEvent(content::NativeWebKeyboardEvent const&) ??:0:0
    #10 0x10f74273c in content::protocol::InputHandler::InputInjector::InjectKeyboardEvent(content::NativeWebKeyboardEvent const&, std::__1::unique_ptr<content::protocol::Input::Backend::DispatchKeyEventCallback, std::__1::default_delete<content::protocol::Input::Backend::DispatchKeyEventCallback> >) ??:0:0
    #11 0x10f7412ff in content::protocol::InputHandler::DispatchKeyEvent(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::protocol::Maybe<int>, content::protocol::Maybe<double>, content::protocol::Maybe<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, content::protocol::Maybe<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, content::protocol::Maybe<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, content::protocol::Maybe<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, content::protocol::Maybe<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, content::protocol::Maybe<int>, content::protocol::Maybe<int>, content::protocol::Maybe<bool>, content::protocol::Maybe<bool>, content::protocol::Maybe<bool>, content::protocol::Maybe<int>, std::__1::unique_ptr<content::protocol::Input::Backend::DispatchKeyEventCallback, std::__1::default_delete<content::protocol::Input::Backend::DispatchKeyEventCallback> >) ??:0:0
    #12 0x10f742a6a in non-virtual thunk to content::protocol::InputHandler::DispatchKeyEvent(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::protocol::Maybe<int>, content::protocol::Maybe<double>, content::protocol::Maybe<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, content::protocol::Maybe<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, content::protocol::Maybe<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, content::protocol::Maybe<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, content::protocol::Maybe<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, content::protocol::Maybe<int>, content::protocol::Maybe<int>, content::protocol::Maybe<bool>, content::protocol::Maybe<bool>, content::protocol::Maybe<bool>, content::protocol::Maybe<int>, std::__1::unique_ptr<content::protocol::Input::Backend::DispatchKeyEventCallback, std::__1::default_delete<content::protocol::Input::Backend::DispatchKeyEventCallback> >) ??:0:0
    #13 0x10f17a870 in content::protocol::Input::DispatcherImpl::dispatchKeyEvent(int, std::__1::unique_ptr<content::protocol::DictionaryValue, std::__1::default_delete<content::protocol::DictionaryValue> >, content::protocol::ErrorSupport*) ??:0:0
    #14 0x10f178530 in content::protocol::Input::DispatcherImpl::dispatch(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::unique_ptr<content::protocol::DictionaryValue, std::__1::default_delete<content::protocol::DictionaryValue> >) ??:0:0
    #15 0x10f211085 in content::protocol::UberDispatcher::dispatch(std::__1::unique_ptr<content::protocol::Value, std::__1::default_delete<content::protocol::Value> >, int*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) ??:0:0
    #16 0x10f6c5a25 in content::DevToolsSession::DispatchProtocolMessage(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) ??:0:0
    #17 0x10f68bce4 in content::DevToolsAgentHostImpl::DispatchProtocolMessage(content::DevToolsAgentHostClient*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) ??:0:0
    #18 0x11d67f9c6 in DevToolsUIBindings::DispatchProtocolMessageFromDevToolsFrontend(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) ??:0:0
    #19 0x11d6386c7 in bool (anonymous namespace)::ParseAndHandle<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&>(base::RepeatingCallback<void (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)> const&, base::RepeatingCallback<void (base::Value const*)> const&, base::ListValue const&) ??:0:0
    #20 0x11d636cd4 in DispatcherImpl::Dispatch(base::RepeatingCallback<void (base::Value const*)> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, base::ListValue const*) ??:0:0
    #21 0x11d670413 in DevToolsUIBindings::HandleMessageFromDevToolsFrontend(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) ??:0:0
    #22 0x110830430 in non-virtual thunk to content::DevToolsFrontendHostImpl::DispatchEmbedderMessage(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) ??:0:0
    #23 0x10e7b6c4d in blink::mojom::DevToolsFrontendHostStubDispatch::Accept(blink::mojom::DevToolsFrontendHost*, mojo::Message*) ??:0:0
    #24 0x11842716c in mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) ??:0:0
    #25 0x1184258a0 in mojo::FilterChain::Accept(mojo::Message*) ??:0:0
    #26 0x11842ad1b in mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*) ??:0:0
    #27 0x1181f843c in IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnProxyThread(mojo::Message) ??:0:0
    #28 0x1181f1ef3 in base::internal::Invoker<base::internal::BindState<void (IPC::(anonymous namespace)::ChannelAssociatedGroupController::*)(mojo::Message), scoped_refptr<IPC::(anonymous namespace)::ChannelAssociatedGroupController>, base::internal::PassedWrapper<mojo::Message> >, void ()>::Run(base::internal::BindStateBase*) ??:0:0
    #29 0x114391858 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ??:0:0
previously allocated by thread T0 here:
    #0 0x1357c8032 in __sanitizer_finish_switch_fiber ??:0:0
    #1 0x11e3d050b in autofill::AutofillPopupControllerImpl::GetOrCreate(base::WeakPtr<autofill::AutofillPopupControllerImpl>, base::WeakPtr<autofill::AutofillPopupDelegate>, content::WebContents*, NSView*, gfx::RectF const&, base::i18n::TextDirection) ??:0:0
    #2 0x11e3d537d in autofill::ChromeAutofillClient::ShowAutofillPopup(gfx::RectF const&, base::i18n::TextDirection, std::__1::vector<autofill::Suggestion, std::__1::allocator<autofill::Suggestion> > const&, base::WeakPtr<autofill::AutofillPopupDelegate>) ??:0:0
    #3 0x11bb6b5bf in autofill::AutofillExternalDelegate::OnSuggestionsReturned(int, std::__1::vector<autofill::Suggestion, std::__1::allocator<autofill::Suggestion> > const&, bool) ??:0:0
    #4 0x11bb53881 in autofill::AutocompleteHistoryManager::SendSuggestions(std::__1::vector<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> >, std::__1::allocator<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > > > const*) ??:0:0
    #5 0x11bb547a2 in autofill::AutocompleteHistoryManager::OnWebDataServiceRequestDone(int, std::__1::unique_ptr<WDTypedResult, std::__1::default_delete<WDTypedResult> >) ??:0:0
    #6 0x11b1ad9ba in WebDataRequestManager::RequestCompletedOnThread(std::__1::unique_ptr<WebDataRequest, std::__1::default_delete<WebDataRequest> >, std::__1::unique_ptr<WDTypedResult, std::__1::default_delete<WDTypedResult> >) ??:0:0
    #7 0x11b1ae12e in void base::internal::FunctorTraits<void (WebDataRequestManager::*)(std::__1::unique_ptr<WebDataRequest, std::__1::default_delete<WebDataRequest> >, std::__1::unique_ptr<WDTypedResult, std::__1::default_delete<WDTypedResult> >), void>::Invoke<void (WebDataRequestManager::*)(std::__1::unique_ptr<WebDataRequest, std::__1::default_delete<WebDataRequest> >, std::__1::unique_ptr<WDTypedResult, std::__1::default_delete<WDTypedResult> >), scoped_refptr<WebDataRequestManager>, std::__1::unique_ptr<WebDataRequest, std::__1::default_delete<WebDataRequest> >, std::__1::unique_ptr<WDTypedResult, std::__1::default_delete<WDTypedResult> > >(void (WebDataRequestManager::*)(std::__1::unique_ptr<WebDataRequest, std::__1::default_delete<WebDataRequest> >, std::__1::unique_ptr<WDTypedResult, std::__1::default_delete<WDTypedResult> >), scoped_refptr<WebDataRequestManager>&&, std::__1::unique_ptr<WebDataRequest, std::__1::default_delete<WebDataRequest> >&&, std::__1::unique_ptr<WDTypedResult, std::__1::default_delete<WDTypedResult> >&&) ??:0:0
    #8 0x114391858 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ??:0:0

Comment 2 by tapted@chromium.org, Jun 4 2018

Components: UI>Browser
Labels: OS-Mac
Ignore the ChromeOS bot in the description. That's Issue 849128
10.11 started in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/26935

(again this is the only CL)

SaveCardBubbleViewsFullFormBrowserTest.Upload_ClickingNoThanksClosesBubbleIfSecondaryUiMdExpOff
SaveCardBubbleViewsFullFormBrowserTest.Local_ClickingNoThanksClosesBubbleIfSecondaryUiMdExpOff
PDFExtensionTest.NavigationOnCorrectTab
SaveCardBubbleViewsFullFormBrowserTest.Upload_ClickingCloseClosesBubbleIfSecondaryUiMdExpOn
SaveCardBubbleViewsFullFormBrowserTest.Local_ClickingSaveClosesBubble

Comment 3 by tapted@chromium.org, Jun 4 2018

Components: UI>Browser>Autofill
Labels: -Pri-2 Pri-1
Summary: SaveCardBubbleViewsFullFormBrowserTest, All/AutofillDevToolsSanityTest.TestDispatchKeyEventShowsAutoFill/* failing on Mac 10.11,msan (was: browser_tests failing on multiple builders)
PDFExtensionTest.NavigationOnCorrectTab dries up in later cycles.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/26956 has persistent failures still

SaveCardBubbleViewsFullFormBrowserTest.Upload_ClickingNoThanksClosesBubbleIfSecondaryUiMdExpOff
SaveCardBubbleViewsFullFormBrowserTest.Upload_ClickingSaveClosesBubble
SaveCardBubbleViewsFullFormBrowserTest.Local_ClickingNoThanksClosesBubbleIfSecondaryUiMdExpOff
SaveCardBubbleViewsFullFormBrowserTest.Upload_ClickingCloseClosesBubbleIfSecondaryUiMdExpOn
SaveCardBubbleViewsFullFormBrowserTest.Local_ClickingSaveClosesBubble

Comment 4 by sdy@chromium.org, Jun 4 2018

Status: Started (was: Assigned)
Yeah. The new nested run loops introduced by that change only run directly from CA callbacks… but there's definitely more blocking happening, which is breaking a bunch of test assumptions that turned out to be fairly fragile (e.g. that you can perform any navigation and then assume that the navigation will still be pending when you get back to test code).
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33c142b74c7311a6a59f4fb2729f02ea05d806c0

commit 33c142b74c7311a6a59f4fb2729f02ea05d806c0
Author: Trent Apted <tapted@chromium.org>
Date: Mon Jun 04 02:14:25 2018

Disable a few failing tests on Mac after resize tweaks in r563958.

Possibly some assumptions these tests are relying on have changed.
Details in  https://crbug.com/849129 

TBR=sdy@chromium.org

Bug:  849129 ,  837660 
Change-Id: I6d01ae3ae0f054df982e4fdc4fede3abc9977557
Reviewed-on: https://chromium-review.googlesource.com/1084143
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563988}
[modify] https://crrev.com/33c142b74c7311a6a59f4fb2729f02ea05d806c0/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/33c142b74c7311a6a59f4fb2729f02ea05d806c0/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc

Comment 6 by tapted@chromium.org, Jun 4 2018 

hm. these are still failing in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/26961

SaveCardBubbleViewsFullFormBrowserTest.Upload_ClickingNoThanksClosesBubbleIfSecondaryUiMdExpOff
SaveCardBubbleViewsFullFormBrowserTest.Upload_ClickingCloseClosesBubbleIfSecondaryUiMdExpOn
SaveCardBubbleViewsFullFormBrowserTest.Local_ClickingNoThanksClosesBubbleIfSecondaryUiMdExpOff

...

Comment 7 by tapted@chromium.org, Jun 4 2018 

dang it.. too many underscores. (and too much copy-paste)
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66d06c330922e3ac9a5d7e1e1a127f73fe3c7d85

commit 66d06c330922e3ac9a5d7e1e1a127f73fe3c7d85
Author: Trent Apted <tapted@chromium.org>
Date: Mon Jun 04 04:33:42 2018

Properly disable *CloseBubble* tests in save_card_bubble_views_browsertest.cc on Mac

TBR=sdy@chromium.org

Bug:  849129 
Change-Id: Ie79332db99b99040f58fc38995213a79afd56b1e
Reviewed-on: https://chromium-review.googlesource.com/1084358
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563996}
[modify] https://crrev.com/66d06c330922e3ac9a5d7e1e1a127f73fe3c7d85/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/641e968b89651387233e56792ddb6ba7662b616b

commit 641e968b89651387233e56792ddb6ba7662b616b
Author: Sidney San Martín <sdy@chromium.org>
Date: Mon Jun 11 19:08:55 2018

Create views::test::WidgetDestroyedWaiter.

Bug:  849129 
Change-Id: I2d618fb319a43d8a9727cdde3c17c85da77b6f03
Reviewed-on: https://chromium-review.googlesource.com/1086509
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566094}
[modify] https://crrev.com/641e968b89651387233e56792ddb6ba7662b616b/chrome/browser/ui/test/test_browser_dialog.cc
[modify] https://crrev.com/641e968b89651387233e56792ddb6ba7662b616b/ui/views/test/widget_test.cc
[modify] https://crrev.com/641e968b89651387233e56792ddb6ba7662b616b/ui/views/test/widget_test.h
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fb697cfa28873ffaf12d455e17637d9a6b05f58

commit 2fb697cfa28873ffaf12d455e17637d9a6b05f58
Author: Sidney San Martín <sdy@chromium.org>
Date: Tue Jun 12 00:14:30 2018

Fix a race in the save credit card bubble tests.

Before this change, several tests relied on waiting for the initial
navigation (from `FillAndSubmitForm()`) later on. However, as of
r563958, the navigation may have already happened by the time the
observer is created, so the tests were disabled.

This shuffles around the various waits so that the tests actually wait
on the events they intend to.

Bug:  849129 
Change-Id: I20c9544e98f3d571591a037c7c97b7bed195c3dd
Reviewed-on: https://chromium-review.googlesource.com/1084322
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566220}
[modify] https://crrev.com/2fb697cfa28873ffaf12d455e17637d9a6b05f58/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/2fb697cfa28873ffaf12d455e17637d9a6b05f58/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/2fb697cfa28873ffaf12d455e17637d9a6b05f58/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h

Comment 12 by sdy@chromium.org, Jul 11

Labels: Pri-2

Comment 13 by sdy@chromium.org, Aug 14

Status: Fixed (was: Started)
Looks like this was fixed (c#11).
►

Sign in to add a comment