New issue
Advanced search Search tips

Issue 849123 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Chrome fails to add google-chrome repository to openSUSE Leap 15.0 package manager

Reported by john.ser...@gmail.com, Jun 3 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.62 Safari/537.36

Steps to reproduce the problem:
1. Install openSUSE Leap 15.0
2. Install Google Chrome from www.google.com/chrome

What is the expected behavior?
The /etc/cron.daily/google-chrome script should determine that the package manager is yast and add the google-chrome repository by creating the /etc/zypp/repos.d/google-chrome.repo file.

What went wrong?
The /etc/cron.daily/google-chrome script fails to determine that the package manager is yast. openSUSE Leap 15.0 does not have the /etc/SuSE-release file that was included in prior releases of openSUSE Leap. The distribution ID as reported by the "lsb_release -i" is "openSUSE"; the script looks for "SUSE LINUX", but not "openSUSE".

Did this work before? Yes Chrome 67.0.3396.62 and openSUSE Leap 42.3

Chrome version: 67.0.3396.62  Channel: stable
OS Version: openSUSE Leap 15.0
Flash Version: 29.0.0.171

I was able to resolve this issue by changing the determine_rpm_package_manager function in the /etc/cron.daily/google-chrome script to look for not only "SUSE LINUX" but also "openSUSE".
 
Cc: pbomm...@chromium.org thomasanderson@chromium.org
Labels: Needs-Triage-M67
Labels: TE-NeedsTriageFromHYD Triaged-ET
john.serock@ Thanks for the issue.

As this issue is related to openSUSE Leap 15.0, this setup is not available at TE end to test this issue. Hence adding 'TE-NeedsTriageFromHYD' and requesting someone from InHouse team to look into this issue and help in further triaging.

Thanks..
Cc: thestig@chromium.org
Labels: -Pri-2 Pri-1
Owner: thomasanderson@chromium.org
Status: Started (was: Unconfirmed)
Thanks for reporting this issue.  We'll try to have this fixed soon
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0d6a9c90b68cfdeaeefe640ca247e46662fe779

commit a0d6a9c90b68cfdeaeefe640ca247e46662fe779
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Jun 04 18:52:26 2018

Linux package: Handle 'openSUSE' when determining RPM package manager

BUG= 849123 
R=thestig

Change-Id: I9114cccf3cb3915c6004d4147da6be75f02260f2
Reviewed-on: https://chromium-review.googlesource.com/1085553
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564168}
[modify] https://crrev.com/a0d6a9c90b68cfdeaeefe640ca247e46662fe779/chrome/installer/linux/common/rpm.include

Labels: Merge-Request-67 Merge-Request-66
Requesting merge to M67 and M66.  This regression means that new installs on openSUSE won't get updates, so we should get this merged/pushed ASAP.  The change is very small and safe.
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 4 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Merge-Request-68
Also requesting merge to M68.

Other points
* This change is Linux-specific and should not affect other OSes.
* Linux doesn't have a Canary channel so we shouldn't wait for canary coverage.
Labels: -Merge-Request-66 -Merge-Request-68 Merge-Rejected-66 Merge-Approved-68
approved for 68. branch:3440
Labels: -Merge-Review-67 Merge-Approved-67
Approving merge to M67 branch 3396 based on comment #5 and #7. Pls merge ASAP. Thank you.
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 4 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e57310ca7bbab98edf7a405a1f6fb4bd725c4265

commit e57310ca7bbab98edf7a405a1f6fb4bd725c4265
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Jun 04 19:52:48 2018

[Merge to M67] Linux package: Handle 'openSUSE' when determining RPM package manager

> BUG= 849123 
> R=thestig
>
> Change-Id: I9114cccf3cb3915c6004d4147da6be75f02260f2
> Reviewed-on: https://chromium-review.googlesource.com/1085553
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564168}

BUG= 849123 
TBR=thestig
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I198db9f5c87cef2ba4baf6d300f7252d41575f4e
Reviewed-on: https://chromium-review.googlesource.com/1085988
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#739}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/e57310ca7bbab98edf7a405a1f6fb4bd725c4265/chrome/installer/linux/common/rpm.include

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 4 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4e3a06987e0c5025c273d5fcef1bcce811c24f1

commit b4e3a06987e0c5025c273d5fcef1bcce811c24f1
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Jun 04 19:56:05 2018

[Merge to M68] Linux package: Handle 'openSUSE' when determining RPM package manager

> BUG= 849123 
> R=thestig
>
> Change-Id: I9114cccf3cb3915c6004d4147da6be75f02260f2
> Reviewed-on: https://chromium-review.googlesource.com/1085553
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564168}

BUG= 849123 
TBR=thestig
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: Ibd1b3022757d2559b63f35250fd006f4ddf3daad
Reviewed-on: https://chromium-review.googlesource.com/1085993
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#160}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/b4e3a06987e0c5025c273d5fcef1bcce811c24f1/chrome/installer/linux/common/rpm.include

@thomasanderson - Thank you for making the fix. I think it may also fix openSUSE Tumbleweed (Issue 751996). Although I had never used Tumbleweed before, I installed openSUSE Tumbleweed 20180530 and Chrome 68.0.3440.15 from the dev channel in a VirtualBox VM; the Chrome installer added the google-chrome repository.
Status: Verified (was: Started)
Tested with 67.0.3396.79 on openSUSE Leap 42.3.  The google-chrome repo is now added, so marking this issue as verified.
Oops. In comment 12, the issue number is wrong. It should be  Issue 751966  .

Sign in to add a comment