New issue
Advanced search Search tips

Issue 849110 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

CHECK failure: *base_computed_style_ == *computed_style in element_animations.cc

Project Member Reported by ClusterFuzz, Jun 3 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5164112888463360

Fuzzer: attekett_dom_fuzzer
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  *base_computed_style_ == *computed_style in element_animations.cc
  blink::ElementAnimations::UpdateBaseComputedStyle
  blink::UpdateBaseComputedStyle
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=529050:529051

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5164112888463360

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 3 2018

Components: Blink>Animation Blink>CSS
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 3 2018

Labels: Test-Predator-Auto-Owner
Owner: lukasza@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/ffb5de3934abd4e16399b2f79e7100823c6076fd (Don't propagate cmdline flags that are not read by renderer processes.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Owner: futhark@chromium.org
Suspected regression changelist looks bogus. The problem is comparing cursor lists are based on pointers and does not compare values, which makes operator== false.

Seems to be an old issue.

Labels: -Pri-1 Pri-2
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a3093d75819bd39178ba7a280add9b49840513b

commit 3a3093d75819bd39178ba7a280add9b49840513b
Author: Rune Lillesveen <futhark@chromium.org>
Date: Thu Jun 07 13:13:41 2018

Use data equivalency comparing cursor images.

We only compared pointers which may be different across style recalcs.
That triggered a failed base-computed-style equivalence DCHECK.

Bug:  849110 
Change-Id: Ia90521cd7012114e937a3b72c8390a5e11ba187e
Reviewed-on: https://chromium-review.googlesource.com/1090718
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565246}
[modify] https://crrev.com/3a3093d75819bd39178ba7a280add9b49840513b/third_party/blink/renderer/core/style/computed_style.h
[modify] https://crrev.com/3a3093d75819bd39178ba7a280add9b49840513b/third_party/blink/renderer/core/style/computed_style_test.cc
[modify] https://crrev.com/3a3093d75819bd39178ba7a280add9b49840513b/third_party/blink/renderer/core/style/cursor_data.h

Status: Fixed (was: Assigned)
Project Member

Comment 7 by ClusterFuzz, Jun 14 2018

Labels: Needs-Feedback
ClusterFuzz testcase 5164112888463360 is still reproducing on tip-of-tree build (trunk).

Please re-test your fix against this testcase and if the fix was incorrect or incomplete, please re-open the bug. Otherwise, ignore this notification and add ClusterFuzz-Wrong label.
Project Member

Comment 8 by ClusterFuzz, Jun 16 2018

ClusterFuzz has detected this issue as fixed in range 567613:567614.

Detailed report: https://clusterfuzz.com/testcase?key=5164112888463360

Fuzzer: attekett_dom_fuzzer
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  *base_computed_style_ == *computed_style in element_animations.cc
  blink::ElementAnimations::UpdateBaseComputedStyle
  blink::UpdateBaseComputedStyle
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=529050:529051
Fixed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=567613:567614

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5164112888463360

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Jun 16 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5164112888463360 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment