SCContentSuggestionsTestCase fails under UIRefresh |
||
Issue descriptionSCContentSuggestionsTestCase fails when run with the UIRefresh flag enabled. Because showcase does not run chrome's startup code, the --enable-features flag has no effect. (This is why the tests are passing on the bot; they aren't actually testing with UIRefresh enabled.) In order to reproduce these failures locally, you will need to edit ios/chrome/browser/ui/ui_feature_flags.cc and set the flag to ENABLED_BY_DEFAULT.
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ac84583b7c6a4b79df8f05ccc54feda1b5c2084 commit 5ac84583b7c6a4b79df8f05ccc54feda1b5c2084 Author: Justin Cohen <justincohen@google.com> Date: Mon Jun 04 00:49:55 2018 [ios] Correct SCContentSuggestionsTestCase under UI Refresh. Remove references to reading list in showcase content suggestions. Bug: 849089 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I13832f021626cd3e063087666d72a64ceb628e88 Reviewed-on: https://chromium-review.googlesource.com/1084311 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#563981} [modify] https://crrev.com/5ac84583b7c6a4b79df8f05ccc54feda1b5c2084/ios/showcase/content_suggestions/BUILD.gn [modify] https://crrev.com/5ac84583b7c6a4b79df8f05ccc54feda1b5c2084/ios/showcase/content_suggestions/sc_content_suggestions_data_source.mm [modify] https://crrev.com/5ac84583b7c6a4b79df8f05ccc54feda1b5c2084/ios/showcase/content_suggestions/sc_content_suggestions_egtest.mm
,
Jun 4 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by rohitrao@chromium.org
, Jun 3 2018Owner: justincohen@chromium.org