New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849059 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
Proj-Servicification

Blocked on:
issue 859594



Sign in to add a comment

filesystem:chrome-extension:// URLs do not work with network service flag

Project Member Reported by pbomm...@chromium.org, Jun 3 2018

Issue description

Chrome Version: 69.0.3447.3
OS: Win10
Extension URL : https://chrome.google.com/webstore/detail/screencastify-screen-vide/mmeijimgabbpbgpdklnllpncmdofkcpn


What steps will reproduce the problem?
1. Install and launch Chrome Canary 
2. Enable "Enable network service" flag from "About://flags"
3. Relaunch Chrome
4. Visit Chrome webstore and install screencastify extension 
"https://chrome.google.com/webstore/detail/screencastify-screen-vide/mmeijimgabbpbgpdklnllpncmdofkcpn
5. Login using gmail(mandatory step) and give drive access.
6. Click on extension icon on tab strip and start record.
7. Once recording is done try to download recorded screencast.


What is the expected result?
Should be able to download recorded screen recording.

What happens instead?
Failed to download due to Network error.

Did this work with Enable network service flag disable?
Yes(That is how I am able to attach the screen recording of failure)

How frequent was the bug reproducible? 
100%

 
oop's forgot to attache the screenrecording.
Jun 2 2018 5_39 PM.webm
4.3 MB View Download

Comment 2 by jam@chromium.org, Jun 7 2018

Cc: xunji...@chromium.org
Helen: is this related to webrtc not working?
Owner: xunji...@chromium.org
Status: Assigned (was: Untriaged)
I am not sure how this extension works. I will assign it to myself to investigate.

Comment 4 by dxie@chromium.org, Jun 12 2018

helen, can you see if this is a canary blocker or not? If it is, please add the relevant label.
Owner: jam@chromium.org
Summary: filesystem:chrome-extension:// URLs do not work with network service flag (was: Downloading a captured video to disk from screencastify extension failed due to Network error.)
Looks like filesystem:chrome-extension://mmeijimgabbpbgpdklnllpncmdofkcpn/persistent/c2802784-f13e-464c-y5ee-2e0a9b5a502d.webm is incorrectly going through the network service. See netlog attached.

jam@: do you know who is working on porting Extensions FileSystem APIs?


chrome-net-export-log.json
150 KB View Download
Labels: -Pri-2 -Proj-Servicification Proj-Servicification-Canary Pri-1

Comment 7 by jam@chromium.org, Jun 26 2018

Owner: cmumford@chromium.org
Chris: can you take a look? Thanks
Status: Started (was: Assigned)
So far it looks like FileWriterDelegate::Start() is using the supplied |request| (net::URLRequest) to load a blob (blob://see_user_data/). This is failing in URLRequestJobManager::CreateJob() with ERR_UNKNOWN_URL_SCHEME. Looks like FileWriterDelegate needs to be modified to use the BlobURLLoaderFactory, or possibly use another delegate. My testing with tip-of-tree (master@{#570444}) didn't get as far as trying to save the recorded video to disk.
Blockedon: 859594
CL up at http://crrev.com/c/1127148. Should be sending out for review shortly.
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/092314fbfea259e1bf334380483b54864d73461f

commit 092314fbfea259e1bf334380483b54864d73461f
Author: Chris Mumford <cmumford@chromium.org>
Date: Tue Jul 24 00:09:20 2018

Fixed downloading from filesystem scheme with network service.

The download manager was using the NetworkDownloadURLLoaderFactoryGetter
for the filesystem scheme which uses a WrapperSharedURLLoaderFactory
for resource requests. This change adds a
FileSystemDownloadURLLoaderFactoryGetter for the filesystem scheme.

Bug:  849059 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia299ad88bac0ff0fa7ae79190e82c5e946d7b053
Reviewed-on: https://chromium-review.googlesource.com/1127148
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577357}
[modify] https://crrev.com/092314fbfea259e1bf334380483b54864d73461f/content/browser/BUILD.gn
[modify] https://crrev.com/092314fbfea259e1bf334380483b54864d73461f/content/browser/download/download_manager_impl.cc
[add] https://crrev.com/092314fbfea259e1bf334380483b54864d73461f/content/browser/download/file_system_download_url_loader_factory_getter.cc
[add] https://crrev.com/092314fbfea259e1bf334380483b54864d73461f/content/browser/download/file_system_download_url_loader_factory_getter.h
[modify] https://crrev.com/092314fbfea259e1bf334380483b54864d73461f/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Status: Fixed (was: Started)
Note: This is fixed, but until  issue 859594  is fixed the reproduction steps above in the bug description won't work.  issue 859594  prevents the screen recording from being written to the filesystem, and with no video in the filesystem there's nothing to download.
Labels: TE-Verified-70.0.3538.35
Verified the fix on latest Chrome Beta i.e., 70.0.3538.35 on Windows10 based on steps provided in bug report(comment#0). 

Please find the attached screencast for the same.

Note: Today's canary has some issue with the extension with and without network service flag. I will check further more and verify the bug on canary and update the bug accordingly.
Sep 28 2018 11_24 AM.webm
1.9 MB View Download

Sign in to add a comment