tabs.move fails to keep groups of tabs together when moving them on the same window
Reported by
eric.pro...@gmail.com,
Jun 2 2018
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36 Steps to reproduce the problem: 1. clone https://github.com/ericpromislow/movetabtester 2. make ; open the .../build/chrome directory to load the extension 3. use the attached a.html.erb file to create a page full of tabs. I use `for x in {a..z} ; do TITLE=$x erb -T 2 a.html.erb > $x.html; done` 4. Load files a.html .... i.html in a new window 5. bring up the movetabtester extension 6. select tabs f, g, h in the list box 7. select the window containing these one-letter tabs 8. select tab b as the destination 9. press "Naive All" -- this corresponds to running tabs.move([f, g, h]map(getTabId), { window: same, index: 1 } What is the expected behavior? Resulting list should be: [a f g h b c d e i j ...]] What went wrong? Resulting list is: [a f g b h c d ... ] If we try moving four tabs: [f g h i] to 1, we get the following: [a f g b h c d i e j k ...] It's like there's an off-by-one error that compounds as more tabs move. Did this work before? N/A Does this work in other browsers? Yes Chrome version: 66.0.3359.181 Channel: n/a OS Version: OS X 10.12.6 Flash Version: I stumbled into this problem while adding drag/drop support to my Tabhunter extension, and have spent a surprisingly high amount of time on a feature I expect hardly anyone to ever use, but so it goes. I disagree with the interpretation of moveProperties.index when you're moving tabs from the left to the right, but I guess that ship sailed long ago. The 4 buttons in my mini-extension correspond to using tabs.move as is, moving tabs one at a time to the target (to avoid older reversal problems), adjusting the index when moving all of them, and adjusting the index when moving one at a time. Please focus on the plain single call to tabs.move
,
Jun 13 2018
,
Jun 18 2018
Unable to test this issue on reported version as we are seeing error on using git clone https://github.com/ericpromislow/movetabtester.git xcrun: error: invalid active developer path (/Library/Developer/CommandLineTools), missing xcrun at: /Library/Developer/CommandLineTools/usr/bin/xcrun Hence downloaded .zip folder and extracted it. Tried Loading unpacked extension and observed error. Attaching screenshot for reference. @Reporter: Please let us know how to install that extension. Please upgrade chrome to latest stable and check the issue. Thanks!
,
Jun 18 2018
I have no problem running `git clone https://github.com/ericpromislow/movetabtester.git` with git version 2.14.2 on macos 10.12.6 Same with git version 1.9.1 on ubuntu. I observe the same error with the movetabtester extension on Version 67.0.3396.87 (Official Build) (64-bit) (macos) To install: 0. Upgrade git, or fix your path -- my guess is you have at least two gits installed, and there's a conflict in libraries. 0.5. cd WORKSPACE 1. git clone https://github.com/ericpromislow/movetabtester.git 2. cd movetabtester 3. make 4. In chrome, chrome://extensions/ -> LOAD UNPACKED -> Navigate to WORKSPACE/movetabtester/build 5. Select the 'chrome' directory 6. Click on the scope icon with the reddish smudge 7. See my initial report for the repro steps
,
Jun 18 2018
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 18 2018
And I just looked at the screenshot. You can't load the extension directly off git -- the manifest file needs to be created by running `make' From my initial report: """ Steps to reproduce the problem: 1. clone https://github.com/ericpromislow/movetabtester 2. make ; open the .../build/chrome directory to load the extension … """ I was a bit terse, but figured the 'make ;' would be understood. May I recommend doing what I do when following an unfamiliar procedure: [] copy the instructions *by hand* onto a piece of paper, with leading checkboxes, leaving space for notes under each instruction [] read the instructions over [] follow them, taking notes as you go
,
Sep 9
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by krajshree@chromium.org
, Jun 3 2018