[Harmony Cast Dialog] Implement UI to enable/disable Media Remoting |
|||
Issue descriptionThere needs to be a way for the user to disable Media Remoting. UX TBD.
,
Jun 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad2aed5ccb030fc2cd6caa8523fa3e19ffa2e668 commit ad2aed5ccb030fc2cd6caa8523fa3e19ffa2e668 Author: Takumi Fujimoto <takumif@chromium.org> Date: Sat Jun 23 00:37:14 2018 Add strings for cloud services and media remoting dialogs This CL adds strings used in the new dialogs. Dialog screenshots (margins aren't final): https://drive.google.com/open?id=1j5P7OyZognlhF6dXkb1cTAh1hXsSjQ9H https://drive.google.com/open?id=1MSonPoMLYt0lfLeq9NfP5yoH15EeVZ6c Bug: 848891 , 849020 Change-Id: Id48ed23018b3171d2dc7d6a9e492594487fcf7d5 Reviewed-on: https://chromium-review.googlesource.com/1112659 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#569859} [modify] https://crrev.com/ad2aed5ccb030fc2cd6caa8523fa3e19ffa2e668/chrome/app/media_router_strings.grdp
,
Jun 25 2018
Required to launch for accessibility reasons.
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df8431b405af6d8eeeada64a4a4eb1b9c2c57a01 commit df8431b405af6d8eeeada64a4a4eb1b9c2c57a01 Author: Takumi Fujimoto <takumif@chromium.org> Date: Wed Jun 27 17:14:14 2018 Add a dialog for enabling/not enabling Media Remoting This CL adds a dialog that will pop up when the Media Remoting feature is about to kick in, to ask the user whether the feature should be enabled. This CL just adds strings/layout, so the dialog is not functional yet, and the code path to open it is missing. Screenshot: https://drive.google.com/open?id=12CVIusU7nNR-uALCrRThnJMynZpPqU27 Bug: 849020 Change-Id: I3c85b62df495fc699e5b600a0dbb54808a198daf Reviewed-on: https://chromium-review.googlesource.com/1095571 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#570823} [modify] https://crrev.com/df8431b405af6d8eeeada64a4a4eb1b9c2c57a01/chrome/browser/ui/BUILD.gn [add] https://crrev.com/df8431b405af6d8eeeada64a4a4eb1b9c2c57a01/chrome/browser/ui/views/media_router/media_remoting_dialog_view.cc [add] https://crrev.com/df8431b405af6d8eeeada64a4a4eb1b9c2c57a01/chrome/browser/ui/views/media_router/media_remoting_dialog_view.h
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9869d38af10115371492e7ab89d709eae148a4c9 commit 9869d38af10115371492e7ab89d709eae148a4c9 Author: Xiangjun Zhang <xjz@chromium.org> Date: Fri Jun 29 19:10:30 2018 Media Remoting: Wait for permission check before starting. To support the new media remoting UI, for each cast session, permission is checked once at the first time render requests to start remoting. TBR=imcheng@chromium.org Bug: 849020 Change-Id: I0663190707e2fed9ae5cf2392a57c0b79475dd0c Reviewed-on: https://chromium-review.googlesource.com/1099267 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571578} [modify] https://crrev.com/9869d38af10115371492e7ab89d709eae148a4c9/chrome/browser/media/cast_remoting_connector.cc [modify] https://crrev.com/9869d38af10115371492e7ab89d709eae148a4c9/chrome/browser/media/cast_remoting_connector.h [modify] https://crrev.com/9869d38af10115371492e7ab89d709eae148a4c9/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe27c47cb189e2a948d520bf1608ec9ad4a7ffc0 commit fe27c47cb189e2a948d520bf1608ec9ad4a7ffc0 Author: Xiangjun Zhang <xjz@chromium.org> Date: Fri Jul 13 17:04:01 2018 Media remoting dialog: Check pref before showing dialog. This CL adds the implementation to check the preference of enabling/disabling media remoting. The remoting dialog is only shown when user has not set the preference. The preference can be set through the remoting dialog. Though this CL doesn't clear the preference once it is set. This will be done in a later CL. Bug: 849020 Change-Id: I89c4ed6b71a2e51bd81fae919531d15b53664b18 Reviewed-on: https://chromium-review.googlesource.com/1125355 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by: Derek Cheng <imcheng@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#574954} [modify] https://crrev.com/fe27c47cb189e2a948d520bf1608ec9ad4a7ffc0/chrome/browser/ui/views/media_router/media_remoting_dialog_view.cc [modify] https://crrev.com/fe27c47cb189e2a948d520bf1608ec9ad4a7ffc0/chrome/browser/ui/views/media_router/media_remoting_dialog_view.h
,
Jul 13
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12f5527bdb55a3033518a865cd0a99b664a0ea6a commit 12f5527bdb55a3033518a865cd0a99b664a0ea6a Author: Xiangjun Zhang <xjz@chromium.org> Date: Mon Jul 30 23:19:37 2018 Media Remoting: Get permission when requested to start. Get permission to start remoting when harmony cast dialog is enabled. Bug: 849020 Change-Id: I98e306c7ffaa6f53dc825a418f2c0b48ea7a9ee2 Reviewed-on: https://chromium-review.googlesource.com/1139173 Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579226} [modify] https://crrev.com/12f5527bdb55a3033518a865cd0a99b664a0ea6a/chrome/browser/media/DEPS [modify] https://crrev.com/12f5527bdb55a3033518a865cd0a99b664a0ea6a/chrome/browser/media/cast_remoting_connector.cc [modify] https://crrev.com/12f5527bdb55a3033518a865cd0a99b664a0ea6a/chrome/browser/media/cast_remoting_connector.h [modify] https://crrev.com/12f5527bdb55a3033518a865cd0a99b664a0ea6a/chrome/browser/media/cast_remoting_connector_unittest.cc [modify] https://crrev.com/12f5527bdb55a3033518a865cd0a99b664a0ea6a/media/blink/webmediaplayer_impl.cc
,
Jul 31
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b48088be1999a5d9f41860a01662433dfd3275b7 commit b48088be1999a5d9f41860a01662433dfd3275b7 Author: Nico Weber <thakis@chromium.org> Date: Wed Oct 03 01:00:19 2018 mac: Make media router permission dialog work. The mac implementation was hidden behind `defined(MAC_VIEWS_BROWSER)` instead of `BUILDFLAG(MAC_VIEWS_BROWSER)` and hence was never enabled. Since BUILDFLAG(MAC_VIEWS_BROWSER) is now always true, just remove the check. Bug: 849020 Change-Id: Ib4e9217304363d2d6e5ace4f1d44271ed6de1bfe Reviewed-on: https://chromium-review.googlesource.com/c/1258027 Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#596078} [modify] https://crrev.com/b48088be1999a5d9f41860a01662433dfd3275b7/chrome/browser/media/cast_remoting_connector.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by taku...@chromium.org
, Jun 11 2018