New issue
Advanced search Search tips

Issue 849009 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

SkRRect::isValid assert in coverting an oval

Project Member Reported by ClusterFuzz, Jun 2 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5248847258058752

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x05390000563d
Crash State:
  sk_abort_no_print
  SkRRect::setOval
  SkRRect::setOval
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=555638:555648

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5248847258058752

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 2 2018

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 2 2018

Cc: enne@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.

Comment 3 by enne@chromium.org, Jun 5 2018

Labels: -Pri-1 Pri-2
Owner: enne@chromium.org
Status: Assigned (was: Untriaged)
Summary: SkRRect::isValid assert in coverting an oval (was: Abrt in sk_abort_no_print)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfe2688d5c93662911b598191e504d90155303f1

commit cfe2688d5c93662911b598191e504d90155303f1
Author: Adrienne Walker <enne@chromium.org>
Date: Tue Jun 05 21:21:54 2018

Fix SkRRect::isValid fuzz assert

isFinite is not sufficient for an oval to be valid.  It needs to also
check isSorted, based on SkRRect::isValid's implementation.

Bug:  849009 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I968b086b6cc5ed2a253a0afc35008ce6c1ba818a
Reviewed-on: https://chromium-review.googlesource.com/1087543
Commit-Queue: enne <enne@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564666}
[modify] https://crrev.com/cfe2688d5c93662911b598191e504d90155303f1/cc/paint/paint_op_buffer.h

Project Member

Comment 5 by ClusterFuzz, Jun 6 2018

ClusterFuzz has detected this issue as fixed in range 564660:564675.

Detailed report: https://clusterfuzz.com/testcase?key=5248847258058752

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x05390000563d
Crash State:
  sk_abort_no_print
  SkRRect::setOval
  SkRRect::setOval
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=555638:555648
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=564660:564675

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5248847258058752

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Jun 6 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5248847258058752 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment