New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848991 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Optimize the loading benchmarks

Project Member Reported by sadrul@chromium.org, Jun 2 2018

Issue description

The loading benchmark currently runs with 'cold' and 'warm' cache-temperature settings [1]. The way this works:

 . For 'cold' setting: the browser is started, the page is loaded once, and the benchmark measures the metrics from that.
 . For 'warm' setting: the browser is started, the page is loaded once [2], then re-loaded, and the benchmark measures the metrics for the second load.

It should be possible to measure the metrics for 'cold' setting for the first load in the 'warm' setting. Therefore, I believe if the benchmarks that run in both 'cold' and 'warm' settings are updated to measure the results for 'cold' from the first load in 'warm', that would reduce the runtime for these benchmarks quite a lot (maybe as much as ~50%?).

sullivan@, nednguyen@ for thoughts.
kouhei@, ksakamoto@ as owners for loading benchmark.
tdresser, vmiura@ fyi

[1] https://cs.chromium.org/chromium/src/tools/perf/page_sets/loading_desktop.py?l=25
[2] https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/page/cache_temperature.py?l=66
 
Cc: maxlg@chromium.org dproy@chromium.org
Cc: pasko@chromium.org
Now that we allow TBMv2 metrics to use interaction records, I have no problem with implementing this optimization :-)

pasko: FYI

Comment 3 by sadrul@chromium.org, Jun 29 2018

Is this something that could be picked up for Q3? Reducing the test runtime would be quite helpful when running the tests locally (and presumably would also help with cycle-times in pinpoint etc.)

Comment 4 by maxlg@google.com, Jun 29 2018

+1 for sadrul@'s proposal, I had the same issue when I did the cold, warm, hot page load analysis. For my circumstance, the a page had to load 1+2+3=6 times if it was not optimized.
Cc: eyaich@chromium.org
If anyone wants to pick this up, I am happy to help with design & review

Comment 7 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 8 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Tests>Telemetry

Sign in to add a comment