New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848983 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
q4



Sign in to add a comment

"org.chromium.chrome.browser.ntp.NewTabPageTest#testRender_Simplified__EnableChromeModern" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 2 2018

Issue description

"org.chromium.chrome.browser.ntp.NewTabPageTest#testRender_Simplified__EnableChromeModern" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 11 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyYwsSBUZsYWtlIlhvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIubnRwLk5ld1RhYlBhZ2VUZXN0I3Rlc3RSZW5kZXJfU2ltcGxpZmllZF9fRW5hYmxlQ2hyb21lTW9kZXJuDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, Jun 4 2018

Detected 3 new flakes for test/step "org.chromium.chrome.browser.ntp.NewTabPageTest#testRender_Simplified__EnableChromeModern". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyYwsSBUZsYWtlIlhvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIubnRwLk5ld1RhYlBhZ2VUZXN0I3Rlc3RSZW5kZXJfU2ltcGxpZmllZF9fRW5hYmxlQ2hyb21lTW9kZXJuDA. This message was posted automatically by the chromium-try-flakes app.
Labels: -Sheriff-Chromium
Owner: lizeb@chromium.org
Status: Assigned (was: Untriaged)
Components: UI>Browser>NewTabPage
Labels: OS-Android
Owner: twelling...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b850f5e79ac3b970b95b291fffa4dc4399441865

commit b850f5e79ac3b970b95b291fffa4dc4399441865
Author: Benoît Lizé <lizeb@chromium.org>
Date: Mon Jun 04 13:37:18 2018

android: Disable a flaky test in NewTabPageTest.

NewTabPageTest#testRender_Simplified__EnableChromeModern is flaky

Bug: 848983
Change-Id: I1bf25d8fcddb26167656c03c2a2ba41848122e4b
Reviewed-on: https://chromium-review.googlesource.com/1084840
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564078}
[modify] https://crrev.com/b850f5e79ac3b970b95b291fffa4dc4399441865/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

Mergedinto: 813589
Status: Duplicate (was: Assigned)

Comment 6 by bau...@google.com, Jun 4 2018

Uh, are you sure this is the same underlying issue? The render test failures here (e.g. https://storage.cloud.google.com/chromium-result-details/html/chrome_public_test_apk_android-kitkat-arm-rel_3856_2018_06_04_T09_42_06-UTC) suggest that the NTP is scrolled, not an issue with highlighting.
Status: Assigned (was: Duplicate)
You're right... I just assumed that it was the same issue.

The first two failures look like the toolbar is missing. The third actually looks like the background on the sign-in promo changed in the third run that failed.

I suspect that the first two failures are not a new issue, but the sign-in promo rounded corners being slightly different may be new.
Labels: -Pri-1 Pri-2
Labels: zine-triaged
Labels: Q2 KR-Move-Bookmarks-Downloads O-NTP-Basic-Functionality
NextAction: 2018-06-19
Status: Started (was: Assigned)
The NextAction date has arrived: 2018-06-19
NextAction: ----
I tried resetting scroll state at the start of the test, but that had no effect. Pulling out of this sprint since work is stalled out for now.
Labels: -Q2 -O-NTP-Basic-Functionality Q3 small O-Jardin-M3
Labels: KR-M3-Implementation Q4
Labels: -KR-Move-Bookmarks-Downloads -Q3
Labels: -Pri-2 Pri-3

Sign in to add a comment