New issue
Advanced search Search tips

Issue 848980 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug


Participants' hotlists:
Session-Storage-S13N-Blockers


Sign in to add a comment

Chrome Canary is hanging when I open a new tab

Project Member Reported by csharrison@chromium.org, Jun 2 2018

Issue description

69.0.3447.3 (Official Build) canary (64-bit)

Symbolized trace attached. Looks potentially related to SessionStorage. One thread is working pretty hard on  SessionStorageContextMojo::OpenSessionStorage.
 
symbolized-trace.rtf
121 KB Download
The same symptoms on Windows 7 x64 with 69.0.3447.2 and 69.0.3447.3.
This is flaky, not each new tab makes browser hang. But when it hangs, no user interface is working for the page that was the source of the new tab (by a middle mouse button click on a link).
Labels: -Pri-3 OS-Windows Pri-1
Summary: Chrome Canary is hanging when I open a new tab (was: Chrome Canary on Mac is hanging when I open a new tab)
My experience matches vsemozhetbyt's, raising priority since this seems to be affecting more than just me (and more than one platform).

Comment 4 by roy...@gmail.com, Jun 4 2018

Same here. Win 10 17134.48, Chrome 69.0.3449.0 (Official Build) canary (64-bit)

Comment 5 by roy...@gmail.com, Jun 4 2018

Notifications are also not solid white bg anymore, they are semi transparent and sometimes the X doesn't show up. This build is unusable.
royale@, please file another issue for a bug in notifications if it is not related to this one. This helps keep the issue easier to follow and triage.

Aside: Not sure why I uploaded the initial trace as an rtf. Here it is as a plain text file.
symbolized-trace.txt
119 KB View Download

Comment 7 by mek@chromium.org, Jun 4 2018

Owner: dmu...@chromium.org
Status: Assigned (was: Untriaged)
Should be fixed now the flag-flip for the new session storage backend got reverted, but still something dmurph should look into before flipping the flag back on.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e08dfef2a3de2369a90cea01ff014d0170d19bab

commit e08dfef2a3de2369a90cea01ff014d0170d19bab
Author: Daniel Murphy <dmurph@chromium.org>
Date: Fri Jun 15 21:56:36 2018

[SessionStorageS13N] Fixed purging and cloning.

Purging will no longer infinitely loop when there are areas &
namespaces that are still bound, and cloning a session storage
namespace from browser commands will clone immediately and not wait
for a 'clone' from the renderer (which never comes).

Opening areas after purging also re-opens the correct storage area,
instead of opening a new storage area.

Bug: 848694,  848980 ,  849400 
Change-Id: I63790d26efe9fad871e9127ef129c772848e7e56
Reviewed-on: https://chromium-review.googlesource.com/1098154
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567805}
[modify] https://crrev.com/e08dfef2a3de2369a90cea01ff014d0170d19bab/content/browser/dom_storage/session_storage_context_mojo.cc
[modify] https://crrev.com/e08dfef2a3de2369a90cea01ff014d0170d19bab/content/browser/dom_storage/session_storage_context_mojo.h
[modify] https://crrev.com/e08dfef2a3de2369a90cea01ff014d0170d19bab/content/browser/dom_storage/session_storage_context_mojo_unittest.cc
[modify] https://crrev.com/e08dfef2a3de2369a90cea01ff014d0170d19bab/content/browser/dom_storage/session_storage_metadata.cc
[modify] https://crrev.com/e08dfef2a3de2369a90cea01ff014d0170d19bab/content/browser/dom_storage/session_storage_namespace_impl.cc
[modify] https://crrev.com/e08dfef2a3de2369a90cea01ff014d0170d19bab/content/browser/dom_storage/session_storage_namespace_impl.h
[modify] https://crrev.com/e08dfef2a3de2369a90cea01ff014d0170d19bab/content/browser/dom_storage/session_storage_namespace_impl_mojo.cc
[modify] https://crrev.com/e08dfef2a3de2369a90cea01ff014d0170d19bab/content/browser/dom_storage/session_storage_namespace_impl_mojo.h
[modify] https://crrev.com/e08dfef2a3de2369a90cea01ff014d0170d19bab/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/e08dfef2a3de2369a90cea01ff014d0170d19bab/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Status: Fixed (was: Assigned)

Sign in to add a comment