The Chromoting app should report (via telemetry logging) the number of network interfaces as enumerated during ICE candidate gathering. This should help us understand the potential impact of bug 841976 .
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92274031bdcff9558762840d180a4245ddbde688 commit 92274031bdcff9558762840d180a4245ddbde688 Author: Lambros Lambrou <lambroslambrou@chromium.org> Date: Sat Jun 02 04:10:31 2018 [remoting] Send network interface count. This updates the NaCl plugin and the Chrome app to report the number of network interfaces on the client machine, as enumerated by the NetworkManager during ICE candidate gathering. Bug: 848972 Change-Id: I6488f270916e4e92ef47f25c318af629cd9c2dd7 Reviewed-on: https://chromium-review.googlesource.com/1083938 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#563926} [modify] https://crrev.com/92274031bdcff9558762840d180a4245ddbde688/remoting/client/plugin/chromoting_instance.cc [modify] https://crrev.com/92274031bdcff9558762840d180a4245ddbde688/remoting/client/plugin/chromoting_instance.h [modify] https://crrev.com/92274031bdcff9558762840d180a4245ddbde688/remoting/client/plugin/pepper_network_manager.cc [modify] https://crrev.com/92274031bdcff9558762840d180a4245ddbde688/remoting/client/plugin/pepper_network_manager.h [modify] https://crrev.com/92274031bdcff9558762840d180a4245ddbde688/remoting/client/plugin/pepper_port_allocator_factory.cc [modify] https://crrev.com/92274031bdcff9558762840d180a4245ddbde688/remoting/client/plugin/pepper_port_allocator_factory.h [modify] https://crrev.com/92274031bdcff9558762840d180a4245ddbde688/remoting/protocol/transport_context.h [modify] https://crrev.com/92274031bdcff9558762840d180a4245ddbde688/remoting/webapp/base/js/chromoting_event.js [modify] https://crrev.com/92274031bdcff9558762840d180a4245ddbde688/remoting/webapp/base/js/client_plugin_impl.js [modify] https://crrev.com/92274031bdcff9558762840d180a4245ddbde688/remoting/webapp/base/js/session_logger.js
Requesting merge to M68. This change only affects the Chrome Remote Desktop app, not Chrome browser.
Approved.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e7acd68c27d010993c09f2bb0fce607b7492a64 commit 1e7acd68c27d010993c09f2bb0fce607b7492a64 Author: Lambros Lambrou <lambroslambrou@chromium.org> Date: Mon Jun 04 19:38:03 2018 [remoting] Send network interface count. This updates the NaCl plugin and the Chrome app to report the number of network interfaces on the client machine, as enumerated by the NetworkManager during ICE candidate gathering. Bug: 848972 Change-Id: I6488f270916e4e92ef47f25c318af629cd9c2dd7 Reviewed-on: https://chromium-review.googlesource.com/1083938 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563926}(cherry picked from commit 92274031bdcff9558762840d180a4245ddbde688) Reviewed-on: https://chromium-review.googlesource.com/1085927 Cr-Commit-Position: refs/branch-heads/3440@{#156} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/1e7acd68c27d010993c09f2bb0fce607b7492a64/remoting/client/plugin/chromoting_instance.cc [modify] https://crrev.com/1e7acd68c27d010993c09f2bb0fce607b7492a64/remoting/client/plugin/chromoting_instance.h [modify] https://crrev.com/1e7acd68c27d010993c09f2bb0fce607b7492a64/remoting/client/plugin/pepper_network_manager.cc [modify] https://crrev.com/1e7acd68c27d010993c09f2bb0fce607b7492a64/remoting/client/plugin/pepper_network_manager.h [modify] https://crrev.com/1e7acd68c27d010993c09f2bb0fce607b7492a64/remoting/client/plugin/pepper_port_allocator_factory.cc [modify] https://crrev.com/1e7acd68c27d010993c09f2bb0fce607b7492a64/remoting/client/plugin/pepper_port_allocator_factory.h [modify] https://crrev.com/1e7acd68c27d010993c09f2bb0fce607b7492a64/remoting/protocol/transport_context.h [modify] https://crrev.com/1e7acd68c27d010993c09f2bb0fce607b7492a64/remoting/webapp/base/js/chromoting_event.js [modify] https://crrev.com/1e7acd68c27d010993c09f2bb0fce607b7492a64/remoting/webapp/base/js/client_plugin_impl.js [modify] https://crrev.com/1e7acd68c27d010993c09f2bb0fce607b7492a64/remoting/webapp/base/js/session_logger.js
Comment 1 by bugdroid1@chromium.org
, Jun 2 2018