New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848957 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

WebUI: Change md-select and cr-input background color to google-gray-100

Project Member Reported by dpa...@chromium.org, Jun 1 2018

Issue description

Cc: -rbpotter@chromium.org
Owner: rbpotter@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4f00065e6bc0776bc065da66717d5f2a0524ecf

commit c4f00065e6bc0776bc065da66717d5f2a0524ecf
Author: rbpotter <rbpotter@chromium.org>
Date: Mon Jun 04 22:58:07 2018

WebUI MD Refresh: Update md-select and cr-input backgrounds

Bug:  848957 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I48eebbe4a4cf25771d64fa5ee74d8ee3af0de90a
Reviewed-on: https://chromium-review.googlesource.com/1083941
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564282}
[modify] https://crrev.com/c4f00065e6bc0776bc065da66717d5f2a0524ecf/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/c4f00065e6bc0776bc065da66717d5f2a0524ecf/ui/webui/resources/cr_elements/shared_vars_css.html
[modify] https://crrev.com/c4f00065e6bc0776bc065da66717d5f2a0524ecf/ui/webui/resources/html/md_select_css.html

Is this fixed?
Cc: sindhu.chelamcherla@chromium.org
Labels: TE-Verified-M69 TE-Verified-69.0.3451.0
Able to reproduce this issue on build without fix(checked on 69.0.3448.0), hence verifying the fix on latest canary 69.0.3450.0.

Now observing --google-grey-refresh-100 instead of google-gray-200 in select menu and input fields in chrome://settings.

As fix is working as expected adding Verified labels.

Thanks!
cr_input.png
50.2 KB View Download
md_select.png
57.4 KB View Download
Status: Fixed (was: Started)

Sign in to add a comment