New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848956 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Finalize conversion to DeviceSync Mojo API

Project Member Reported by hansberry@chromium.org, Jun 1 2018

Issue description

Classes such as TetherHostFetcher accept both a CryptAuthService and DeviceSyncClient, as the feature is migrated to the DeviceSync Mojo API. Once the feature has been fully migrated to DeviceSync Mojo API, rip out direct CryptAuthService in clients.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e30241b2090ac9d36fadf0c31ce53eede27e4303

commit e30241b2090ac9d36fadf0c31ce53eede27e4303
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Thu Jun 14 18:29:57 2018

[CrOS Multidevice] Migrate ProximityAuthWebUIHandler to conditionally use DeviceSyncClient.

ProximityAuthWebUiHandler now uses either ProximityAuthClient or DeviceSyncClient
to get remote device info or perform Cryptauth calls, depending on whether the
chromeos::features::kMultiDeviceApi is enabled. Once the migration to DeviceSyncClient
has been completed across all of Smart Lock, code that references ProximityAuthClient will
be removed.

This is one of many future CLs which are migrating Smart Lock to use
DeviceSync Mojo API instead of directly using the CryptAuth API.

I have manually verified the correctness of this change by verifying the
output on chrome://proximity-auth.

Bug: 824568,  752273 ,  848956 
Change-Id: Ia6bf1666f631a79c2873df3745232b8a8152bc8e
Reviewed-on: https://chromium-review.googlesource.com/1099050
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567354}
[modify] https://crrev.com/e30241b2090ac9d36fadf0c31ce53eede27e4303/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/e30241b2090ac9d36fadf0c31ce53eede27e4303/chromeos/components/proximity_auth/webui/BUILD.gn
[modify] https://crrev.com/e30241b2090ac9d36fadf0c31ce53eede27e4303/chromeos/components/proximity_auth/webui/proximity_auth_ui.cc
[modify] https://crrev.com/e30241b2090ac9d36fadf0c31ce53eede27e4303/chromeos/components/proximity_auth/webui/proximity_auth_ui.h
[modify] https://crrev.com/e30241b2090ac9d36fadf0c31ce53eede27e4303/chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
[modify] https://crrev.com/e30241b2090ac9d36fadf0c31ce53eede27e4303/chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d687ea9e30cde1863a51645a974841010a95c9a1

commit d687ea9e30cde1863a51645a974841010a95c9a1
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Fri Jun 15 04:29:17 2018

[CrOS Multidevice] ChromeProximityAuthClient: conditionally use DeviceSyncClient.

ChromeProximityAuthClient now uses either CryptAuthService or DeviceSyncClient
to get remote device info or perform Cryptauth calls, depending on whether the
chromeos::features::kMultiDeviceApi is enabled. Once the migration to DeviceSyncClient
has been completed across all of Smart Lock, code that references CryptAuthService will
be removed.

This is one of many future CLs which are migrating Smart Lock to use
DeviceSync Mojo API instead of directly using the CryptAuth API.

TBR=jhawkins@chromium.org

Bug: 824568,  752273 ,  848956 
Change-Id: If78959aa2a0ef6dc9433bca29649ab2d837114a1
Reviewed-on: https://chromium-review.googlesource.com/1102161
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567546}
[modify] https://crrev.com/d687ea9e30cde1863a51645a974841010a95c9a1/chrome/browser/chromeos/login/easy_unlock/chrome_proximity_auth_client.cc
[modify] https://crrev.com/d687ea9e30cde1863a51645a974841010a95c9a1/chrome/browser/chromeos/login/easy_unlock/chrome_proximity_auth_client.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/256fbf85047c58767640b6477d8ec826fb2d5ae1

commit 256fbf85047c58767640b6477d8ec826fb2d5ae1
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Fri Jun 15 19:48:14 2018

[CrOS Multidevice] Make EasyUnlockServiceRegular conditionally use DeviceSyncClient.

EasyUnlockServiceRegular now uses either CryptAuthService or DeviceSyncClient
to get remote device info or perform Cryptauth calls, depending on whether the
chromeos::features::kMultiDeviceApi is enabled. Once the migration to DeviceSyncClient
has been completed across all of Smart Lock, code that references CryptAuthService will
be removed.

This is the last of other similar CLs which are migrating Smart Lock to use
DeviceSync Mojo API instead of directly using the CryptAuth API.

This CL also injects DeviceSyncClient into EasyUnlockServiceRegular, making Smart Lock
rely entirely on DeviceSyncClient if chromeos::features::kMultiDeviceApi is enabled.
I have manually verified that it works correctly by testing the following:

1. Setting up Smart Lock.
2. Using Smart Lock in the regular lock-screen manner.
3. Using Smart Lock in the login-screen manner.
4. Ensuring that notifications display at the correct time.
5. Turning off Smart Lock.
6. Ensuring that permits are correctly saved to prefs (the new model can't
   use the old way of grabbing the user's AccountId).

TBR=jhawkins@chromium.org

Bug: 824568,  752273 ,  848956 
Change-Id: I3acc6dec46ff1ddc2875fbfe97261bb195a9494b
Reviewed-on: https://chromium-review.googlesource.com/1102164
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567769}
[modify] https://crrev.com/256fbf85047c58767640b6477d8ec826fb2d5ae1/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
[modify] https://crrev.com/256fbf85047c58767640b6477d8ec826fb2d5ae1/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_factory.cc
[modify] https://crrev.com/256fbf85047c58767640b6477d8ec826fb2d5ae1/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/256fbf85047c58767640b6477d8ec826fb2d5ae1/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h
[modify] https://crrev.com/256fbf85047c58767640b6477d8ec826fb2d5ae1/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_unittest_chromeos.cc

Status: Fixed (was: Assigned)

Sign in to add a comment