New issue
Advanced search Search tips

Issue 848955 link

Starred by 1 user
Status: Started
Owner:
jsaul@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

[Upstream] Request cardholder name in the credit card upload save bubble under certain conditions

Project Member Reported by jsaul@google.com, Jun 1 2018 
For Milestone 4 of the Partial Data Project, Chrome should explicitly request that the user confirms their cardholder name (prepopulated with the name from their Google Account) when name is missing and the user does not have a Google Payments account.

This is actually going to be very similar to the CVC fix flow...

Desktop-only for the moment with Android/iOS plans to come.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc672a07dde1969b28a79f92262a873c3f54eaed

commit bc672a07dde1969b28a79f92262a873c3f54eaed
Author: Jared Saul <jsaul@google.com>
Date: Sat Jun 16 05:22:12 2018

[Autofill] Request cardholder name in the credit card upload save bubble under certain conditions

For Milestone 4 of the Partial Data Project, Chrome should explicitly request that the user confirms their cardholder name (prepopulated with the name from their Google Account) when name is missing and the user does not have a Google Payments account.

This CL is actually going to be extremely similar to the original CVC fix flow, which was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1034103.  Feel free to cross-reference these CLs, as most everything I took out in that CL is simply getting put back in this one, except this time it's name instead of CVC.  Surprise!

Bug: 848955
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I08e94c1a16b7b1da403ea5a8f26d1e2d423c210e
Reviewed-on: https://chromium-review.googlesource.com/1083880
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567876}
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/android_webview/browser/aw_autofill_client.cc
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/android_webview/browser/aw_autofill_client.h
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/chrome/browser/about_flags.cc
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/chrome/browser/ui/autofill/save_card_bubble_controller_impl_browsertest.cc
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_unittest.mm
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/chrome/browser/ui/views/autofill/dialog_view_ids.h
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/chrome/browser/ui/views/autofill/save_card_bubble_views.h
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/components/autofill/core/browser/test_autofill_client.h
[add] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/components/autofill/core/browser/ui/DEPS
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/components/autofill/core/browser/ui/save_card_bubble_controller.h
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/components/autofill_strings.grdp
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/ios/web_view/internal/autofill/web_view_autofill_client_ios.h
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
[modify] https://crrev.com/bc672a07dde1969b28a79f92262a873c3f54eaed/tools/metrics/histograms/enums.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94e03c605a6e73da5dd2d8907483f4b12bdc02f8

commit 94e03c605a6e73da5dd2d8907483f4b12bdc02f8
Author: Jared Saul <jsaul@google.com>
Date: Fri Jul 06 19:57:55 2018

[Chrome Upstream] Add .RequestingCardholderName subhistogram for Partial Data M4 scenarios

Bug: 848955
Change-Id: I441a9eafab2a6f1cd6d8bbd5990de3a596ca65ed
Reviewed-on: https://chromium-review.googlesource.com/1121549
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#573049}
[modify] https://crrev.com/94e03c605a6e73da5dd2d8907483f4b12bdc02f8/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/94e03c605a6e73da5dd2d8907483f4b12bdc02f8/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[modify] https://crrev.com/94e03c605a6e73da5dd2d8907483f4b12bdc02f8/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/94e03c605a6e73da5dd2d8907483f4b12bdc02f8/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/94e03c605a6e73da5dd2d8907483f4b12bdc02f8/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/94e03c605a6e73da5dd2d8907483f4b12bdc02f8/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/94e03c605a6e73da5dd2d8907483f4b12bdc02f8/tools/metrics/histograms/histograms.xml
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fe9a6f70cce578b4af4d51a5dcf3b628419239c

commit 1fe9a6f70cce578b4af4d51a5dcf3b628419239c
Author: Jared Saul <jsaul@google.com>
Date: Fri Jul 06 21:10:52 2018

[Autofill] Fix cardholder name prefilling bug and log accompanying metric

Context: A late change in Patch Set 14 of
https://chromium-review.googlesource.com/c/chromium/src/+/1083880
accidentally inverted the logic, causing cardholder name to NOT be
prefilled in the card upload textfield as desired.  (There was no impact
as this feature is not yet available.)  This change fixes the inverted
logic, finishes up the browsertest that would have caught the error,
and creates a metric for whether the prefilling was successful (both of
the last two were on my roadmap anyway!)

Bug: 848955
Change-Id: I5db1fbf7ad85962eec2af34f3c6c66ba11110a85
Reviewed-on: https://chromium-review.googlesource.com/1123776
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#573071}
[modify] https://crrev.com/1fe9a6f70cce578b4af4d51a5dcf3b628419239c/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/1fe9a6f70cce578b4af4d51a5dcf3b628419239c/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/1fe9a6f70cce578b4af4d51a5dcf3b628419239c/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/1fe9a6f70cce578b4af4d51a5dcf3b628419239c/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/1fe9a6f70cce578b4af4d51a5dcf3b628419239c/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
[modify] https://crrev.com/1fe9a6f70cce578b4af4d51a5dcf3b628419239c/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/1fe9a6f70cce578b4af4d51a5dcf3b628419239c/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/1fe9a6f70cce578b4af4d51a5dcf3b628419239c/tools/metrics/histograms/histograms.xml
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb6d23328c138b25add5f805bbcef29cb836dc5a

commit bb6d23328c138b25add5f805bbcef29cb836dc5a
Author: Jared Saul <jsaul@google.com>
Date: Tue Jul 10 01:25:38 2018

[Autofill] Update cardholder name fix flow UI

This change moves from using grey watermark text in the textfield to
having an explicit label above the textfield along with a hoverable
tooltip.  Tooltip text is subject to change pending final UX strings.

Example screenshots:
https://screenshot.googleplex.com/gY5QKjd58Ow.png
https://screenshot.googleplex.com/rQT522vErCX.png

Bug: 848955
Change-Id: Id9503a9c5955ecec297061e0c5117db1bbe7c0e1
Reviewed-on: https://chromium-review.googlesource.com/1130111
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#573586}
[modify] https://crrev.com/bb6d23328c138b25add5f805bbcef29cb836dc5a/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/bb6d23328c138b25add5f805bbcef29cb836dc5a/components/autofill_strings.grdp

Comment 5 by ftirelo@chromium.org, Jul 11 

Please add a new test to SaveCardBubbleControllerImplTest to show the new control on a browser test. It makes life much simpler when you want to do UI changes on the dialog.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8c204be7c30bf7592501657cb0aab09a5fd1a0c

commit f8c204be7c30bf7592501657cb0aab09a5fd1a0c
Author: Jared Saul <jsaul@google.com>
Date: Tue Jul 17 18:39:16 2018

[Chrome Autofill] Reset |should_request_name_from_user_| on consecutive save offers

Bug: 848955
Change-Id: I685ff122d8ab0a8b8a529e7d381442e7ac5d9838
Reviewed-on: https://chromium-review.googlesource.com/1140679
Commit-Queue: Jared Saul <jsaul@google.com>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575734}
[modify] https://crrev.com/f8c204be7c30bf7592501657cb0aab09a5fd1a0c/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/f8c204be7c30bf7592501657cb0aab09a5fd1a0c/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/f8c204be7c30bf7592501657cb0aab09a5fd1a0c/components/autofill/core/browser/credit_card_save_manager_unittest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e51c496fbde22e09f84df1b6818d3e4a4aa95720

commit e51c496fbde22e09f84df1b6818d3e4a4aa95720
Author: Jared Saul <jsaul@google.com>
Date: Thu Jul 19 01:48:03 2018

[Chrome Autofill] Update cardholder name fix flow UI

Changes made by request of UX team.

Bug: 848955
Change-Id: I4b5486a97cf3482f98a26657ac2644b9bc2c1bd4
Reviewed-on: https://chromium-review.googlesource.com/1142200
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#576313}
[modify] https://crrev.com/e51c496fbde22e09f84df1b6818d3e4a4aa95720/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/e51c496fbde22e09f84df1b6818d3e4a4aa95720/ui/views/bubble/tooltip_icon.cc
[modify] https://crrev.com/e51c496fbde22e09f84df1b6818d3e4a4aa95720/ui/views/bubble/tooltip_icon.h

Comment 12 by jsaul@google.com, Jul 19 

ftirelo@: Regarding comment #5, I thought I did that here:
https://chromium-review.googlesource.com/c/chromium/src/+/1083880/16/chrome/browser/ui/autofill/save_card_bubble_controller_impl_browsertest.cc
Or are you referring to something else?
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbddee4feb5b8e16b3fc8259456655d61beeb474

commit cbddee4feb5b8e16b3fc8259456655d61beeb474
Author: Jared Saul <jsaul@google.com>
Date: Fri Aug 17 23:28:48 2018

Update fieldtrial_testing_config.json for AutofillUpstreamEditableCardholderName

Bug: 848955
Change-Id: I4dbd64bd97a8483434fc247ca428dd4bacb4846d
Reviewed-on: https://chromium-review.googlesource.com/1176428
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#584234}
[modify] https://crrev.com/cbddee4feb5b8e16b3fc8259456655d61beeb474/testing/variations/fieldtrial_testing_config.json
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c

commit 4e5b2c2c758ced0ab5de2f67dc909dc16950e33c
Author: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Date: Thu Nov 08 18:25:52 2018

Editable UI to use in chrome Autofill

CL splitting Plan

1) Current CL - End to end flow and functional demo. Fix flow UI is quite basic and need to make small changes and I will chat with you tomorrow on UX layout here. Today at save card, it is crashing in JNI code. Matthew, will swing by your desk tomorrow. It is again at some Context OOO or some thing. This time I want to learn how to debug that stuff.

This is major part of CL where I have to get ack from multiple reviewers. I tried to make flow as basic as possible.

2) Pretty up the UI and fix all UI nits to match production one - This is mostly mdjones@ review and UX Ok with spacing and etc.

3) Metrics, tests and preferences - Today there is not much testing on Android side. So need to see what I can add - This jsaul@ can review.

What to implement - https://docs.google.com/presentation/d/1hfCDQJle0SB5AX2vdhERC7JuduR9jvOTiszSy4BON2Q/edit#slide=id.g433d7fc08d_1_8
Demo - https://drive.google.com/file/d/0Bw9uo2EXAqJ_NmtQbGtVdlpHWF9PQ1Y2QVR1SGtuRjBQeFI4/view?usp=sharing

Bug: 848955
Change-Id: I080684d8a864cba760b5be6fef96b1aa52478eb8
Reviewed-on: https://chromium-review.googlesource.com/c/1180438
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Cr-Commit-Position: refs/heads/master@{#606544}
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/android_webview/browser/aw_autofill_client.cc
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/android_webview/browser/aw_autofill_client.h
[add] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/chrome/android/java/res/layout/autofill_name_fixflow.xml
[add] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillNameFixFlowBridge.java
[add] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillNameFixFlowPrompt.java
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/chrome/android/java_sources.gni
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/chrome/browser/BUILD.gn
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/chrome/browser/ui/android/autofill/card_name_fix_flow_view_android.cc
[add] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/chrome/browser/ui/android/autofill/card_name_fix_flow_view_android.h
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/components/autofill/core/browser/test_autofill_client.h
[add] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/components/autofill/core/browser/ui/card_name_fix_flow_view_delegate_mobile.cc
[add] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/components/autofill/core/browser/ui/card_name_fix_flow_view_delegate_mobile.h
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/components/autofill_strings.grdp
[modify] https://crrev.com/4e5b2c2c758ced0ab5de2f67dc909dc16950e33c/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03fad82c4925ada089675ad7e19d8a70e026d9e8

commit 03fad82c4925ada089675ad7e19d8a70e026d9e8
Author: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Date: Mon Nov 26 22:15:03 2018

Fix Name UI with recent changes

Latest UI - https://screenshot.googleplex.com/qqSuM2bvctM.png

UI + tool tip - https://screenshot.googleplex.com/RPZkrxgBdnN.png

Changes
1) Remove legal message from second screen as it is not needed
2) Add tool tip icon and adjust spacing for name.

UX is still working on final spaces to make it clean post Legal removal
message world. Would like to get this CL before M72 branch date,so dont need
to ask TPMs for merge. Small UI spacing fixes, can request TPMs.

Bug: 848955
Change-Id: Ia8a5cd4fe2c6751c1e169a58ac88123770838234
Reviewed-on: https://chromium-review.googlesource.com/c/1334509
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#610959}
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/android_webview/browser/aw_autofill_client.cc
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/android_webview/browser/aw_autofill_client.h
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/chrome/android/java/res/layout/autofill_name_fixflow.xml
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillNameFixFlowBridge.java
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillNameFixFlowPrompt.java
[add] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillUiUtils.java
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/chrome/android/java_sources.gni
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/chrome/browser/ui/android/autofill/card_name_fix_flow_view_android.cc
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/chrome/browser/ui/android/autofill/card_name_fix_flow_view_android.h
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/components/autofill/core/browser/ui/card_name_fix_flow_view_delegate_mobile.cc
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/components/autofill/core/browser/ui/card_name_fix_flow_view_delegate_mobile.h
[modify] https://crrev.com/03fad82c4925ada089675ad7e19d8a70e026d9e8/components/autofill_strings.grdp
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c09156f7539e0ec63ad9f1beeb48d8de815d92c3

commit c09156f7539e0ec63ad9f1beeb48d8de815d92c3
Author: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Date: Sat Dec 08 01:19:21 2018

UX changes as per UX review

1) Fix icon and spacings
2) Remove text field focus by default.
3) Disable "save" button on empty text boxes
UX spacings - https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZTBepuvIfB--/files/MCHtA7U1iMGr65CS6zbGFFJCmdLeVs-ufU0

Demo - https://screenshot.googleplex.com/Byqr4iXQ1zg.png

Demo with layout enabled - https://screenshot.googleplex.com/fFajpXgZ4RB.png

Bug: 848955
Change-Id: I72bf916610c9c576f693557ad05950ef08229cf5
Reviewed-on: https://chromium-review.googlesource.com/c/1359829
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614897}
[modify] https://crrev.com/c09156f7539e0ec63ad9f1beeb48d8de815d92c3/chrome/android/java/res/layout/autofill_name_fixflow.xml
[modify] https://crrev.com/c09156f7539e0ec63ad9f1beeb48d8de815d92c3/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillNameFixFlowPrompt.java
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/360be5f2c3ebec59e3c7e9528a8b093a5216b9a4

commit 360be5f2c3ebec59e3c7e9528a8b093a5216b9a4
Author: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Date: Mon Dec 10 23:04:19 2018

Autofill Android card name fix flow metrics

Android credit card name fix flow metrics

Bug: 848955
Change-Id: Ibc01b5685996d2564e99d54e0d6df47a0311026e
Reviewed-on: https://chromium-review.googlesource.com/c/1361707
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#615300}
[modify] https://crrev.com/360be5f2c3ebec59e3c7e9528a8b093a5216b9a4/chrome/browser/ui/android/autofill/card_name_fix_flow_view_android.cc
[modify] https://crrev.com/360be5f2c3ebec59e3c7e9528a8b093a5216b9a4/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/360be5f2c3ebec59e3c7e9528a8b093a5216b9a4/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/360be5f2c3ebec59e3c7e9528a8b093a5216b9a4/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/360be5f2c3ebec59e3c7e9528a8b093a5216b9a4/components/autofill/core/browser/ui/card_name_fix_flow_view_delegate_mobile.cc
[modify] https://crrev.com/360be5f2c3ebec59e3c7e9528a8b093a5216b9a4/components/autofill/core/browser/ui/card_name_fix_flow_view_delegate_mobile.h
[modify] https://crrev.com/360be5f2c3ebec59e3c7e9528a8b093a5216b9a4/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/360be5f2c3ebec59e3c7e9528a8b093a5216b9a4/tools/metrics/histograms/histograms.xml
Project Member

Comment 18 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b0eaa6a9cf65963a7c0ff622aaec88ed281c96a

commit 8b0eaa6a9cf65963a7c0ff622aaec88ed281c96a
Author: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Date: Tue Dec 11 22:22:33 2018

Fix logging bug where shown logs it as user interacted.

Had interacted is being logged just when prompt is shown.
Introduced shown boolean to denote that
and fixed logging for had_user_interacted.


Bug: 848955
Change-Id: Ib3d17ab567b88c7ebda2dbe08cb3e46cf0807924
Reviewed-on: https://chromium-review.googlesource.com/c/1372281
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#615688}
[modify] https://crrev.com/8b0eaa6a9cf65963a7c0ff622aaec88ed281c96a/components/autofill/core/browser/ui/card_name_fix_flow_view_delegate_mobile.cc
[modify] https://crrev.com/8b0eaa6a9cf65963a7c0ff622aaec88ed281c96a/components/autofill/core/browser/ui/card_name_fix_flow_view_delegate_mobile.h
Project Member

Comment 19 by bugdroid1@chromium.org, Dec 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a904568a51b65d9ac3e9b905dd7a2160220246a

commit 3a904568a51b65d9ac3e9b905dd7a2160220246a
Author: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Date: Sat Dec 29 00:13:29 2018

Replace Next with Continue as per UXR

Bug: 848955
Change-Id: I9e294cd0855a50d7e6ee0df417474c6bb2e3329c
Reviewed-on: https://chromium-review.googlesource.com/c/1391784
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619210}
[modify] https://crrev.com/3a904568a51b65d9ac3e9b905dd7a2160220246a/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/3a904568a51b65d9ac3e9b905dd7a2160220246a/components/autofill_strings.grdp
Project Member

Comment 20 by bugdroid1@chromium.org, Jan 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcff4822f19d72661086ee688884dd4dc219cdf4

commit bcff4822f19d72661086ee688884dd4dc219cdf4
Author: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Date: Wed Jan 02 20:04:10 2019

Small UX changes from UX review

1) Fix padding.
2) Fix editing in landscape mode


Screenshots - https://screenshot.googleplex.com/xFHjg8t9rxu.png
https://screenshot.googleplex.com/sS7NWffEpOf.png

Landscape mode screenshots -
https://screenshot.googleplex.com/xM2HVR5SXH6
https://screenshot.googleplex.com/zDeW1YOtQqB


Bug: 848955
Change-Id: I2b8d3f70291de088f29007377cae0c03e3c5f18d
Reviewed-on: https://chromium-review.googlesource.com/c/1391350
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Cr-Commit-Position: refs/heads/master@{#619472}
[modify] https://crrev.com/bcff4822f19d72661086ee688884dd4dc219cdf4/chrome/android/java/res/layout/autofill_name_fixflow.xml
►

Sign in to add a comment