New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848950 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
User never visited
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Choose Trybots is broken in Gerrit

Project Member Reported by tandrii@chromium.org, Jun 1 2018

Issue description

Please provide the details for your request here.

Set Pri-0 iff it requires immediate attention, Pri-1 if resolution within a few hours is acceptable, and Pri-2 if it just needs to be handled today.

 

Comment 1 by no...@chromium.org, Jun 1 2018

Status: Started (was: Assigned)
Labels: -Restrict-View-Google
PSAs sent to public and private mailing lists.
Labels: Foundation-Troopers

Comment 5 by s...@google.com, Jun 1 2018

Nodir says we need to just add *args, **kwargs to CorsHandler.options:
https://chromium.googlesource.com/infra/luci/luci-py/+/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/components/components/endpoints_webapp2/adapter.py#100

I tried this and it seems to allow try jobs to be scheduled again.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/e0a8a5640c4104e5c90781d833168aa8a8d1f24d

commit e0a8a5640c4104e5c90781d833168aa8a8d1f24d
Author: smut <smut@google.com>
Date: Fri Jun 01 23:42:56 2018

[webapp2 adapter] Fix method signature for CorsHandler.options

Bug:  848950 
Change-Id: Ibed95782ce70646276005ee959af0fa4c8aa191f
Reviewed-on: https://chromium-review.googlesource.com/1083840
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/e0a8a5640c4104e5c90781d833168aa8a8d1f24d/appengine/components/components/endpoints_webapp2/adapter.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2deea1aa314694a7f128582b5a6355c3b75ba7de

commit 2deea1aa314694a7f128582b5a6355c3b75ba7de
Author: smut <smut@google.com>
Date: Sat Jun 02 00:07:39 2018

Roll luci-py to e0a8a5640c4104e5c90781d833168aa8a8d1f24d

Changes:
e0a8a564 [webapp2 adapter] Fix method signature for CorsHandler.options
0355ec5c [Swarming] Update clients to hit /_ah/api instead of /api

Bug:  848950 
Change-Id: Ib14c5aac48b21144c1cc5d92dc535b8bb3dada52
Reviewed-on: https://chromium-review.googlesource.com/1083846
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/2deea1aa314694a7f128582b5a6355c3b75ba7de/DEPS

Comment 8 by s...@google.com, Jun 2 2018

Status: Fixed (was: Started)
Owner: smut@chromium.org

Sign in to add a comment