New issue
Advanced search Search tips

Issue 848948 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

WidgetInputMethodInteractiveTest.Activation crashes when allowed to run

Project Member Reported by ccameron@chromium.org, Jun 1 2018

Issue description

If a delay is added to WidgetInputMethodInteractiveTest.Activation, the test will crash with the following stack:
[FATAL:focus_ring.cc(85)] Check failed: IsPathUseable(path). 
    base::debug::StackTrace::StackTrace(...
    logging::LogMessage::~LogMessage(... 
    views::FocusRing::OnPaint(...
    views::View::Paint(...
    views::View::OnPaintLayer(...
    ui::Layer::PaintContentsToDisplayList(...
    non-virtual thunk to ui::Layer::PaintContentsToDisplayList(...
    cc::PictureLayer::Update(... 
    cc::LayerTreeHost::PaintContent(...
    cc::LayerTreeHost::DoUpdateLayers(...
    cc::LayerTreeHost::UpdateLayers(... 
    cc::SingleThreadProxy::BeginMainFrame(...

This crash was triggered by adding a delay to ensure smooth resizing, but it can be triggered independently of that change.

The following patch will trigger the crash:
diff --git a/ui/views/test/widget_test.cc b/ui/views/test/widget_test.cc
index 28977d94d80d..82e21d72a69e 100644
--- a/ui/views/test/widget_test.cc
+++ b/ui/views/test/widget_test.cc
@@ -177,8 +177,10 @@ void WidgetActivationWaiter::OnWidgetActivationChanged(Widget* widget,
 
   observed_ = true;
   widget->RemoveObserver(this);
+/*
   if (run_loop_.running())
     run_loop_.Quit();
+*/
 }
 
 WidgetClosingObserver::WidgetClosingObserver(Widget* widget) : widget_(widget) {
 
Labels: Target-70 MacViews-Cleanup Proj-MacViews M-70
Owner: ccameron@chromium.org
Status: Assigned (was: Untriaged)
mac triage: ccameron@, over to you :)
This is an broken-as-written test which we're just tripping over. Realistically I'm not going to look at this soon.
Labels: -M-70 Group-Tests
Labels: M-70
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIToolingRequired
***UI Mass Triage ***

Sign in to add a comment