New issue
Advanced search Search tips

Issue 848929 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Bidi adjustment should check paragraph/line direction instead of block direction

Project Member Reported by xiaoche...@chromium.org, Jun 1 2018

Issue description

Current bidi adjustment code assumes same line direction as block direction, which is wrong when we have 'unicode-bidi: plain-text' property.

We should change all bidi-related code to check line direction instead of block direction.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6baa395e3dec8e33e23eaf8d2e533f1276b3a7a

commit e6baa395e3dec8e33e23eaf8d2e533f1276b3a7a
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Mon Jun 04 22:16:43 2018

[LayoutNG] Check line direction instead of block direction in bidi adjustment

Existing bidi adjustment code compares block direction against text runs'
resolved directions, and perform different types of adjustments depending
on the comparison result.

This is incorrect, as block direction is not necessarily the same as the line's
base direction. This patch corrects it by checking line direction instead.

Note: this patch only fixes the LayoutNG implementation. Legacy remains unfixed
because the line direction is not stored anywhere, and is hard to compute.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Bug: 848929
Change-Id: I2e15237d73bea0374d2b9d466040a6e4dd55cdc3
Reviewed-on: https://chromium-review.googlesource.com/1083621
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564263}
[modify] https://crrev.com/e6baa395e3dec8e33e23eaf8d2e533f1276b3a7a/third_party/blink/renderer/core/editing/inline_box_traversal.cc
[modify] https://crrev.com/e6baa395e3dec8e33e23eaf8d2e533f1276b3a7a/third_party/blink/renderer/core/editing/inline_box_traversal.h

Sign in to add a comment