New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848925 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

Scheduler: Experiment with priorities for frame and task types.

Project Member Reported by farahcharab@chromium.org, Jun 1 2018

Issue description

Experiment with setting the priority (during loading) of the following to low: 

1- hidden frames 
2- sub-frames
3- timer tasks 
4- sub-frame timer tasks

Relevant material can be found in:

https://docs.google.com/document/d/1ct7kiPbpBsYJqeHJ07aWPzfC2I7kpcvdllPJ3hLfgYw/edit?usp=sharing 

 
Components: Blink>Scheduling
Status: Started (was: Fixed)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b4dbe720b3cb0ea70589568c513a33a67940169

commit 4b4dbe720b3cb0ea70589568c513a33a67940169
Author: Farah Charab <farahcharab@google.com>
Date: Mon Jun 04 17:22:56 2018

Scheduler: Experiment with priorities of frame and task types.

Set the priority of hidden frames to low during loading
when relevant feature is enabled.

Set the priority of sub-frames to low during loading when
relevant feature is enabled.

Set the priority of throttleable task queues to low during loading
when relevant feature is enabled.

Set the priority of subframe throttleable task queues to low during
loading when relevant feature is enabled.

Note that this experiment is supposed to run on Canary/Dev,
so waterfall test configs aren't added.

Bug: 848925
Change-Id: I54f3d8049faee10f1ced891033561f91d171b79c
Reviewed-on: https://chromium-review.googlesource.com/1083194
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564134}
[modify] https://crrev.com/4b4dbe720b3cb0ea70589568c513a33a67940169/third_party/blink/renderer/platform/scheduler/child/features.h
[modify] https://crrev.com/4b4dbe720b3cb0ea70589568c513a33a67940169/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/4b4dbe720b3cb0ea70589568c513a33a67940169/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/4b4dbe720b3cb0ea70589568c513a33a67940169/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/4b4dbe720b3cb0ea70589568c513a33a67940169/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h

Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
Status: Started (was: Assigned)
Cc: altimin@chromium.org
Labels: Pri-1

Sign in to add a comment