New issue
Advanced search Search tips

Issue 848920 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Terminal shows up as broken after login/logout

Project Member Reported by jkardatzke@chromium.org, Jun 1 2018

Issue description

Not sure how realistic this is to fix, but it always looks like something is broken when this happens. If you have an open Terminal window and then logout/login, then it will have that window open but show you D-Bus errors at the top of it. You know you've all seen it a hundred times. :)

I guess there's 3 options:

1. Sorry, leave it
2. Close the windows automatically
3. Cause a VM startup so the terminal window can actually connect

Curious what others think about this issue.
 
Let's close the windows. That seems like the easiest and most consistent, we don't want to auto start VMs.

If we could get a user action to start the VM, that would be OK.
Labels: Hotlist-Crostini-UI
Status: Available (was: Untriaged)
+1 to having the windows closed, that's common for other types of applications.
Cc: jkardatzke@chromium.org

Comment 4 by vapier@chromium.org, Jun 21 2018

Components: OS>Systems>Containers
Cc: -jkardatzke@chromium.org
Owner: jkardatzke@chromium.org
Status: Started (was: Available)
This one just consistently bugs me so I want to fix it. :)
Status: Assigned (was: Started)
Status: Started (was: Assigned)
Cc: rohi...@chromium.org
 Issue 888154  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb4a81e60777d76575731facf2655d8c00086b7b

commit fb4a81e60777d76575731facf2655d8c00086b7b
Author: Jeffrey Kardatzke <jkardatzke@google.com>
Date: Thu Oct 25 18:00:12 2018

Do not restore browser windows for Crostini terminals

The Crostini VM does not start up automatically upon user login, and if
the user had Crostini terminal windows open they will be restored in a
broken state. This prevents restoring any windows that are from Crostini
terminals.

BUG= chromium:848920 
TEST=Verified manually that terminal does not restore

Change-Id: Icec4986da80e039444cd92b151695d2d1751269e
Reviewed-on: https://chromium-review.googlesource.com/c/1287251
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602787}
[modify] https://crrev.com/fb4a81e60777d76575731facf2655d8c00086b7b/chrome/browser/sessions/session_service.cc
[modify] https://crrev.com/fb4a81e60777d76575731facf2655d8c00086b7b/chrome/browser/sessions/session_service_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment