Disable views login in 68 and put views login behind a feature/finch flag |
||||||
Issue descriptionDisable views login in 68 and put views login behind a feature/finch flag
,
Jun 1 2018
,
Jun 1 2018
,
Jun 2 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fa7d94e2e43962179abd1812a1bddc7f288cd4e commit 1fa7d94e2e43962179abd1812a1bddc7f288cd4e Author: Jacob Dufault <jdufault@google.com> Date: Mon Jun 04 18:24:00 2018 cros: Re-enable views-login by default. We will probably want to control this with a finch flag at some point. Bug: 848898 Change-Id: I4389a3a892aa42273f654ffc4c1fab3e6f480fdf Reviewed-on: https://chromium-review.googlesource.com/1083339 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#564156} [modify] https://crrev.com/1fa7d94e2e43962179abd1812a1bddc7f288cd4e/ash/public/cpp/ash_features.cc
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/128e5dd8bf9e283098b3aad22937b66c51096559 commit 128e5dd8bf9e283098b3aad22937b66c51096559 Author: Jacob Dufault <jdufault@google.com> Date: Mon Jun 04 18:49:26 2018 cros: Disable views-login, enable webui login. This CL also switches views login from a switch to a feature flag. This will be cherry-picked to m68, and a follow-up CL will re-enable views-login in m69. TBR=jdufault@google.com (cherry picked from commit 56f56840cb6126b4df949e700e79424557678df8) Bug: 848898 Change-Id: I5d6e48cb68f3c6f3af10561392a5b1c146b1a6fc Reviewed-on: https://chromium-review.googlesource.com/1083353 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563853} Reviewed-on: https://chromium-review.googlesource.com/1085696 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#152} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/128e5dd8bf9e283098b3aad22937b66c51096559/ash/public/cpp/ash_features.cc [modify] https://crrev.com/128e5dd8bf9e283098b3aad22937b66c51096559/ash/public/cpp/ash_features.h [modify] https://crrev.com/128e5dd8bf9e283098b3aad22937b66c51096559/ash/public/cpp/ash_switches.cc [modify] https://crrev.com/128e5dd8bf9e283098b3aad22937b66c51096559/ash/public/cpp/ash_switches.h [modify] https://crrev.com/128e5dd8bf9e283098b3aad22937b66c51096559/ash/shelf/shelf_widget.cc [modify] https://crrev.com/128e5dd8bf9e283098b3aad22937b66c51096559/ash/shelf/shelf_widget_unittest.cc [modify] https://crrev.com/128e5dd8bf9e283098b3aad22937b66c51096559/chrome/browser/chromeos/login/chrome_restart_request.cc [modify] https://crrev.com/128e5dd8bf9e283098b3aad22937b66c51096559/chrome/browser/chromeos/login/ui/login_display_host_webui.cc [modify] https://crrev.com/128e5dd8bf9e283098b3aad22937b66c51096559/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc [modify] https://crrev.com/128e5dd8bf9e283098b3aad22937b66c51096559/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
,
Jun 4 2018
I am wondering if this might clean up a bunch of the log in based crashes and such we have blocking 68?
,
Jun 5 2018
re #7: yes, it should unblock 68.
,
Jun 7 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jun 1 2018