Hey Jesse, can you get us a string for this case?  Something like:

Smart Lock is disabled on the login screen. To enable this feature, visit chrome://settings after logging in with your password.

I'll work with Jon Ann to find an appropriate string for this scenario.

Hiya, is there a screenshot of this for more context? I wasn't able to get to it from my phone or Pixelbook. Thanks!

Screenshot attached.

Deleted: MVIMG_20180605_143953.jpg 845 KB

	MVIMG_20180605_143953.jpg 845 KB View Download

Jon Ann, have we made any progress on this particular string? Thanks in advance!

We can tighten it up:

To turn on Smart Lock, sign in to your phone and go to Settings > Security & location.

Thank you, Jon Ann!

@Kyle, is there anything else you need here?

Hi folks - I think there was a bit of a misunderstanding about the string. Let me try to clarify:

* EasyUnlock has two modes: unlock a locked screen (i.e., after the user logs in, allow the user to unlock the laptop with only a phone), and sign into a session (i.e., before the user logs in, allow the user to bypass the login screen with only a phone).
* When EasyUnlock is set up, only the first mode is enabled by default. The second mode requires the user to opt into the feature explicitly in settings. The reasoning here is that the second mode is less secure.
* When EasyUnlock is set up to unlock but *not* sign in and the user gets to the sign-in screen, the message in Jesse's screenshot is displayed.

So, at the point this string is displayed, the user has already enabled Smart Lock on the phone side. The user does not need to do anything else on the phone side to configure the feature. Instead, if the user wants to enable automatic sign-in, the user needs to opt into the feature in Chrome OS settings, not Android settings.

Another thing to consider here is that many users simply do not want to opt into the sign-in mode. I know several engineers at Google who purposely do not enable the feature. It may be considered "spammy" to show this tooltip message every time the users is at the sign-in screen. Another thing we may want to consider is simply not showing a message at all, or, perhaps, only showing the message once (the first time the user is at the sign-in screen after enabling EasyUnlock) and not showing it on subsequent times.

+jonmann, who just came across this

Hi Jesse & Jon Ann - friendly ping here. We have gotten several more reports of this issue. Thanks!

Any particular reason this is RVG?

No particular reason for the RVG, James.

@Kyle, can we attack this from two fronts:

1) Reduce the frequency of displaying this notification to only the first time the user is at the sign-in screen after enabling EasyUnlock (your latter suggestion)

2) Change the string to read something akin to, "To use Smart Lock to sign in to your account, enable it in Settings > Connected devices > Better Together > Smart Lock"

For #2, I will ask Jon Ann to review the string above and note her approval/recommended changes here.

Thanks Jesse, here's my tweak:


To use Smart Lock to sign in to your Google Account, go to Settings > Connected devices > Better Together > Smart Lock

These suggestions SGTM. James, can you take this on?

Yeah, that's fine.

 Issue 885334  has been merged into this issue.

Just bumped into this issue while writing E2E tests. The language really confused me, and I'd like to test the string proposed in #14 for my E2E test, so I'm gonna take this issue. Should be a quick fix.

Note that the string in comment #14 is no longer accurate (no "Better Together" section anymore), so it should be updated.

Yep, noticed that, thanks. I chose "Your phone" instead in my CL [1], so it will read: "To use Smart Lock to sign in to your Google Account, go to Settings > Connected devices > Your phone > Smart Lock". 

Does that sound reasonable? Is there a precedent for how we've replaced "Better Together" in strings like this?


1) https://chromium-review.googlesource.com/c/chromium/src/+/1415377

Thanks Ryan, lgtm.

(to make sure: no period at the end of the string)

Spoke with Jon Ann offthread -- similar strings in this tooltip context end periods, so we'll keep a period in this case.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1120f8ed78e67a58f0c40ce3539f77fef51093d0

commit 1120f8ed78e67a58f0c40ce3539f77fef51093d0
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Wed Jan 16 23:39:19 2019

Smart Lock: Clarify language at sign-in screen when disabled.

Also clean up and refactor some nearby code and comments for
consistency.

Bug: 848893
Change-Id: Ia332e012fb0da1a54bcaeb235c99767a9d107f27
Reviewed-on: https://chromium-review.googlesource.com/c/1415377
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623451}
[modify] https://crrev.com/1120f8ed78e67a58f0c40ce3539f77fef51093d0/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/1120f8ed78e67a58f0c40ce3539f77fef51093d0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_metrics.h
[modify] https://crrev.com/1120f8ed78e67a58f0c40ce3539f77fef51093d0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler.cc
[modify] https://crrev.com/1120f8ed78e67a58f0c40ce3539f77fef51093d0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler.h
[modify] https://crrev.com/1120f8ed78e67a58f0c40ce3539f77fef51093d0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/1120f8ed78e67a58f0c40ce3539f77fef51093d0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/1120f8ed78e67a58f0c40ce3539f77fef51093d0/chromeos/components/proximity_auth/smart_lock_metrics_recorder.h
[modify] https://crrev.com/1120f8ed78e67a58f0c40ce3539f77fef51093d0/tools/metrics/histograms/enums.xml

One task left for this bug:

"Reduce the frequency of displaying this [tooltip] to only the first time the user is at the sign-in screen after enabling EasyUnlock"

Lowering priority again; I'm not actively working on this at the moment.