New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848892 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 831359



Sign in to add a comment

Weird boomerang effect in new Android horizontal tab switcher

Project Member Reported by rlanday@chromium.org, Jun 1 2018

Issue description

Selecting tab is weird

 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fd2cbbc47922191bd1d89977a26a7c0ad2983ee

commit 9fd2cbbc47922191bd1d89977a26a7c0ad2983ee
Author: Ryan Landay <rlanday@chromium.org>
Date: Fri Jun 01 21:49:24 2018

Clean up tab focus animation in new Android horizontal tab switcher

The new non-overlapping horizontal tab switcher on Android currently does a
weird boomerang/swooshing effect when you select a tab because we're
incorrectly doing a scroll offset animation that's only needed for the
overlapping tab switcher. This CL removes this animation for the non-overlapping
tab switcher to correct this effect.

Bug:  848892 ,831359
Change-Id: I1ef73960ed6189ef70cd8375a098131b7c03e245
Reviewed-on: https://chromium-review.googlesource.com/1083218
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563812}
[modify] https://crrev.com/9fd2cbbc47922191bd1d89977a26a7c0ad2983ee/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimationLandscape.java

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2018

Labels: merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/545828780f3517a89ce467fa0895087e42ba13c8

commit 545828780f3517a89ce467fa0895087e42ba13c8
Author: Ryan Landay <rlanday@chromium.org>
Date: Fri Jun 01 21:51:17 2018

Clean up tab focus animation in new Android horizontal tab switcher

The new non-overlapping horizontal tab switcher on Android currently does a
weird boomerang/swooshing effect when you select a tab because we're
incorrectly doing a scroll offset animation that's only needed for the
overlapping tab switcher. This CL removes this animation for the non-overlapping
tab switcher to correct this effect.

Bug:  848892 ,831359
Change-Id: I1ef73960ed6189ef70cd8375a098131b7c03e245
Reviewed-on: https://chromium-review.googlesource.com/1083218
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563812}(cherry picked from commit 9fd2cbbc47922191bd1d89977a26a7c0ad2983ee)
Reviewed-on: https://chromium-review.googlesource.com/1083512
Reviewed-by: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#102}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/545828780f3517a89ce467fa0895087e42ba13c8/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimationLandscape.java

Status: Fixed (was: Started)

Sign in to add a comment