ws: KSV app doesn't show a shelf item/button for the window. |
||
Issue descriptionws: KSV app doesn't show a shelf item/button for the window. (1) Run cros/simplechrome with --keyboard-shortcut-viewer-app (2) Open the KSV app (CTRL-ALT-/), wait for it to open Expected: The shelf should show an item for the window. Actual: The shelf doesn't show an item for the window.
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9df7c9f3cda93f5c32290113bb9568b6479352a7 commit 9df7c9f3cda93f5c32290113bb9568b6479352a7 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Fri Jun 08 14:22:48 2018 ws2: Show KSV app icon on shelf KSV app registers ash specific window properties and sets up to use MusPropertyMirrorAsh. ShelfWindowWatcher is then able to take care of the rest. Also make InternalAppWindowShelfController to ignore visibility change for windows it does not observe. Otherwise, it crashes when it attempts to manage the content window from KSV app. Bug: 848884 Change-Id: Ib9c1e46eb3f39bdda4e66529d0497a4ef775b80f Reviewed-on: https://chromium-review.googlesource.com/1091799 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#565625} [modify] https://crrev.com/9df7c9f3cda93f5c32290113bb9568b6479352a7/ash/components/shortcut_viewer/shortcut_viewer_application.cc [modify] https://crrev.com/9df7c9f3cda93f5c32290113bb9568b6479352a7/chrome/browser/ui/ash/launcher/internal_app_window_shelf_controller.cc
,
Jun 8 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by sky@chromium.org
, Jun 4 2018Status: Assigned (was: Available)