New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848881 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 732555



Sign in to add a comment

Fling doesn't work on Android+Viz

Project Member Reported by samans@chromium.org, Jun 1 2018

Issue description

Fling doesn't work on Android when Viz is enabled.
 
Labels: Android-OOPD-Finch
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2018

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d53de12370ee682edb3353852af4571e2374f5a

commit 7d53de12370ee682edb3353852af4571e2374f5a
Author: Saman Sami <samans@chromium.org>
Date: Mon Jun 11 23:58:30 2018

Add Android implementation for FlingScheduler

RenderWidgetHostImpl doesn't receive BeginFrames when Viz is enabled,
so create an implementation for FlingScheduler that receives animation
ticks from WindowAndroid.

viz is enabled. Viz tests are not enabled yet but are being worked
on ( crbug.com/849746 ).

Test: Any existing fling test should test FlingSchedulerAndroid when
Bug:  848881 
Change-Id: I1655b7e5402f91178e286f3c64f57d00ccb6eb19
Reviewed-on: https://chromium-review.googlesource.com/1089144
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566211}
[modify] https://crrev.com/7d53de12370ee682edb3353852af4571e2374f5a/content/browser/BUILD.gn
[modify] https://crrev.com/7d53de12370ee682edb3353852af4571e2374f5a/content/browser/renderer_host/input/fling_scheduler.h
[add] https://crrev.com/7d53de12370ee682edb3353852af4571e2374f5a/content/browser/renderer_host/input/fling_scheduler_android.cc
[add] https://crrev.com/7d53de12370ee682edb3353852af4571e2374f5a/content/browser/renderer_host/input/fling_scheduler_android.h
[add] https://crrev.com/7d53de12370ee682edb3353852af4571e2374f5a/content/browser/renderer_host/input/fling_scheduler_base.h
[modify] https://crrev.com/7d53de12370ee682edb3353852af4571e2374f5a/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/7d53de12370ee682edb3353852af4571e2374f5a/content/browser/renderer_host/render_widget_host_impl.h

Comment 4 by samans@chromium.org, Jun 12 2018

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 18 2018

Labels: merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c03f560623de99ece6ab85d7e9c137012340808

commit 0c03f560623de99ece6ab85d7e9c137012340808
Author: Sahel Sharify <sahel@chromium.org>
Date: Mon Jun 18 20:21:47 2018

Move observing ui::Compositor from FlingController to FlingScheduler

This should make it easier to have an Android implementation where
ui::Compositor is not available.

(cherry picked from commit 991984ee8f4bddf51105084ecba84625c4f5be57)
TBR=samans@chromium.org,dtapsuka@chromium.org

Bug:  848881 , 851719
Change-Id: Ib7838f53b0935bf178954f1aa64bbf777cae3b6d
Reviewed-on: https://chromium-review.googlesource.com/1087807
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#565053}
Reviewed-on: https://chromium-review.googlesource.com/1105029
Cr-Commit-Position: refs/branch-heads/3440@{#412}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/0c03f560623de99ece6ab85d7e9c137012340808/content/browser/renderer_host/input/fling_controller.cc
[modify] https://crrev.com/0c03f560623de99ece6ab85d7e9c137012340808/content/browser/renderer_host/input/fling_controller.h
[modify] https://crrev.com/0c03f560623de99ece6ab85d7e9c137012340808/content/browser/renderer_host/input/fling_scheduler.cc
[modify] https://crrev.com/0c03f560623de99ece6ab85d7e9c137012340808/content/browser/renderer_host/input/fling_scheduler.h
[modify] https://crrev.com/0c03f560623de99ece6ab85d7e9c137012340808/content/browser/renderer_host/input/fling_scheduler_unittest.cc

Comment 6 by sahel@chromium.org, Jun 18 2018

Labels: Merge-Request-68
I merged the code landed in comment #2 to M68. The reason for merge was fixing the crash on crbug.com/851719 since with the refactoring in comment #2 the crash signature code doesn't exist anymore. The fix in comment #2 has landed in June 6th and is safe to merge to 68 (I updated https://chromium.googlesource.com/chromium/src/+/0c03f560623de99ece6ab85d7e9c137012340808/content/browser/renderer_host/input/fling_scheduler.cc#81 to check the controller before calling progress).

Asking for merge request now since I forgot to ask for permission before merging, if it gets rejected, I will revert the patch on M68. 
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 18 2018

Labels: -Merge-Request-68 Merge-Reject-68 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M68 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment