Infobar action buttons need highlight effect. |
|||||||||||||
Issue descriptionFrom pschaffner ( issue 843571 comment 10): As for the action buttons ... I noticed we lost the highlight effect on the non-primary button. I wouldn't mind getting rid of the ink effect (on both buttons) and applying the same solution mentioned above for the close button. I'm also fine keeping the ink effect if it is easier to just reinstate it on the non-primary button. In the end, the important thing here is to *have* a highlight state for all buttons.
,
Jun 1 2018
,
Jun 27 2018
,
Aug 7
Moving infobar bugs into M70.
,
Aug 20
You did not specify what the highlighted state/color should be. I just used a default. See if this is what you are thinking of. See screen recording: https://drive.google.com/file/d/1IskVlnIVya40VT2ysuqIjypqWP2JY-TW/view?usp=sharing
,
Aug 20
,
Aug 21
+pschaffner +martijnb: Please see video https://drive.google.com/open?id=1KPbihk06PtMAicZt5NTjPip9jwoeZl7Q This is the infobar button as it exists today. There's the ink splash. There's a lightening of the button color. Is this the "highlight" effect you are talking about? The button is a MDCFlatButton, so it is not possible to do the same thing as the Close (X) as in issue 848879 .
,
Aug 23
,
Aug 23
,
Aug 29
Pete: Any updates here? There was also this discussion about MD audit so I would like to make sure we don't have to do things twice.
,
Aug 30
Sorry for the delay. What pkl@ has implemented and shows in #7 is fine.
,
Sep 7
Please check 71.0.3544.0 canary or later. Seems fine to me.
,
Oct 1
Issue verified Version: Chrome Beta 70.0.3538.40 Device: iPhone X iOS: 12.0 Correct Highlighted effect on infobar action button as per comment #7 https://drive.google.com/open?id=1Kcg55IKK03WNjT0MfkmdhFoXKyNiDg8O |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by pkl@chromium.org
, Jun 1 2018